GNU bug report logs

#42129 guix-install.sh does not add build users to kvm group

PackageSource(s)Maintainer(s)
guix PTS Buildd Popcon
Reply or subscribe to this bug. View this bug as an mbox, status mbox, or maintainer mbox

Report forwarded to bug-guix@gnu.org:
bug#42129; Package guix. (Mon, 29 Jun 2020 20:03:02 GMT) (full text, mbox, link).

Acknowledgement sent to Marius Bakke <marius@gnu.org>:
New bug report received and forwarded. Copy sent to bug-guix@gnu.org. (Mon, 29 Jun 2020 20:03:02 GMT) (full text, mbox, link).

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Marius Bakke <marius@gnu.org>
To: bug-guix@gnu.org
Subject: guix-install.sh does not add build users to kvm group
Date: Mon, 29 Jun 2020 22:01:54 +0200
[Message part 1 (text/plain, inline)]
Hello,

guix-install.sh should add the build users to the 'kvm' group if present
so that commands that require use of KVM can succeed.

[signature.asc (application/pgp-signature, inline)]

Severity set to 'important' from 'normal' Request was from Ludovic Courtès <ludo@gnu.org> to control@debbugs.gnu.org. (Thu, 01 Apr 2021 13:22:02 GMT) (full text, mbox, link).

Added tag(s) easy. Request was from Ludovic Courtès <ludo@gnu.org> to control@debbugs.gnu.org. (Fri, 02 Apr 2021 07:47:02 GMT) (full text, mbox, link).

Added indication that bug 42129 blocks47297 Request was from Ludovic Courtès <ludo@gnu.org> to control@debbugs.gnu.org. (Fri, 02 Apr 2021 07:47:02 GMT) (full text, mbox, link).

Information forwarded to bug-guix@gnu.org:
bug#42129; Package guix. (Thu, 08 Apr 2021 22:40:02 GMT) (full text, mbox, link).

Message #14 received at 42129@debbugs.gnu.org (full text, mbox, reply):

From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <marius@gnu.org>
Cc: 42129@debbugs.gnu.org
Subject: Re: bug#42129: guix-install.sh does not add build users to kvm group
Date: Thu, 8 Apr 2021 18:38:59 -0400
[Message part 1 (text/plain, inline)]
On Mon, Jun 29, 2020 at 10:01:54PM +0200, Marius Bakke wrote:
> guix-install.sh should add the build users to the 'kvm' group if present
> so that commands that require use of KVM can succeed.

Here is a patch (untested) that makes sure a 'kvm' group exists and adds
it to the guixbuilders' groups.

[0001-guix-install.sh-Add-the-build-users-to-the-kvm-group.patch (text/plain, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-guix@gnu.org:
bug#42129; Package guix. (Thu, 08 Apr 2021 23:04:02 GMT) (full text, mbox, link).

Message #17 received at 42129@debbugs.gnu.org (full text, mbox, reply):

From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <marius@gnu.org>
Cc: 42129@debbugs.gnu.org
Subject: Re: bug#42129: guix-install.sh does not add build users to kvm group
Date: Thu, 8 Apr 2021 19:03:26 -0400
[Message part 1 (text/plain, inline)]
On Thu, Apr 08, 2021 at 06:38:59PM -0400, Leo Famulari wrote:
> On Mon, Jun 29, 2020 at 10:01:54PM +0200, Marius Bakke wrote:
> > guix-install.sh should add the build users to the 'kvm' group if present
> > so that commands that require use of KVM can succeed.
> 
> Here is a patch (untested) that makes sure a 'kvm' group exists and adds
> it to the guixbuilders' groups.

I realized that you specified that the build users should be added to
the kvm group 'if' it is present. So, here is a revised patch.

[v2-0001-guix-install.sh-Add-the-build-users-to-the-kvm-gr.patch (text/plain, attachment)]
[signature.asc (application/pgp-signature, inline)]

Reply sent to Leo Famulari <leo@famulari.name>:
You have taken responsibility. (Wed, 14 Apr 2021 19:34:01 GMT) (full text, mbox, link).

Notification sent to Marius Bakke <marius@gnu.org>:
bug acknowledged by developer. (Wed, 14 Apr 2021 19:34:02 GMT) (full text, mbox, link).

Message #22 received at 42129-done@debbugs.gnu.org (full text, mbox, reply):

From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <marius@gnu.org>
Cc: 42129-done@debbugs.gnu.org
Subject: Re: bug#42129: guix-install.sh does not add build users to kvm group
Date: Wed, 14 Apr 2021 15:33:46 -0400
[Message part 1 (text/plain, inline)]
On Thu, Apr 08, 2021 at 07:03:26PM -0400, Leo Famulari wrote:
> From 1a9fd7decd843f21c36d8ec4d1e218f478b983cf Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Thu, 8 Apr 2021 18:34:43 -0400
> Subject: [PATCH v2] guix-install.sh: Add the build users to the 'kvm' group.
> 
> * etc/guix-install.sh (sys_create_build_user): If a 'kvm' group exists,
> add it to the guixbuilders' lists of supplementary groups.

I tested, fixed bugs, and pushed as 8e214c53a48a841887a59f24a20e7392b5e59b55

[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs@gnu.org> to internal_control@debbugs.gnu.org. (Thu, 13 May 2021 11:24:04 GMT) (full text, mbox, link).

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 03:31:51 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.