#27475 Add kashmir, crypto++, opendht-with-msgpack-c++-11, and some updates.

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Adonay Felipe Nogueira <adfeno@openmailbox.org>

To: guix-patches@gnu.org

Subject: Add kashmir, crypto++, opendht-with-msgpack-c++-11, and some updates.

Date: Sat, 24 Jun 2017 13:26:48 -0300

[Message part 1 (text/plain, inline)]

Hi Guix! :)

Here follows a series of patches, it's part of the attempt to package
GNU Ring. However, these contributions don't need custom patches from
Savir Faire Linux. The only doubt is in regards to the need to have a
variant of msgpack that uses C++ 11 instead, and have a variant of
opendht that makes use of such msgpack variant instead.


Respectfully, Adonay.
-- 
- [[https://libreplanet.org/wiki/User:Adfeno]]
- Palestrante e consultor sobre /software/ livre (não confundir com
  gratis).
- "WhatsApp"? Ele não é livre, por isso não uso. Iguais a ele prefiro
  GNU Ring, ou Tox. Quer outras formas de contato? Adicione o vCard
  que está no endereço acima aos teus contatos.
- Pretende me enviar arquivos .doc, .ppt, .cdr, ou .mp3? OK, eu
  aceito, mas não repasso. Entrego apenas em formatos favoráveis ao
  /software/ livre. Favor entrar em contato em caso de dúvida.

[gnu packages cpp (kashmir).patch (text/x-diff, attachment)]

[gnu packages crypto (crypto++).patch (text/x-diff, attachment)]

[gnu packages crypto (opendht opendht-with-msgpack-c++-11) serialization (msgpack-c++-11).patch (text/x-diff, attachment)]

[gnu packages password-utils (argon2).patch (text/x-diff, attachment)]

Message #8 received at 27475@debbugs.gnu.org (full text, mbox, reply):

From: Adonay Felipe Nogueira <adfeno@openmailbox.org>

To: 27475@debbugs.gnu.org

Subject: Re: [bug#27475] Add kashmir, crypto++, opendht-with-msgpack-c++-11, and some updates.

Date: Sat, 22 Jul 2017 17:59:27 -0300

Strange, no comments so far?

Message #13 received at 27475@debbugs.gnu.org (full text, mbox, reply):

From: Christopher Baines <mail@cbaines.net>

To: Adonay Felipe Nogueira <adfeno@openmailbox.org>

Cc: 27475@debbugs.gnu.org

Subject: Re: [bug#27475] Add kashmir, crypto++, opendht-with-msgpack-c++-11, and some updates.

Date: Wed, 11 Oct 2017 18:22:54 +0100

[Message part 1 (text/plain, inline)]

On Sat, 24 Jun 2017 13:26:48 -0300
Adonay Felipe Nogueira <adfeno@openmailbox.org> wrote:

> Here follows a series of patches, it's part of the attempt to package
> GNU Ring. However, these contributions don't need custom patches from
> Savir Faire Linux. The only doubt is in regards to the need to have a
> variant of msgpack that uses C++ 11 instead, and have a variant of
> opendht that makes use of such msgpack variant instead.

I've just noticed that no one has taken a look at this yet! Not quite
sure how that has happened. Here are my comments.

The first general comment is that these patches don't quite apply now,
so it would be useful to send another set which do apply cleanly.

Starting with the kashmir package.

> +     (source (origin
> +	      (method url-fetch)
> +	      (uri (string-append "https://github.com/Corvusoft/"
> name
> +				  "-dependency/archive/" commit
> ".tar.gz"))
> +	      (file-name (string-append name "-" version ".tar.gz"))
> +	      (sha256
> +	       (base32
> +		"11hbh3d7w74gng9qgz3hdrzvxjgil1pymk2bzxv1ajh9vp60xxs9"))))

Looks like this patch may have got caught up in the recent hash changes
from GitHub. I had to change the sha256 before this would build.

The directory structure in this package looks a little odd. The Debian
package has kashmir-dependency/kashmir as include/kashmir, which might
be a little more usual.

guix lint also reports some issues:

/home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4: kashmir@0-1.2f3913f: tabulation on line 39, column 0
+ more tab issues
/home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4: kashmir@0-1.2f3913f: tabulation on line 71, column 0
/home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4: kashmir@0-1.2f3913f: line 72 is way too long (98 characters)
/home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4: kashmir@0-1.2f3913f: line 73 is way too long (176 characters)


As for the crypto++ package.

guix lint reports lots of tabs.

> +		       (add-after 'build 'build-shared
> +				  (lambda _
> +				    ;; By default, only the static
> +				    ;; library is built.
> +				    (zero?
> +				     (system* "make" "shared"))))

I think you could get rid of this phase by adding "shared" to the
#:make-flags.

I'm not sure why the binary is has .exe in the name? Even
the inbuilt help calls it cryptest:

  Unrecognized command. Run "cryptest h" to obtain usage information.

I have no idea what this does, but running it in a container fails, as
it seems to be looking for data in the doc output:

  → guix environment --container --ad-hoc crypto++:bin -- cryptest.exe
  CryptoPP::Exception caught: FileStore: error opening file for reading:
 TestData/usage.dat


On to the opendht update.

> +  (let ((release "1.3.3")
> +	(revision 5))

I'm not why this revision is being used?

Also, with the msgpack-c++-11 package, I built both msgpack and
msgpack-c++-11 and diffed the contents with diffoscope, and they are
practically identical as far as I can see. I'm guessing there was
supposed to be a difference?


Last but not least, for the argon2 package, for which I don't have any
questions or suggestions. Ignoring the tabs, I think it looks fine.

I hope this helps Adonay :)

[Message part 2 (application/pgp-signature, inline)]

Message #16 received at 27475@debbugs.gnu.org (full text, mbox, reply):

From: Adonay Felipe Nogueira <adfeno@hyperbola.info>

To: 27475@debbugs.gnu.org

Subject: Re: [bug#27475] Add kashmir, crypto++, opendht-with-msgpack-c++-11, and some updates.

Date: Wed, 22 Nov 2017 00:16:08 -0200

[Message part 1 (text/plain, inline)]

Thank you very much for the feedback! ;)

Here follows an updated patch.

The "release-revision.commit" is taken from [1], I just kept 'revision
as a number when let'ing, and now in this new patch also attempted to
make it so that 'version has checks for the existance of 'revision and
'commit.

As for any other detail (including: whether the msgpack "c++-11" variant
is really needed; or if the "upcoming" packages for GNU Ring will work
if these package definitions are based on the *stable* releases and what
are the drawbacks), I'll unfortunatelly not be able to answer these, as
I'm not a developer of these packages (neither of GNU Ring).

From here on you will be reading text that deserves to be discussed in
another thread.

Some months ago I made an implicit mention of GNU Guix in the GNU Ring
discussion resources, but so far I'm not aware of GNU Ring project
making package definitions for GNU Guix.

There are lots of people interested in using GNU Ring and I was also
made aware that some people downloaded the patches I made for
Guix. Although I don't know what those people interested do or what are
their current limitations, but at least in my case, I'm not a developer
and currently have some time constraints (because I'm looking for a job
and also having to work on my Bachelor's final work).

[1] [[info:guix#Version Numbers]]

[0001-Update-opendht-argon2.-Add-kashmir-secp256k1-opendht.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

2017-10-11T17:22:54+0100 Christopher Baines wrote:
>
> I've just noticed that no one has taken a look at this yet! Not quite
> sure how that has happened. Here are my comments.
>
> The first general comment is that these patches don't quite apply now,
> so it would be useful to send another set which do apply cleanly.
>
> Starting with the kashmir package.
>
>
> Looks like this patch may have got caught up in the recent hash changes
> from GitHub. I had to change the sha256 before this would build.
>
> The directory structure in this package looks a little odd. The Debian
> package has kashmir-dependency/kashmir as include/kashmir, which might
> be a little more usual.
>
> guix lint also reports some issues:
>
> /home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4:
> kashmir@0-1.2f3913f: tabulation on line 39, column 0
> + more tab issues
> /home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4:
> kashmir@0-1.2f3913f: tabulation on line 71, column 0
> /home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4:
> kashmir@0-1.2f3913f: line 72 is way too long (98 characters)
> /home/chris/.config/guix/latest/gnu/packages/cpp.scm:36:4:
> kashmir@0-1.2f3913f: line 73 is way too long (176 characters)
>
>
> As for the crypto++ package.
>
> guix lint reports lots of tabs.
>
>
> I think you could get rid of this phase by adding "shared" to the
> #:make-flags.
>
> I'm not sure why the binary is has .exe in the name? Even
> the inbuilt help calls it cryptest:
>
>   Unrecognized command. Run "cryptest h" to obtain usage information.
>
> I have no idea what this does, but running it in a container fails, as
> it seems to be looking for data in the doc output:
>
>   → guix environment --container --ad-hoc crypto++:bin -- cryptest.exe
>   CryptoPP::Exception caught: FileStore: error opening file for reading:
>  TestData/usage.dat
>
>
> On to the opendht update.
>
>
> I'm not why this revision is being used?
>
> Also, with the msgpack-c++-11 package, I built both msgpack and
> msgpack-c++-11 and diffed the contents with diffoscope, and they are
> practically identical as far as I can see. I'm guessing there was
> supposed to be a difference?
>
>
> Last but not least, for the argon2 package, for which I don't have any
> questions or suggestions. Ignoring the tabs, I think it looks fine.
>
> I hope this helps Adonay :)

-- 
- https://libreplanet.org/wiki/User:Adfeno
- Palestrante e consultor sobre /software/ livre (não confundir com
  gratis).
- "WhatsApp"? Ele não é livre. Por favor, veja formas de se comunicar
  instantaneamente comigo no endereço abaixo.
- Contato: https://libreplanet.org/wiki/User:Adfeno#vCard
- Arquivos comuns aceitos (apenas sem DRM): Corel Draw, Microsoft
  Office, MP3, MP4, WMA, WMV.
- Arquivos comuns aceitos e enviados: CSV, GNU Dia, GNU Emacs Org, GNU
  GIMP, Inkscape SVG, JPG, LibreOffice (padrão ODF), OGG, OPUS, PDF
  (apenas sem DRM), PNG, TXT, WEBM.

Message #27 received at 27475-done@debbugs.gnu.org (full text, mbox, reply):

From: Leo Famulari <leo@famulari.name>

To: Adonay Felipe Nogueira <adfeno@openmailbox.org>

Cc: 27475-done@debbugs.gnu.org

Subject: Re: [bug#27475] Add kashmir, crypto++, opendht-with-msgpack-c++-11, and some updates.

Date: Tue, 12 Feb 2019 18:57:49 -0500

[Message part 1 (text/plain, inline)]

Like the other batch of old Ring patches, I'm closing this bug ticket
because there is a new effort to package Ring / Jami in our Git repo:

https://git.savannah.gnu.org/cgit/guix.git/log/?h=wip-ring

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.