Acknowledgement sent
to Leo Famulari <leo@famulari.name>:
New bug report received and forwarded. Copy sent to guix-patches@gnu.org.
(Tue, 13 Jul 2021 23:01:01 GMT) (full text, mbox, link).
Added indication that bug 49556 blocks46602
Request was from Leo Famulari <leo@famulari.name>
to control@debbugs.gnu.org.
(Tue, 13 Jul 2021 23:02:02 GMT) (full text, mbox, link).
Information forwarded
to guix-patches@gnu.org: bug#49556; Package guix-patches.
(Tue, 13 Jul 2021 23:03:01 GMT) (full text, mbox, link).
Hi Leo,
Leo Famulari <leo@famulari.name> writes:
> Updating to this unreleased revision allows us to package VDE 2 with
> wolfSSL instead of the obsolete OpenSSL 1.0:
>
> https://github.com/virtualsquare/vde-2/issues/2
>
> * gnu/packages/networking.scm (vde2): Update to 2.3.2-0.8599321.
> [source]: Use git-fetch.
> [native-inputs]: Add autoconf, automake, and libtool
> [inputs]: Replace openssl-1.0 with wolfssl.
[...]
I've tried building this and it looks like the configure script fails to
detect wolfSSL (the build still succeeds, but "VDE CryptCab" is
disabled):
--8<---------------cut here---------------start------------->8---
Configure results:
- VDE CryptCab............ disabled
+ VDE Router.............. enabled
+ VDE VXLAN............... enabled
+ Python Libraries........ enabled
+ TAP support............. enabled
+ pcap support............ enabled
- Experimental features... disabled
- Profiling options....... disabled
- Kernel switch........... disabled
configure: WARNING: VDE CryptCab support has been disabled because wolfSSL is
not installed on your system, or because wolfssl/wolfcrypt/chacha.h could not be found.
Please install libwolfssl if you want CryptCab to be compiled and installed.
--8<---------------cut here---------------end--------------->8---
I suspect the following lines in configure.ac are the culprit:
--8<---------------cut here---------------start------------->8---
AC_CHECK_LIB([crypto], [EVP_EncryptInit],
[add_cryptcab_support=yes],
[add_cryptcab_support=no ; warn_cryptcab=yes])
--8<---------------cut here---------------end--------------->8---
This might've been overlooked when switching from OpenSSL to wolfSSL,
since libcrypto is provided by the former, but not the latter. They
should probably be changed to something like this instead:
--8<---------------cut here---------------start------------->8---
AC_CHECK_LIB([wolfssl], [wc_Chacha_Process],
[add_cryptcab_support=yes],
[add_cryptcab_support=no ; warn_cryptcab=yes])
--8<---------------cut here---------------end--------------->8---
I'll report this issue upstream.
Regards,
Diego
Information forwarded
to guix-patches@gnu.org: bug#49556; Package guix-patches.
(Tue, 03 Aug 2021 22:05:02 GMT) (full text, mbox, link).
On Tue, Aug 03, 2021 at 06:01:33PM +0000, Diego Nicola Barbato wrote:
> I suspect the following lines in configure.ac are the culprit:
>
> --8<---------------cut here---------------start------------->8---
> AC_CHECK_LIB([crypto], [EVP_EncryptInit],
> [add_cryptcab_support=yes],
> [add_cryptcab_support=no ; warn_cryptcab=yes])
> --8<---------------cut here---------------end--------------->8---
Thanks for catching that!
> I'll report this issue upstream.
Okay, please share the link to your report once you have made it.
Information forwarded
to guix-patches@gnu.org: bug#49556; Package guix-patches.
(Tue, 03 Aug 2021 23:58:02 GMT) (full text, mbox, link).
I made the changes to VDE-2's configure.ac that Diego suggested, and
VDE-2 does register the presence of wolfSSL and configure the build to
use it for cryptcab.
Please refer to the following v2 patch series.
Leo Famulari (2):
gnu: Add wolfSSL.
gnu: VDE 2: Update to 2.3.2-0.8599321.
gnu/packages/networking.scm | 35 +++++++++++++++++++++++++++--------
gnu/packages/tls.scm | 34 +++++++++++++++++++++++++++++++++-
2 files changed, 60 insertions(+), 9 deletions(-)
--
2.32.0
Information forwarded
to guix-patches@gnu.org: bug#49556; Package guix-patches.
(Tue, 03 Aug 2021 23:58:02 GMT) (full text, mbox, link).
Hi Leo,
Leo Famulari <leo@famulari.name> writes:
> On Tue, Aug 03, 2021 at 06:01:33PM +0000, Diego Nicola Barbato wrote:
>> I suspect the following lines in configure.ac are the culprit:
>>
>> --8<---------------cut here---------------start------------->8---
>> AC_CHECK_LIB([crypto], [EVP_EncryptInit],
>> [add_cryptcab_support=yes],
>> [add_cryptcab_support=no ; warn_cryptcab=yes])
>> --8<---------------cut here---------------end--------------->8---
>
> Thanks for catching that!
>
>> I'll report this issue upstream.
>
> Okay, please share the link to your report once you have made it.
I've submitted a pull request:
https://github.com/virtualsquare/vde-2/pull/27
Regards,
Diego
Reply sent
to Leo Famulari <leo@famulari.name>:
You have taken responsibility.
(Wed, 11 Aug 2021 19:48:02 GMT) (full text, mbox, link).
Notification sent
to Leo Famulari <leo@famulari.name>:
bug acknowledged by developer.
(Wed, 11 Aug 2021 19:48:02 GMT) (full text, mbox, link).
On Thu, Aug 05, 2021 at 03:37:47PM +0000, Diego Nicola Barbato wrote:
> Hi Leo,
>
> Leo Famulari <leo@famulari.name> writes:
>
> > On Tue, Aug 03, 2021 at 06:01:33PM +0000, Diego Nicola Barbato wrote:
> >> I suspect the following lines in configure.ac are the culprit:
> >>
> >> --8<---------------cut here---------------start------------->8---
> >> AC_CHECK_LIB([crypto], [EVP_EncryptInit],
> >> [add_cryptcab_support=yes],
> >> [add_cryptcab_support=no ; warn_cryptcab=yes])
> >> --8<---------------cut here---------------end--------------->8---
> >
> > Thanks for catching that!
> >
> >> I'll report this issue upstream.
> >
> > Okay, please share the link to your report once you have made it.
>
> I've submitted a pull request:
> https://github.com/virtualsquare/vde-2/pull/27
They accepted your patch.
I've added the wolfSSL package and updated VDE-2 to include your fix,
with commit e6388b48f3df21b792cd61f93fddc7274238bac6
bug archived.
Request was from Debbugs Internal Request <help-debbugs@gnu.org>
to internal_control@debbugs.gnu.org.
(Thu, 09 Sep 2021 11:24:06 GMT) (full text, mbox, link).
Debbugs is free software and licensed under the terms of the
GNU Public License version 2. The current version can be
obtained from https://bugs.debian.org/debbugs-source/.