[PATCH] fix build ola

  • Done
  • quality assurance status badge
Details
2 participants
  • Andreas Enge
  • Rick Huijzer
Owner
unassigned
Submitted by
Rick Huijzer
Severity
normal

Debbugs page

R
R
Rick Huijzer wrote on 25 Jul 03:24 -0700
(address . guix-patches@gnu.org)(name . Rick Huijzer)(address . ikbenrickhuyzer@gmail.com)
20250725103041.25193-1-ikbenrickhuyzer@gmail.com
---
Maybe not the most elegant fix, but the next version of ola will target a newer
c++. At the moment ola doesn't build at all.
gnu/packages/lighting.scm | 36 +++++++++++++++++-------------------
1 file changed, 17 insertions(+), 19 deletions(-)

Toggle diff (55 lines)
diff --git a/gnu/packages/lighting.scm b/gnu/packages/lighting.scm
index 4794400e6e..77f1aade53 100644
--- a/gnu/packages/lighting.scm
+++ b/gnu/packages/lighting.scm
@@ -50,31 +50,29 @@ (define-public ola
(base32 "0mbf5dc309pqg9ckqgk2kh9p3mf9vqsjkxnwjzqw7yzzf17ij3zk"))
(file-name (git-file-name name version))))
(build-system gnu-build-system)
- (native-inputs
- (list bison
- cppunit
- flex
- pkg-config
- ;; For git repository bootstrapping.
- autoconf
- automake
- libtool))
- (inputs
- (list libftdi
- libmicrohttpd
- libusb
- `(,util-linux "lib")
- zlib))
- (propagated-inputs
- (list protobuf)) ; for pkg-config --libs libola
+ (native-inputs (list bison
+ cppunit
+ flex
+ pkg-config
+ ;; For git repository bootstrapping.
+ autoconf
+ automake
+ libtool))
+ (inputs (list libftdi libmicrohttpd libusb
+ `(,util-linux "lib") zlib))
+ (propagated-inputs (list protobuf)) ;for pkg-config --libs libola
(arguments
(list
;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing
;; build to fail on low memory systems. We disable that with the
;; following configure flags.
- #:configure-flags #~(list "CXXFLAGS=-ftrack-macro-expansion=0")))
+ ;; We also have to omit: use of std::auto_ptr is deprecated, and template-id not allowed for constructor in C++20
+ #:configure-flags
+ #~(list
+ "CXXFLAGS=-ftrack-macro-expansion=0 -Wno-error=deprecated-declarations -Wno-template-id-cdtor")))
(synopsis "Framework for controlling entertainment lighting equipment")
- (description "The Open Lighting Architecture is a framework for lighting
+ (description
+ "The Open Lighting Architecture is a framework for lighting
control information. It supports a range of protocols and over a dozen USB
devices. It can run as a standalone service, which is useful for converting
signals between protocols, or alternatively using the OLA API, it can be used
--
2.50.1
A
A
Andreas Enge wrote on 26 Jul 10:04 -0700
(name . Rick Huijzer)(address . ikbenrickhuyzer@gmail.com)(address . 79092-done@debbugs.gnu.org)
aIUKi0A0Hc31dKSB@jurong
Hello,

thanks for your patch, which I have just pushed.

In the future, please refrain from making cosmetic changes like
reformatting; it makes it more difficult to see what are the real
changes, and also confuse "git blame".

Andreas
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 79092@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 79092
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch