#79092 [PATCH] fix build ola

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Rick Huijzer <ikbenrickhuyzer@gmail.com>

To: guix-patches@gnu.org

Cc: Rick Huijzer <ikbenrickhuyzer@gmail.com>

Subject: [PATCH] fix build ola

Date: Fri, 25 Jul 2025 12:24:48 +0200

---
Maybe not the most elegant fix, but the next version of ola will target a newer
c++. At the moment ola doesn't build at all.
 gnu/packages/lighting.scm | 36 +++++++++++++++++-------------------
 1 file changed, 17 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/lighting.scm b/gnu/packages/lighting.scm
index 4794400e6e..77f1aade53 100644
--- a/gnu/packages/lighting.scm
+++ b/gnu/packages/lighting.scm
@@ -50,31 +50,29 @@ (define-public ola
         (base32 "0mbf5dc309pqg9ckqgk2kh9p3mf9vqsjkxnwjzqw7yzzf17ij3zk"))
        (file-name (git-file-name name version))))
     (build-system gnu-build-system)
-    (native-inputs
-     (list bison
-           cppunit
-           flex
-           pkg-config
-           ;; For git repository bootstrapping.
-           autoconf
-           automake
-           libtool))
-    (inputs
-     (list libftdi
-           libmicrohttpd
-           libusb
-           `(,util-linux "lib")
-           zlib))
-    (propagated-inputs
-     (list protobuf))       ; for pkg-config --libs libola
+    (native-inputs (list bison
+                         cppunit
+                         flex
+                         pkg-config
+                         ;; For git repository bootstrapping.
+                         autoconf
+                         automake
+                         libtool))
+    (inputs (list libftdi libmicrohttpd libusb
+                  `(,util-linux "lib") zlib))
+    (propagated-inputs (list protobuf)) ;for pkg-config --libs libola
     (arguments
      (list
       ;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing
       ;; build to fail on low memory systems.  We disable that with the
       ;; following configure flags.
-      #:configure-flags #~(list "CXXFLAGS=-ftrack-macro-expansion=0")))
+      ;; We also have to omit: use of std::auto_ptr is deprecated, and template-id not allowed for constructor in C++20
+      #:configure-flags
+      #~(list
+         "CXXFLAGS=-ftrack-macro-expansion=0 -Wno-error=deprecated-declarations -Wno-template-id-cdtor")))
     (synopsis "Framework for controlling entertainment lighting equipment")
-    (description "The Open Lighting Architecture is a framework for lighting
+    (description
+     "The Open Lighting Architecture is a framework for lighting
 control information.  It supports a range of protocols and over a dozen USB
 devices.  It can run as a standalone service, which is useful for converting
 signals between protocols, or alternatively using the OLA API, it can be used
-- 
2.50.1

Message #10 received at 79092-done@debbugs.gnu.org (full text, mbox, reply):

From: Andreas Enge <andreas@enge.fr>

To: Rick Huijzer <ikbenrickhuyzer@gmail.com>

Cc: 79092-done@debbugs.gnu.org

Subject: Re: [PATCH] fix build ola

Date: Sat, 26 Jul 2025 19:04:11 +0200

Hello,

thanks for your patch, which I have just pushed.

In the future, please refrain from making cosmetic changes like
reformatting; it makes it more difficult to see what are the real
changes, and also confuse "git blame".

Andreas

Send a report that this bug log contains spam.