[PATCH] gnu: Add emacs-vhdl-mode.

  • Done
  • quality assurance status badge
Details
2 participants
  • Cayetano Santos
  • Maxim Cournoyer
Owner
unassigned
Submitted by
Cayetano Santos
Severity
normal

Debbugs page

C
C
Cayetano Santos wrote on 11 Jan 06:51 -0800
(address . guix-patches@gnu.org)(name . Cayetano Santos)(address . csantosb@inventati.org)
35e5d37a5caef4732d5b42bc6447160fd28c1e98.1704984698.git.csantosb@inventati.org
* gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.

Signed-off-by: Cayetano Santos <csantosb@inventati.org>
---
gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

Toggle diff (33 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 1d99fb30ff..6684b4496a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7999,6 +7999,24 @@ (define-public emacs-rspec
snippets for yasnippet.")
(license license:gpl3+))))
+(define-public emacs-vhdl-mode
+ (package
+ (name "emacs-vhdl-mode")
+ (version "3.39.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode-"
+ version ".tar.gz"))
+ (sha256
+ (base32 "1yvh4gyig8hgf5pahajjgsgp4jpzwgmlprwzsfybqxrcfza6f3yq"))))
+ (build-system emacs-build-system)
+ (home-page "https://www.emacswiki.org/emacs/EmacsWget")
+ (synopsis "Major mode for VHDL")
+ (description
+ "This Emacs package provides a mode for the VHDL programming language.")
+ (license license:gpl3+)))
+
(define-public emacs-mode-line-bell
(package
(name "emacs-mode-line-bell")

base-commit: 3dd8bf94a9d1a2eddb6eda9da7d4a3d422b9dfe9
--
2.41.0
C
C
Cayetano Santos wrote on 11 Jan 06:56 -0800
[PATCH v1] gnu: Add emacs-vhdl-mode.
(address . 68386@debbugs.gnu.org)(name . Cayetano Santos)(address . csantosb@inventati.org)
1116c7d02e4591ed8105146e3c16372cb78a3f3a.1704985017.git.csantosb@inventati.org
* gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.

Signed-off-by: Cayetano Santos <csantosb@inventati.org>
---
gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

Toggle diff (33 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 1d99fb30ff..dcd16caaa9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7999,6 +7999,24 @@ (define-public emacs-rspec
snippets for yasnippet.")
(license license:gpl3+))))
+(define-public emacs-vhdl-mode
+ (package
+ (name "emacs-vhdl-mode")
+ (version "3.39.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode-"
+ version ".tar.gz"))
+ (sha256
+ (base32 "1yvh4gyig8hgf5pahajjgsgp4jpzwgmlprwzsfybqxrcfza6f3yq"))))
+ (build-system emacs-build-system)
+ (home-page "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html")
+ (synopsis "Major mode for VHDL")
+ (description
+ "This Emacs package provides a mode for the VHDL programming language.")
+ (license license:gpl3+)))
+
(define-public emacs-mode-line-bell
(package
(name "emacs-mode-line-bell")

base-commit: 3dd8bf94a9d1a2eddb6eda9da7d4a3d422b9dfe9
--
2.41.0
M
M
Maxim Cournoyer wrote on 14 Jan 18:46 -0800
(name . Cayetano Santos)(address . csantosb@inventati.org)(address . 68386@debbugs.gnu.org)
87bk9ns48q.fsf@gmail.com
Hi,

Cayetano Santos <csantosb@inventati.org> writes:

Toggle quote (33 lines)
> * gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.
>
> Signed-off-by: Cayetano Santos <csantosb@inventati.org>
> ---
> gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 1d99fb30ff..dcd16caaa9 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -7999,6 +7999,24 @@ (define-public emacs-rspec
> snippets for yasnippet.")
> (license license:gpl3+))))
>
> +(define-public emacs-vhdl-mode
> + (package
> + (name "emacs-vhdl-mode")
> + (version "3.39.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode-"
> + version ".tar.gz"))
> + (sha256
> + (base32 "1yvh4gyig8hgf5pahajjgsgp4jpzwgmlprwzsfybqxrcfza6f3yq"))))
> + (build-system emacs-build-system)
> + (home-page "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html")
> + (synopsis "Major mode for VHDL")
> + (description
> + "This Emacs package provides a mode for the VHDL programming language.")
> + (license license:gpl3+)))

Since there already is a 'vhdl-mode' package shipped with Emacs, I think
it's important to describe how this one differs (what improvements, features,
refinements, etc. does it provide that would make it worth considering
it instead of the default Emacs-provided option?).

--
Thanks,
Maxim
M
M
Maxim Cournoyer wrote on 14 Jan 18:46 -0800
control message for bug #68386
(address . control@debbugs.gnu.org)
87a5p7s48k.fsf@gmail.com
tags 68386 + moreinfo
quit
C
C
Cayetano Santos wrote on 14 Jan 23:30 -0800
Re: [bug#68386] [PATCH v1] gnu: Add emacs-vhdl-mode.
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 68386@debbugs.gnu.org)
87fryzoxin.fsf@inventati.org
Toggle quote (7 lines)
>dim. 14 janv. 2024 at 21:46, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> Since there already is a 'vhdl-mode' package shipped with Emacs, I think
> it's important to describe how this one differs (what improvements, features,
> refinements, etc. does it provide that would make it worth considering
> it instead of the default Emacs-provided option?).

There are also many other packages (org, modus-themes, etc.) shipped with
Emacs that we package in its most recent versions (and many others that
pull these as propagated inputs, for some reason, even when already
available with Emacs). Do we also describe how they differ ?

Anyway, the release notes, update history, bug fixes and enhancements of
every single version of vhdl-mode are given in the project home page,
already included along with the package. Where do we need to replicate
this information exactly for the patch to be accepted ?

Thanks,

Cayetano Santos
M
M
Maxim Cournoyer wrote on 17 Jan 06:08 -0800
(name . Cayetano Santos)(address . csantosb@inventati.org)(address . 68386@debbugs.gnu.org)
87r0ignjc8.fsf@gmail.com
Hi,

Cayetano Santos <csantosb@inventati.org> writes:

Toggle quote (17 lines)
>>dim. 14 janv. 2024 at 21:46, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> Since there already is a 'vhdl-mode' package shipped with Emacs, I think
>> it's important to describe how this one differs (what improvements, features,
>> refinements, etc. does it provide that would make it worth considering
>> it instead of the default Emacs-provided option?).
>
> There are also many other packages (org, modus-themes, etc.) shipped with
> Emacs that we package in its most recent versions (and many others that
> pull these as propagated inputs, for some reason, even when already
> available with Emacs). Do we also describe how they differ ?
>
> Anyway, the release notes, update history, bug fixes and enhancements of
> every single version of vhdl-mode are given in the project home page,
> already included along with the package. Where do we need to replicate
> this information exactly for the patch to be accepted ?

Oh, I hadn't noticed that this was the very same package that comes with
Emacs. I guess it's fine then, but to avoid any misunderstanding,
perhaps the description text could mention it explicitly ("This is the
same @code{vhdl-mode} that comes with Emacs, albeit it may be newer") or
similar wording.

--
Thanks,
Maxim
C
C
Cayetano Santos wrote on 17 Jan 08:10 -0800
[PATCH v2] gnu: Add emacs-vhdl-mode.
(address . 68386@debbugs.gnu.org)(name . Cayetano Santos)(address . csantosb@inventati.org)
50762c4245754a472a295ae66551ff2f7d806f1b.1705507807.git.csantosb@inventati.org
* gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.

Signed-off-by: Cayetano Santos <csantosb@inventati.org>
---
gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

Toggle diff (31 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 1d99fb30ff..b7c5fbdf21 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7999,6 +7999,24 @@ (define-public emacs-rspec
snippets for yasnippet.")
(license license:gpl3+))))
+(define-public emacs-vhdl-mode
+ (package
+ (name "emacs-vhdl-mode")
+ (version "3.39.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode-"
+ version ".tar.gz"))
+ (sha256
+ (base32 "1yvh4gyig8hgf5pahajjgsgp4jpzwgmlprwzsfybqxrcfza6f3yq"))))
+ (build-system emacs-build-system)
+ (home-page "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html")
+ (synopsis "Major mode for VHDL programming language")
+ (description
+ "This package provides an update of @code{vhdl-mode} included in Emacs.")
+ (license license:gpl3+)))
+
(define-public emacs-mode-line-bell
(package
(name "emacs-mode-line-bell")

base-commit: 3dd8bf94a9d1a2eddb6eda9da7d4a3d422b9dfe9
--
2.41.0
C
C
Cayetano Santos wrote on 17 Jan 08:11 -0800
Re: [bug#68386] [PATCH v1] gnu: Add emacs-vhdl-mode.
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 68386@debbugs.gnu.org)
87v87s546m.fsf@inventati.org
Toggle quote (29 lines)
>mer. 17 janv. 2024 at 09:08, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> Hi,
>
> Cayetano Santos <csantosb@inventati.org> writes:
>
>>>dim. 14 janv. 2024 at 21:46, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>>
>>> Since there already is a 'vhdl-mode' package shipped with Emacs, I think
>>> it's important to describe how this one differs (what improvements, features,
>>> refinements, etc. does it provide that would make it worth considering
>>> it instead of the default Emacs-provided option?).
>>
>> There are also many other packages (org, modus-themes, etc.) shipped with
>> Emacs that we package in its most recent versions (and many others that
>> pull these as propagated inputs, for some reason, even when already
>> available with Emacs). Do we also describe how they differ ?
>>
>> Anyway, the release notes, update history, bug fixes and enhancements of
>> every single version of vhdl-mode are given in the project home page,
>> already included along with the package. Where do we need to replicate
>> this information exactly for the patch to be accepted ?
>
> Oh, I hadn't noticed that this was the very same package that comes with
> Emacs. I guess it's fine then, but to avoid any misunderstanding,
> perhaps the description text could mention it explicitly ("This is the
> same @code{vhdl-mode} that comes with Emacs, albeit it may be newer") or
> similar wording.

Done.

As an aside note, at some point, it should be decided how do we handle newest
releases of packages already included with emacs: do we need to mention
it explicitly or something else ?

C.
M
M
Maxim Cournoyer wrote on 17 Jan 11:39 -0800
(name . Cayetano Santos)(address . csantosb@inventati.org)(address . 68386@debbugs.gnu.org)
87jzo7n40g.fsf@gmail.com
Hi Cayetano,

Cayetano Santos <csantosb@inventati.org> writes:

Toggle quote (35 lines)
>>mer. 17 janv. 2024 at 09:08, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> Hi,
>>
>> Cayetano Santos <csantosb@inventati.org> writes:
>>
>>>>dim. 14 janv. 2024 at 21:46, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>>>
>>>> Since there already is a 'vhdl-mode' package shipped with Emacs, I think
>>>> it's important to describe how this one differs (what improvements, features,
>>>> refinements, etc. does it provide that would make it worth considering
>>>> it instead of the default Emacs-provided option?).
>>>
>>> There are also many other packages (org, modus-themes, etc.) shipped with
>>> Emacs that we package in its most recent versions (and many others that
>>> pull these as propagated inputs, for some reason, even when already
>>> available with Emacs). Do we also describe how they differ ?
>>>
>>> Anyway, the release notes, update history, bug fixes and enhancements of
>>> every single version of vhdl-mode are given in the project home page,
>>> already included along with the package. Where do we need to replicate
>>> this information exactly for the patch to be accepted ?
>>
>> Oh, I hadn't noticed that this was the very same package that comes with
>> Emacs. I guess it's fine then, but to avoid any misunderstanding,
>> perhaps the description text could mention it explicitly ("This is the
>> same @code{vhdl-mode} that comes with Emacs, albeit it may be newer") or
>> similar wording.
>
> Done.
>
> As an aside note, at some point, it should be decided how do we handle newest
> releases of packages already included with emacs: do we need to mention
> it explicitly or something else ?

I think explicit doesn't hurt.

--
Thanks,
Maxim
M
M
Maxim Cournoyer wrote on 18 Jan 19:47 -0800
Re: [bug#68386] [PATCH v2] gnu: Add emacs-vhdl-mode.
(name . Cayetano Santos)(address . csantosb@inventati.org)(address . 68386-done@debbugs.gnu.org)
87sf2uj86d.fsf@gmail.com
Hi,

Cayetano Santos <csantosb@inventati.org> writes:

Toggle quote (4 lines)
> * gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.
>
> Signed-off-by: Cayetano Santos <csantosb@inventati.org>

We do not 'Signed-off-by' in Guix unless we apply patches of someone
else. It's a different convention than for the kernel Linux
development and other projects.

I've applied it with small adjustments.

--
Thanks,
Maxim
Closed
C
C
Cayetano Santos wrote on 18 Jan 23:28 -0800
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 68386-done@debbugs.gnu.org)
87a5p1u6gn.fsf@inventati.org
Toggle quote (14 lines)
>jeu. 18 janv. 2024 at 22:47, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> Hi,
>
> Cayetano Santos <csantosb@inventati.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.
>>
>> Signed-off-by: Cayetano Santos <csantosb@inventati.org>
>
> We do not 'Signed-off-by' in Guix unless we apply patches of someone
> else. It's a different convention than for the kernel Linux
> development and other projects.

You mean, it is optional, or do I better remove it next time ?
Closed
M
M
Maxim Cournoyer wrote on 19 Jan 13:58 -0800
(name . Cayetano Santos)(address . csantosb@inventati.org)(address . 68386-done@debbugs.gnu.org)
87frythtno.fsf@gmail.com
Hi,

Cayetano Santos <csantosb@inventati.org> writes:

Toggle quote (16 lines)
>>jeu. 18 janv. 2024 at 22:47, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> Hi,
>>
>> Cayetano Santos <csantosb@inventati.org> writes:
>>
>>> * gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.
>>>
>>> Signed-off-by: Cayetano Santos <csantosb@inventati.org>
>>
>> We do not 'Signed-off-by' in Guix unless we apply patches of someone
>> else. It's a different convention than for the kernel Linux
>> development and other projects.
>
> You mean, it is optional, or do I better remove it next time ?

It's better to remove it next time.

--
Thanks,
Maxim
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 68386@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 68386
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch