[PATCH 07/13] gnu: Add go-github-com-pkg-profile

  • Done
  • quality assurance status badge
Details
3 participants
  • Fries
  • Maxim Cournoyer
  • (
Owner
unassigned
Submitted by
Fries
Severity
normal
Merged with

Debbugs page

F
F
Fries wrote on 5 Aug 2023 00:00
(address . guix-patches@gnu.org)(name . Fries)(address . fries1234@protonmail.com)
d5a16e184406bdc66ef16e85a5a78efe931b073d.1691218710.git.fries1234@protonmail.com
* gnu/packages/golang.scm (go-github-com-pkg-profile): New variable.
---
gnu/packages/golang.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)

Toggle diff (43 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 208b88d934..daa811a5dc 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2113,6 +2113,36 @@ (define-public go-github-com-dhowett-go-plist
types.")
(license license:giftware))))
+(define-public go-github-com-pkg-profile
+ (package
+ (name "go-github-com-pkg-profile")
+ (version "1.7.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/pkg/profile")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0ifr9gnycjwh7dbvsb5vgs9kzlr548cb4m45zvl8i8lgd3qhppy1"))))
+ (build-system go-build-system)
+ (arguments
+ '(#:import-path "github.com/pkg/profile"
+ #:phases (modify-phases %standard-phases
+ ;; profile drops a cpu.pprof file inside its source directory
+ ;; after tests which makes it unreproducable so we remove it.
+ (add-after 'check 'delete-test-file
+ (lambda _
+ (delete-file "src/github.com/pkg/profile/cpu.pprof"))))))
+ (propagated-inputs `(("go-github-com-felixge-fgprof" ,go-github-com-felixge-fgprof)))
+ (home-page "https://github.com/pkg/profile")
+ (synopsis "Simple profiling for Go")
+ (description
+ "Profile provides a simple way to manage runtime/pprof profiling of your
+Go application.")
+ (license license:bsd-2)))
+
(define-public go-github-com-felixge-fgprof
(package
(name "go-github-com-felixge-fgprof")
--
2.41.0
(
(
( wrote on 5 Aug 2023 02:19
(name . Fries)(address . fries1234@protonmail.com)
875y5trgj2.fsf@disroot.org
Fries via Guix-patches via <guix-patches@gnu.org> writes:
Toggle quote (4 lines)
> + (build-system go-build-system)
> + (arguments
> + '(#:import-path "github.com/pkg/profile"

Use LIST and #~.

Toggle quote (4 lines)
> + #:phases (modify-phases %standard-phases
> + ;; profile drops a cpu.pprof file inside its source directory
> + ;; after tests which makes it unreproducable so we remove it.

s/unreproducable/unreproducible/

Toggle quote (4 lines)
> + (add-after 'check 'delete-test-file
> + (lambda _
> + (delete-file "src/github.com/pkg/profile/cpu.pprof"))))))

You can make this neater like so:

(add-after 'check 'delete-test-file
(lambda* (#:key import-path #:allow-other-keys)
(delete-file (string-append "src/" import-path "/cpu.pprof"))))

Toggle quote (2 lines)
> + (propagated-inputs `(("go-github-com-felixge-fgprof" ,go-github-com-felixge-fgprof)))

LIST here too.

-- (
F
F
Fries wrote on 5 Aug 2023 02:30
Merge bugs
(address . control@debbugs.gnu.org)
6131230.DvuYhMxLoT@pc
merge 65075 65072 65076 65073 65078 65077 65079 65082 65080 65081 65084 65085 65083 65074
# accidently sent my patch series to the mailing list instead the cover letters bug
quit
F
F
Fries wrote on 5 Aug 2023 16:13
More cleanly merge bugs
(address . control@debbugs.gnu.org)
5713201.DvuYhMxLoT@pc
unmerge 65072
unmerge 65073
unmerge 65075
unmerge 65076
unmerge 65077
unmerge 65078
unmerge 65079
unmerge 65080
unmerge 65081
unmerge 65082
unmerge 65083
unmerge 65084
unmerge 65085
unmerge 65074
merge 65075 65074
merge 65072 65074
merge 65076 65074
merge 65073 65074
merge 65078 65074
merge 65077 65074
merge 65079 65074
merge 65082 65074
merge 65080 65074
merge 65081 65074
merge 65084 65074
merge 65085 65074
merge 65083 65074
# try to merge all the bugs with just 65074 instead of merging with all of themselves
stop
M
M
Maxim Cournoyer wrote on 1 Sep 2023 05:08
Re: bug#65085: [PATCH 12/13] gnu: Add go-github-com-json-iterator-go
(name . Fries)(address . fries1234@protonmail.com)
87wmxa3xl5.fsf_-_@gmail.com
tags 65072 + moreinfo
quit

Hi Fries,

Thank you for your contribution.

Fries <fries1234@protonmail.com> writes:

Toggle quote (34 lines)
> * gnu/packages/golang.scm (go-github-com-chyzer-test): New variable.
> ---
> gnu/packages/golang.scm | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index d99f76dc7d..ef82f0aa1b 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -2113,6 +2113,32 @@ (define-public go-github-com-dhowett-go-plist
> types.")
> (license license:giftware))))
>
> +(define-public go-github-com-chzyer-test
> + (package
> + (name "go-github-com-chzyer-test")
> + (version "1.0.0")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/chzyer/test")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1axdlcnx2qjsn5wsr2pr1m0w0a8k4nk5kkrngh742fgh81vzzy8s"))))
> + (build-system go-build-system)
> + (arguments
> + '(#:import-path "github.com/chzyer/test"
> + #:phases
> + ;; Tests relating to a in-memory disk fail due to a Segfault.
> + (modify-phases %standard-phases
> + (delete 'check))))

This should be minimally investigated, and ideally an issue created on
upstream issue tracker and an URL added next to the comment to track its
resolution, e.g:

;; Tests relating to a in-memory disk fail due to a segfault (see:
;; $URL).

Also taking the comments from parens into account, could you please send
a v2 to this same issue (65072@debbugs.gnu.org) ?

--
Thanks,
Maxim
?
Your comment

This issue is archived.

To comment on this conversation send an email to 65079@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 65079
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch