Subject: Re: [bug#65079] [PATCH 07/13] gnu: Add go-github-com-pkg-profile

From: "(" <[email-masked]>
Date: Sat, 05 Aug 2023 10:19:20 +0100

Fries via Guix-patches via <[email-masked]> writes:
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/pkg/profile"

Use LIST and #~.

> +       #:phases (modify-phases %standard-phases
> +                  ;; profile drops a cpu.pprof file inside its source directory
> +                  ;; after tests which makes it unreproducable so we remove it.

s/unreproducable/unreproducible/

> +                  (add-after 'check 'delete-test-file
> +                    (lambda _
> +                      (delete-file "src/github.com/pkg/profile/cpu.pprof"))))))

You can make this neater like so:

  (add-after 'check 'delete-test-file
    (lambda* (#:key import-path #:allow-other-keys)
      (delete-file (string-append "src/" import-path "/cpu.pprof"))))

> +    (propagated-inputs `(("go-github-com-felixge-fgprof" ,go-github-com-felixge-fgprof)))

LIST here too.

  -- (