[PATCH] gnu: swaynotificationcenter: Update to 0.8.0

  • Done
  • quality assurance status badge
Details
2 participants
  • Brian Cully
  • Christopher Baines
Owner
unassigned
Submitted by
Brian Cully
Severity
normal

Debbugs page

B
B
Brian Cully wrote on 22 May 2023 07:20
(address . guix-patches@gnu.org)(name . Brian Cully)(address . bjc@spork.org)
c734e5135bf527b91c800d1296e777615c24ac26.1684765256.git.bjc@spork.org
* gnu/packages/wm.scm (swaynotificationcenter): Update to 0.8.0.
---
gnu/packages/wm.scm | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

Toggle diff (54 lines)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 4360f3722b..1bf6d46200 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -147,6 +147,7 @@ (define-module (gnu packages wm)
#:use-module (gnu packages python-xyz)
#:use-module (gnu packages readline)
#:use-module (gnu packages serialization)
+ #:use-module (gnu packages shells)
#:use-module (gnu packages sphinx)
#:use-module (gnu packages suckless)
#:use-module (gnu packages texinfo)
@@ -1761,7 +1762,7 @@ (define-public swaybg
(define-public swaynotificationcenter
(package
(name "swaynotificationcenter")
- (version "0.7.3")
+ (version "0.8.0")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -1769,7 +1770,7 @@ (define-public swaynotificationcenter
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
- (base32 "1xvr5m5sqznr3dd512i5pk0d56v7n0ywdcy6rnz85vbf2k7b6kj5"))))
+ (base32 "1c3gd6mlr209jzzrh5jmws2lawnn3gr6smvzcw74kkpi3wvs7l0k"))))
(build-system meson-build-system)
(arguments (list #:configure-flags #~(list "-Dsystemd-service=false")))
(native-inputs
@@ -1780,11 +1781,15 @@ (define-public swaynotificationcenter
scdoc
vala))
(inputs
- (list json-glib
+ (list bash-completion
+ fish
+ json-glib
glib
gtk+
gtk-layer-shell
libhandy
+ libgee
+ pulseaudio
wayland-protocols))
(synopsis "Notification daemon with a graphical interface")
(description

base-commit: 849286ba66c96534bddc04df1a47d5692cbc977e
prerequisite-patch-id: 18557da18beab5677060ea1de1897768791ce89e
prerequisite-patch-id: a2d8b917b767b5445112f49ca4d9b060e8baa587
prerequisite-patch-id: eabe444a8c70abebec53c814fbd88236bb86fabf
--
2.40.1
C
C
Christopher Baines wrote on 12 Jun 2023 11:38
(name . Brian Cully)(address . bjc@spork.org)(address . 63645@debbugs.gnu.org)
875y7sy17p.fsf@cbaines.net
Brian Cully via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (51 lines)
> * gnu/packages/wm.scm (swaynotificationcenter): Update to 0.8.0.
> ---
> gnu/packages/wm.scm | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 4360f3722b..1bf6d46200 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -147,6 +147,7 @@ (define-module (gnu packages wm)
> #:use-module (gnu packages python-xyz)
> #:use-module (gnu packages readline)
> #:use-module (gnu packages serialization)
> + #:use-module (gnu packages shells)
> #:use-module (gnu packages sphinx)
> #:use-module (gnu packages suckless)
> #:use-module (gnu packages texinfo)
> @@ -1761,7 +1762,7 @@ (define-public swaybg
> (define-public swaynotificationcenter
> (package
> (name "swaynotificationcenter")
> - (version "0.7.3")
> + (version "0.8.0")
> (source (origin
> (method git-fetch)
> (uri (git-reference
> @@ -1769,7 +1770,7 @@ (define-public swaynotificationcenter
> (commit (string-append "v" version))))
> (file-name (git-file-name name version))
> (sha256
> - (base32 "1xvr5m5sqznr3dd512i5pk0d56v7n0ywdcy6rnz85vbf2k7b6kj5"))))
> + (base32 "1c3gd6mlr209jzzrh5jmws2lawnn3gr6smvzcw74kkpi3wvs7l0k"))))
> (build-system meson-build-system)
> (arguments (list #:configure-flags #~(list "-Dsystemd-service=false")))
> (native-inputs
> @@ -1780,11 +1781,15 @@ (define-public swaynotificationcenter
> scdoc
> vala))
> (inputs
> - (list json-glib
> + (list bash-completion
> + fish
> + json-glib
> glib
> gtk+
> gtk-layer-shell
> libhandy
> + libgee
> + pulseaudio
> wayland-protocols))

Hi Brian,

Regarding these new inputs, what's you're reasoning for adding them?

fish stood out to me, it doesn't seem to be referenced by the
swaynotificationcenter output (doesn't show up in guix size), so maybe
it should be a native-input if it's some test dependency?

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmSHZlpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XcHkxAApAScveaeF6v+eglb7/hDnieXvbpXOA0E
19xTfrOAxjDD+dYefc9DZB9qnFh2qn915v0Ntb3O1XVdfGcxp5R9uoDLN51MgxHj
CJ5bEDRFmytePqjS5xmN4yVih900uIyEzxO6uOWbHmuBPMb/TsDzR0jLfx/Tp1O9
Y3KlXE+t96RqblEzOjLEwTJy1P8L5qZqGvW7flD3Hqenq9PWw8c95X4jTVtzaXIx
0RmZDbVh9Ykc4z5ckA8OUxoQeLmkh1IG0lsjfDLA38xYvoTdiWkrtJKpZYWbHL7w
iiWHiFDJznBuMzf+gflt0G6+Hj7bDs34E50YZTUag7LX37tkR47d1oMElpROL/Ws
u2vBOw8EeZwb0PvD9ZWCVzrZUe+ZQfuPRoCVLpG55aKKWonJhUVOq89Ms18coTsK
Xeqe+CtkcylLZOUB23RabENxTU+JWqB6VFu6jyE1m3MEv87GqlUh2HjvOLzaqGTF
YT3aspXbDJ+eXc5FDo7l1SmefKqkyL9lVhEaGXGROYTq92lLUVAjsvDy+dbHJcaQ
T1w1jEYUeK0LrvE1aNiD/A236oCXq92qdOjmyflqumslXRJ6M2fjgmaGeVMHmuZY
sGyRSUdy6zcGHAABK2IdKCHOXMQ+/qvpYp4GHsoVN7soaVejAjAMGy7t4+x8gfk5
0vSNqNgxrYw=
=bm5h
-----END PGP SIGNATURE-----

C
C
Christopher Baines wrote on 12 Jun 2023 11:39
tag 63645 moreinfo
(address . control@debbugs.gnu.org)
875y7scyor.fsf@cbaines.net
tags 63645 + moreinfo
quit
B
B
Brian Cully wrote on 12 Jun 2023 12:11
Re: [bug#63645] [PATCH] gnu: swaynotificationcenter: Update to 0.8.0
(name . Christopher Baines)(address . mail@cbaines.net)(address . 63645@debbugs.gnu.org)
871qigpk63.fsf@psyduck.jhoto.kublai.com
Christopher Baines <mail@cbaines.net> writes:

Toggle quote (16 lines)
>> (inputs
>> - (list json-glib
>> + (list bash-completion
>> + fish
>> + json-glib
>> glib
>> gtk+
>> gtk-layer-shell
>> libhandy
>> + libgee
>> + pulseaudio
>> wayland-protocols))
>
> Regarding these new inputs, what's you're reasoning for adding
> them?

In general: so that configure would find everything it was looking
for. I believe the only new hard requirement is libgee and
json-glib (I can test a build without them and see how far I get,
but it'll have to wait until I have a bit more time).

The others — bash-completion and fish — are for command
completion, I believe. Do those better belong in native-inputs
just so the can be detected during configure-time?

-bjc
B
B
Brian Cully wrote on 16 Jun 2023 16:12
(name . Brian Cully)(address . bjc@spork.org)
87zg4zc6ht.fsf@psyduck.jhoto.kublai.com
Brian Cully <bjc@spork.org> writes:

Toggle quote (26 lines)
> Christopher Baines <mail@cbaines.net> writes:
>
>>> (inputs
>>> - (list json-glib
>>> + (list bash-completion
>>> + fish
>>> + json-glib
>>> glib
>>> gtk+
>>> gtk-layer-shell
>>> libhandy
>>> + libgee
>>> + pulseaudio
>>> wayland-protocols))
>>
>> Regarding these new inputs, what's you're reasoning for adding
>> them?
>
> In general: so that configure would find everything it was
> looking
> for. I believe the only new hard requirement is libgee and
> json-glib
> (I can test a build without them and see how far I get, but
> it'll have
> to wait until I have a bit more time).

I re-ran the build today, and the output from the configure phase
does specify that ‘libgee’, ‘json-glib’, and ‘pulseaudio’ are
runtime dependencies:

Toggle snippet (8 lines)
Run-time dependency json-glib-1.0 found: YES 1.6.2
[…]
Run-time dependency gee-0.8 found: YES 0.20.5
Run-time dependency libpulse found: YES 16.1
Run-time dependency libpulse-mainloop-glib found: YES 16.1


Toggle quote (6 lines)
> The others — bash-completion and fish — are for command
> completion, I
> believe. Do those better belong in native-inputs just so the can
> be
> detected during configure-time?

But maybe ‘Run-time dependency’ is a mis-labelling. Compiling
without the ‘bash-completion’ or ‘fish’ inputs generates the
complaints:

Toggle snippet (5 lines)
Run-time dependency bash-completion found: NO (tried pkgconfig and
cmake)
Run-time dependency fish found: NO (tried pkgconfig and cmake)

But it still installs the completion files:

Toggle snippet (26 lines)
Installing
/tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/zsh/_swaync
to
/gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/share/zsh/site-functions
Installing
/tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/zsh/_swaync-client
to
/gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/share/zsh/site-functions
Installing
/tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/bash/swaync
to
/gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/share/bash-completion/completions
Installing
/tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/bash/swaync-client
to
/gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/share/bash-completion/completions
Installing
/tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/fish/swaync.fish
to
/gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/share/fish/vendor_completions.d
Installing
/tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/fish/swaync-client.fish
to
/gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/share/fish/vendor_completions.d

Note also that ‘zsh’ gets completions as well, even though it's
not being checked for in the configuration phase.

Starting a shell with fish:

Toggle snippet (4 lines)
/pre-inst-env guix shell -CP coreutils fish bash
swaynotificationcenter -- fish

Yields completion candidates for ‘swaync’ and ‘swaync-client’,
even though I've removed those inputs, so it seems they're not
necessary.

I'll submit a v2 without the ‘fish’ and ‘bash’ inputs shortly.

--
-bjc
B
B
Brian Cully wrote on 16 Jun 2023 16:52
[PATCH v2] gnu: swaynotificationcenter: Update to 0.8.0
(address . 63645@debbugs.gnu.org)(name . Brian Cully)(address . bjc@spork.org)
e5ea3b66632cf49c921f93a798da487d5704398f.1686959554.git.bjc@spork.org
* gnu/packages/wm.scm (swaynotificationcenter): Update to 0.8.0.
---
gnu/packages/wm.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Toggle diff (35 lines)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index e707a15785..55c7e7e63f 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1779,7 +1779,7 @@ (define-public swaybg
(define-public swaynotificationcenter
(package
(name "swaynotificationcenter")
- (version "0.7.3")
+ (version "0.8.0")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -1787,7 +1787,7 @@ (define-public swaynotificationcenter
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
- (base32 "1xvr5m5sqznr3dd512i5pk0d56v7n0ywdcy6rnz85vbf2k7b6kj5"))))
+ (base32 "1c3gd6mlr209jzzrh5jmws2lawnn3gr6smvzcw74kkpi3wvs7l0k"))))
(build-system meson-build-system)
(arguments (list #:configure-flags #~(list "-Dsystemd-service=false")))
(native-inputs
@@ -1803,6 +1803,8 @@ (define-public swaynotificationcenter
gtk+
gtk-layer-shell
libhandy
+ libgee
+ pulseaudio
wayland-protocols))
(synopsis "Notification daemon with a graphical interface")
(description

base-commit: 31336e9f5d68512a9c1c6826bce9f17c892a2125
--
2.40.1
C
C
Christopher Baines wrote on 19 Jun 2023 03:14
(name . Brian Cully)(address . bjc@spork.org)(address . 63645-done@debbugs.gnu.org)
878rcflpvn.fsf@cbaines.net
Brian Cully via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (5 lines)
> * gnu/packages/wm.scm (swaynotificationcenter): Update to 0.8.0.
> ---
> gnu/packages/wm.scm | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

Thanks for investigating further Brian, I've pushed this to master as
c63e6652861d8ed85ffa91d568e69053478a1511.

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmSQKrxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XcaHA//Zebh4VuDFodwDYsOeIRCQVdW27CyrSKa
Bz3A124np/k36na4AaZAVeXF5JwECtndGO42b6yv5RuUody1qAoP+BD4vgU/zcy1
vbnyVxgxOIdYdMYstMCxuvSsq7ykBDCidIJnwOutjNj7wxiXYYvbnnSkHQU6mSuK
mKZfRnCmBbxvbf4LhnsPoRGgvQCGLfKbOZn0MO7xx9pGtOcbtoXgUmMxqaU8waYY
fUhQQscO/xwiZpFyBYzSK+ePlGZ2lFs/TKfvJzyeM1wohfXiTHVwFjJQjJoMF3CY
wGN5rTG83qkK5Hv2wqrUdnkjfUak2WezuRf+6wu/jmAo5mpsWpi+R2le++/TiXWn
dd9+mFiDXaPOV6eQ6sQa1IQ6jBN9nCPBNTILs9jJTpmFVVAkORCMmpQhdmylWOMx
mDKGiItCcg5hJj3CHaRn+hnxDx5HNbi7LOVWh3FS4w2ezWHx0Jd9BTrin0g7B2+N
vY5fFMTLlUkA1u/2FvR8zePqe1RH/UePJjPHUM2t92ecpeRfE5ZwyAFG6xCl2AKw
5qa1ngGoPNwbj1e/6+2VeLGZ+exAZCIoj628C8m2PhRbJJ6UpQNJ/a2CGHl6j8As
MoGZuxpe94D48daucSso+Ez4HDo1NY/V6IQlUJ4I0J1xSV2uNC6+N+BQuNlzRljX
gTWKDYkyjRU=
=pKKR
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 63645@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 63645
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch