Subject: Re: [bug#63645] [PATCH] gnu: swaynotificationcenter: Update to 0.8.0

From: Christopher Baines <[email-masked]>
Date: Mon, 12 Jun 2023 19:38:04 +0100

Brian Cully via Guix-patches via <[email-masked]> writes:

> * gnu/packages/wm.scm (swaynotificationcenter): Update to 0.8.0.
> ---
>  gnu/packages/wm.scm | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 4360f3722b..1bf6d46200 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -147,6 +147,7 @@ (define-module (gnu packages wm)
>    #:use-module (gnu packages python-xyz)
>    #:use-module (gnu packages readline)
>    #:use-module (gnu packages serialization)
> +  #:use-module (gnu packages shells)
>    #:use-module (gnu packages sphinx)
>    #:use-module (gnu packages suckless)
>    #:use-module (gnu packages texinfo)
> @@ -1761,7 +1762,7 @@ (define-public swaybg
>  (define-public swaynotificationcenter
>    (package
>      (name "swaynotificationcenter")
> -    (version "0.7.3")
> +    (version "0.8.0")
>      (source (origin
>                (method git-fetch)
>                (uri (git-reference
> @@ -1769,7 +1770,7 @@ (define-public swaynotificationcenter
>                      (commit (string-append "v" version))))
>                (file-name (git-file-name name version))
>                (sha256
> -               (base32 "1xvr5m5sqznr3dd512i5pk0d56v7n0ywdcy6rnz85vbf2k7b6kj5"))))
> +               (base32 "1c3gd6mlr209jzzrh5jmws2lawnn3gr6smvzcw74kkpi3wvs7l0k"))))
>      (build-system meson-build-system)
>      (arguments (list #:configure-flags #~(list "-Dsystemd-service=false")))
>      (native-inputs
> @@ -1780,11 +1781,15 @@ (define-public swaynotificationcenter
>             scdoc
>             vala))
>      (inputs
> -     (list json-glib
> +     (list bash-completion
> +           fish
> +           json-glib
>             glib
>             gtk+
>             gtk-layer-shell
>             libhandy
> +           libgee
> +           pulseaudio
>             wayland-protocols))

Hi Brian,

Regarding these new inputs, what's you're reasoning for adding them?

fish stood out to me, it doesn't seem to be referenced by the
swaynotificationcenter output (doesn't show up in guix size), so maybe
it should be a native-input if it's some test dependency?

Thanks,

Chris