[PATCH] gnu: python2-bottle: Remove package.

  • Done
  • quality assurance status badge
Details
2 participants
  • jgart
  • Ludovic Courtès
Owner
unassigned
Submitted by
jgart
Severity
normal

Debbugs page

J
J
jgart wrote on 7 Dec 2021 13:00
(address . guix-patches@gnu.org)(name . jgart)(address . jgart@dismail.de)
20211207210007.1058-1-jgart@dismail.de
* gnu/packages/python-web.scm (python2-bottle): Delete variable.
---
gnu/packages/python-web.scm | 3 ---
1 file changed, 3 deletions(-)

Toggle diff (16 lines)
diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index d4a785b2fc..fb23054489 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -4170,9 +4170,6 @@ (define-public python-bottle
(description "@code{python-bottle} is a WSGI framework for small web-applications.")
(license license:expat)))
-(define-public python2-bottle
- (package-with-python2 python-bottle))
-
(define-public python-wtforms
(package
(name "python-wtforms")
--
2.34.0
L
L
Ludovic Courtès wrote on 19 Dec 2021 14:25
(name . jgart)(address . jgart@dismail.de)(address . 52359@debbugs.gnu.org)
87bl1cmdvh.fsf@gnu.org
Hi,

jgart <jgart@dismail.de> skribis:

Toggle quote (2 lines)
> * gnu/packages/python-web.scm (python2-bottle): Delete variable.

Apparently it still has users so we can’t remove it yet:

Toggle snippet (4 lines)
$ ./pre-inst-env guix refresh -l python2-bottle
Building the following 2 packages would ensure 3 dependent packages are rebuilt: h-client@0.0a0-138 virtaal@0.7.1

Ludo’.
J
J
jgart wrote on 19 Dec 2021 14:58
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 52359@debbugs.gnu.org)
20211219175816.GB5741@gac
On Sun, 19 Dec 2021 23:25:06 +0100 Ludovic Courtès <ludo@gnu.org> wrote:
Toggle quote (8 lines)
> Hi,
>
> jgart <jgart@dismail.de> skribis:
>
> > * gnu/packages/python-web.scm (python2-bottle): Delete variable.
>
> Apparently it still has users so we can’t remove it yet:

Hi Ludo,

Thanks for the review!

The best way to check is with `guix refresh --list-dependent python2-bottle`?

Or, you're referring to the fact that there are still users using the
python2 version of bottle itself?

Also, when upgrading a package, what is your workflow for testing and making
sure you don't break a dependent package?

Do you also build all packages listed in the output of
`guix refresh --list-dependent package-name` before sending a patch?

My experience with this issue is when I updated python-jedi recently.
I sent the patch. It got accepted. (Un)relatedly, I tried installing
bpython a day later and bpython was broken. My first guess is that the
upgrade of python-jedi broke the current version of bpython in master. I
wasn't thinking about bpython when I was upgrading python-jedi.

Could any of the above be mentioned in the cookbook or the manual? Excuse me if
I TDLR'ed that part.

Any advice is much appreciated.

Toggle quote (7 lines)
>
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix refresh -l python2-bottle
> Building the following 2 packages would ensure 3 dependent packages are rebuilt: h-client@0.0a0-138 virtaal@0.7.1
> --8<---------------cut here---------------end--------------->8---
>
> Ludo’.
L
L
Ludovic Courtès wrote on 20 Dec 2021 07:05
control message for bug #52359
(address . control@debbugs.gnu.org)
87y24fiaf0.fsf@gnu.org
tags 52359 wontfix
close 52359
quit
?
Your comment

This issue is archived.

To comment on this conversation send an email to 52359@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 52359
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch