#52359 [PATCH] gnu: python2-bottle: Remove package.

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: jgart <jgart@dismail.de>

To: guix-patches@gnu.org

Cc: jgart <jgart@dismail.de>

Subject: [PATCH] gnu: python2-bottle: Remove package.

Date: Tue, 7 Dec 2021 16:00:07 -0500

* gnu/packages/python-web.scm (python2-bottle): Delete variable.
---
 gnu/packages/python-web.scm | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index d4a785b2fc..fb23054489 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -4170,9 +4170,6 @@ (define-public python-bottle
     (description "@code{python-bottle} is a WSGI framework for small web-applications.")
     (license license:expat)))
 
-(define-public python2-bottle
-  (package-with-python2 python-bottle))
-
 (define-public python-wtforms
   (package
     (name "python-wtforms")
-- 
2.34.0

Message #8 received at 52359@debbugs.gnu.org (full text, mbox, reply):

From: Ludovic Courtès <ludo@gnu.org>

To: jgart <jgart@dismail.de>

Cc: 52359@debbugs.gnu.org

Subject: Re: bug#52359: [PATCH] gnu: python2-bottle: Remove package.

Date: Sun, 19 Dec 2021 23:25:06 +0100

Hi,

jgart <jgart@dismail.de> skribis:

> * gnu/packages/python-web.scm (python2-bottle): Delete variable.

Apparently it still has users so we can’t remove it yet:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env  guix refresh -l python2-bottle
Building the following 2 packages would ensure 3 dependent packages are rebuilt: h-client@0.0a0-138 virtaal@0.7.1
--8<---------------cut here---------------end--------------->8---

Ludo’.

Message #11 received at 52359@debbugs.gnu.org (full text, mbox, reply):

From: jgart <jgart@dismail.de>

To: Ludovic Courtès <ludo@gnu.org>

Cc: 52359@debbugs.gnu.org

Subject: Re: bug#52359: [PATCH] gnu: python2-bottle: Remove package.

Date: Sun, 19 Dec 2021 17:58:16 -0500

On Sun, 19 Dec 2021 23:25:06 +0100 Ludovic Courtès <ludo@gnu.org> wrote:
> Hi,
> 
> jgart <jgart@dismail.de> skribis:
> 
> > * gnu/packages/python-web.scm (python2-bottle): Delete variable.
> 
> Apparently it still has users so we can’t remove it yet:

Hi Ludo,

Thanks for the review!

The best way to check is with `guix refresh --list-dependent python2-bottle`?

Or, you're referring to the fact that there are still users using the
python2 version of bottle itself?

Also, when upgrading a package, what is your workflow for testing and making 
sure you don't break a dependent package?

Do you also build all packages listed in the output of 
`guix refresh --list-dependent package-name` before sending a patch?

My experience with this issue is when I updated python-jedi recently. 
I sent the patch.  It got accepted. (Un)relatedly, I tried installing
bpython a day later and bpython was broken. My first guess is that the
upgrade of python-jedi broke the current version of bpython in master. I
wasn't thinking about bpython when I was upgrading python-jedi.

Could any of the above be mentioned in the cookbook or the manual? Excuse me if
I TDLR'ed that part.

Any advice is much appreciated.

> 
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env  guix refresh -l python2-bottle
> Building the following 2 packages would ensure 3 dependent packages are rebuilt: h-client@0.0a0-138 virtaal@0.7.1
> --8<---------------cut here---------------end--------------->8---
> 
> Ludo’.

Send a report that this bug log contains spam.