dvtm does not properly export terminfo

  • Open
  • quality assurance status badge
Details
2 participants
  • Jelle Licht
  • Ludovic Courtès
Owner
unassigned
Submitted by
Jelle Licht
Severity
normal

Debbugs page

J
J
Jelle Licht wrote on 29 Dec 2017 06:05
(address . bug-guix@gnu.org)
CAPsKtfJHY95oaG88deDoQzQJ_EtYYGub1sHaoJi0Hcp+GF+o-w@mail.gmail.com
As far as I can see, the current version of dvtm does not work properly
with programs such as htop etc.

To reproduce:
```
$ guix package -i dvtm
$ dvtm
$ htop
```
It only worked properly once I added something like:
`export TERMINFO_DIRS="/home/jelle/.guix-profile/share/terminfo"`.

Would a proper fix be to simply add a native-search-path declaration to the
dvtm package? If so, I can prepare a patch this weekend.

Thanks,
Jelle
Attachment: file
L
L
Ludovic Courtès wrote on 1 Jan 2018 09:19
(name . Jelle Licht)(address . jlicht@fsfe.org)(address . 29892@debbugs.gnu.org)
87mv1xzec7.fsf@gnu.org
Hi!

Jelle Licht <jlicht@fsfe.org> skribis:

Toggle quote (15 lines)
> As far as I can see, the current version of dvtm does not work properly
> with programs such as htop etc.
>
> To reproduce:
> ```
> $ guix package -i dvtm
> $ dvtm
> $ htop
> ```
> It only worked properly once I added something like:
> `export TERMINFO_DIRS="/home/jelle/.guix-profile/share/terminfo"`.
>
> Would a proper fix be to simply add a native-search-path declaration to the
> dvtm package? If so, I can prepare a patch this weekend.

‘TERMINFO_DIRS’ is a search path of ncurses. However, because search
paths of dependencies are not honored, it doesn’t get set:


This is what we should fix.

It would feel wrong to add ‘TERMINFO_DIRS’ as a search path of dvtm and
everything that depends on ncurses.

Thanks,
Ludo’.
J
J
Jelle Licht wrote on 4 Jan 2018 07:20
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 29892@debbugs.gnu.org)
CAPsKtf+mZ4-87AH=6g2p5d3JJBzZP6kSFBZVFRHFK3L5q1gyVA@mail.gmail.com
Hello,

2018-01-01 18:19 GMT+01:00 Ludovic Courtès <ludo@gnu.org>:

Toggle quote (27 lines)
> Hi!
>
> Jelle Licht <jlicht@fsfe.org> skribis:
>
> > As far as I can see, the current version of dvtm does not work properly
> > with programs such as htop etc.
> >
> > To reproduce:
> > ```
> > $ guix package -i dvtm
> > $ dvtm
> > $ htop
> > ```
> > It only worked properly once I added something like:
> > `export TERMINFO_DIRS="/home/jelle/.guix-profile/share/terminfo"`.
> >
> > Would a proper fix be to simply add a native-search-path declaration to
> the
> > dvtm package? If so, I can prepare a patch this weekend.
>
> ‘TERMINFO_DIRS’ is a search path of ncurses. However, because search
> paths of dependencies are not honored, it doesn’t get set:
>
> https://bugs.gnu.org/22138
>
> This is what we should fix.
>
Fixing this properly seems like it would take effort indeed.


Toggle quote (5 lines)
>
> It would feel wrong to add ‘TERMINFO_DIRS’ as a search path of dvtm and
> everything that depends on ncurses.
>

Am I correct in assuming that as a temporary (personal) workaround, I can
just
install ncurses in my profile as well?

Perhaps guix can warn if you install a package which has a dependency
with a search path like ncurses? Or would this be too much of a hassle
to implement?

It would not solve the issue, but at least prevent people from
not understanding why their packages are not working. WDYT?

Toggle quote (5 lines)
>
> Thanks,
> Ludo’.
>

- Jelle
Attachment: file
L
L
Ludovic Courtès wrote on 5 Jan 2018 09:24
(name . Jelle Licht)(address . jlicht@fsfe.org)(address . 29892@debbugs.gnu.org)
87tvw0usl4.fsf@gnu.org
Hi,

Jelle Licht <jlicht@fsfe.org> skribis:

Toggle quote (2 lines)
> 2018-01-01 18:19 GMT+01:00 Ludovic Courtès <ludo@gnu.org>:

[...]

Toggle quote (7 lines)
>> ‘TERMINFO_DIRS’ is a search path of ncurses. However, because search
>> paths of dependencies are not honored, it doesn’t get set:
>>
>> https://bugs.gnu.org/22138
>>
>> This is what we should fix.

[...]

Toggle quote (4 lines)
> Am I correct in assuming that as a temporary (personal) workaround, I can
> just
> install ncurses in my profile as well?

Yes.

Toggle quote (7 lines)
> Perhaps guix can warn if you install a package which has a dependency
> with a search path like ncurses? Or would this be too much of a hassle
> to implement?
>
> It would not solve the issue, but at least prevent people from
> not understanding why their packages are not working. WDYT?

Good question, not sure it would be significantly easier than fixing the
core issue. Dunno!

Ludo’.
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 29892@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 29892
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch