guix system reconfigure does not update path to nginx configuration

  • Done
  • quality assurance status badge
Details
3 participants
  • Clément Lassieur
  • Oleg Pykhalov
  • Ludovic Courtès
Owner
unassigned
Submitted by
Oleg Pykhalov
Severity
normal

Debbugs page

O
O
Oleg Pykhalov wrote on 10 Oct 2017 02:37
(address . bug-guix@gnu.org)
8760bnmjhn.fsf@gmail.com
Hello Guix,

After changing config.scm, herd restarts NGINX with previous (on boot)
configuration (checked with ps). So to apply a new NGINX configuration
to a system, reboot is required.
C
C
Clément Lassieur wrote on 10 Oct 2017 03:47
(name . Oleg Pykhalov)(address . go.wigust@gmail.com)(address . 28776@debbugs.gnu.org)
87k2036zzz.fsf@lassieur.org
Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> writes:

Toggle quote (4 lines)
> After changing config.scm, herd restarts NGINX with previous (on boot)
> configuration (checked with ps). So to apply a new NGINX configuration
> to a system, reboot is required.

Toggle snippet (6 lines)
Currently ‘guix system reconfigure’ (specifically
‘upgrade-shepherd-services’) reloads and starts all services that are
currently stopped, on the grounds that it would not be safe/desirable to
simply stop any running service.

So if you want NGINX to start with its new configuration, you need to
stop it before doing the 'guix system reconfigure'.

Clément
O
O
Oleg Pykhalov wrote on 10 Oct 2017 03:58
(name . Clément Lassieur)(address . clement@lassieur.org)(address . 28776@debbugs.gnu.org)
874lr7fevt.fsf@gmail.com
Hello Clement,

Clément Lassieur <clement@lassieur.org> writes:

Toggle quote (17 lines)
> Oleg Pykhalov <go.wigust@gmail.com> writes:
>
>> After changing config.scm, herd restarts NGINX with previous (on boot)
>> configuration (checked with ps). So to apply a new NGINX configuration
>> to a system, reboot is required.
>
> Quoting Ludovic from:
> https://lists.gnu.org/archive/html/guix-patches/2017-05/msg00669.html
>
> Currently ‘guix system reconfigure’ (specifically
> ‘upgrade-shepherd-services’) reloads and starts all services that are
> currently stopped, on the grounds that it would not be safe/desirable to
> simply stop any running service.
>
> So if you want NGINX to start with its new configuration, you need to
> stop it before doing the 'guix system reconfigure'.

Thank you for giving a direction! I actually tried to make 'sudo herd
restart nginx' after reconfigure, but apparently it's wrong.

I'm not sure if we need to close this bug. It wasn't obvious to
me that it related to subject “Allow services to implement a 'reload'
action”, because I tried to reload it manually :-)
L
L
Ludovic Courtès wrote on 11 Oct 2017 06:25
(name . Oleg Pykhalov)(address . go.wigust@gmail.com)
87tvz5byut.fsf@gnu.org
Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

Toggle quote (2 lines)
> Clément Lassieur <clement@lassieur.org> writes:

[...]

Toggle quote (18 lines)
>> Quoting Ludovic from:
>> https://lists.gnu.org/archive/html/guix-patches/2017-05/msg00669.html
>>
>> Currently ‘guix system reconfigure’ (specifically
>> ‘upgrade-shepherd-services’) reloads and starts all services that are
>> currently stopped, on the grounds that it would not be safe/desirable to
>> simply stop any running service.
>>
>> So if you want NGINX to start with its new configuration, you need to
>> stop it before doing the 'guix system reconfigure'.
>
> Thank you for giving a direction! I actually tried to make 'sudo herd
> restart nginx' after reconfigure, but apparently it's wrong.
>
> I'm not sure if we need to close this bug. It wasn't obvious to
> me that it related to subject “Allow services to implement a 'reload'
> action”, because I tried to reload it manually :-)

The behavior of ‘reconfigure’ is not ideal, which is why Clément started
working on improving it.

However, what you report here is intended, so I’ll just close as
“not-a-bug”.

Thank you,
Ludo’.
L
L
Ludovic Courtès wrote on 11 Oct 2017 06:25
control message for bug #28776
(address . control@debbugs.gnu.org)
87shepbyuo.fsf@gnu.org
tags 28776 notabug
close 28776
?
Your comment

This issue is archived.

To comment on this conversation send an email to 28776@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 28776
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch