Subject: Re: [bug#65556] [PATCH] Added SiriKali

From: Ludovic Courtès <[email-masked]>
Date: Thu, 19 Oct 2023 22:07:06 +0200

Hi Aaron,

Sorry for the long delay!

Aaron Covrig <[email-masked]> skribis:

> Project main page: https://mhogomchungu.github.io/sirikali/
> Project GitHub: https://github.com/mhogomchungu/sirikali
>
> Comment: SiriKali provides a user friendly GUI for managing
> encrypted folders and supports 'cloud friendly' encryption
> such as CryFS, where the encrypted contents are split across
> multiple encrypted blocks. These blocks only update as their
> respective contents are changed, allowing for easier syncing
> across network links by simplifying resumption of interrupted
> transfers and providing smaller units for differential
> transfer deltas.

The comment above should rather complement the ‘description’ field of
the package.

For the commit log, we use a peculiar convention that consists in
describing the changes in terms of files, variables, etc.:

  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

(One of us can fix it up for you though, if needed.)

> +++ b/gnu/packages/sirikali.scm

Rather than create a new file, I’d suggest putting it in
file-systems.scm.

> +    (build-system cmake-build-system)
> +    (arguments
> +     '(#:tests? #f ;No tests
> +       #:configure-flags '("-DQT5=true" "-DCMAKE_BUILD_TYPE=RELEASE")))

You can remove “-DCMAKE_BUILD_TYPE=RELEASE” (the default is
“RelWithDebInfo”).

Could you send an updated patch?

Thanks in advance,
Ludo’.