Subject: Re: [bug#65075] [PATCH 01/13] gnu: Add go-github-com-chyzer-logex

From: "(" <[email-masked]>
Date: Sat, 05 Aug 2023 10:08:50 +0100

Hi!

Fries via Guix-patches via <[email-masked]> writes:
> +    (arguments
> +     '(#:import-path "github.com/chzyer/logex"
> +       #:phases (modify-phases %standard-phases
> +                  ;; Tests are completely broken on this package.
> +                  (delete 'check))))

Generally this should look like this now:

  (arguments
   (list #:import-path "github.com/chzyer/logex"
         #:phases
         #~(modify-phases %standard-phases
             (delete 'check))))

Also, generally, you'd use ``#:tests? #f'' rather than
``(delete 'check)'' to disable tests.

> --- /dev/null
> +++ b/gnu/packages/patches/go-github-com-chzyer-logex-fix-tests.patch

Doesn't this effectively do nothing, since you disabled tests?

  -- (