Subject: Re: bug#62473: [PATCH 0/4] OpenFoam update to version 10

From: Ludovic Courtès <[email-masked]>
Date: Thu, 06 Apr 2023 16:36:50 +0200

reza <[email-masked]> skribis:

> +(define-public openfoam-com
> +  (package
> +    (inherit openfoam-org)
> +    (name "openfoam-com")
> +    (version "2212")
> +    (source (origin
> +              (method url-fetch)
> +
> +              (uri (string-append "https://develop.openfoam.com"
> +                    "/Development/openfoam/-/archive/OpenFOAM-v"
> +                    version
> +                    "/openfoam-OpenFOAM-v"
> +                    version
> +                    ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0i9039hfz9gvgymkdjhjvvn5500zha3cpdbpqrzfrfi8lbz10is2"))
> +              (modules '((guix build utils)))
> +              (snippet '(begin
> +                          ;; patch shell paths
> +                          (substitute* (list "src/OSspecific/POSIX/POSIX.C"
> +                                             "wmake/src/Makefile"
> +                                             "wmake/makefiles/general"
> +                                             "wmake/makefiles/info")
> +                            (("/bin/sh")
> +                             which "sh"))))))
> +    (description
> +     "OpenFOAM is a free, open source CFD software released and developed by
> +OpenCFD Ltd since 2004.  It has a large user base across most areas of
> +engineering and science, from both commercial and academic organizations.

This is not OK:

  https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html

You can keep the description of ‘openfoam-org’, which is inherited.
However, please provide at least a different ‘synopsis’ to show how it
differs from ‘openfoam-org’.

Is the license the same for both?

Does “com” stand for “commercial”, and if so, what are the implications?

Thanks in advance,
Ludo’.