Subject: Re: bug#62473: [PATCH 0/4] OpenFoam update to version 10

From: Ludovic Courtès <[email-masked]>
Date: Thu, 06 Apr 2023 16:33:56 +0200

reza <[email-masked]> skribis:

> ---
>  gnu/local.mk                                  |   1 -
>  .../patches/openfoam-4.1-cleanup.patch        | 243 -----------
>  gnu/packages/simulation.scm                   | 405 ++++++++++++------
>  3 files changed, 263 insertions(+), 386 deletions(-)
>  delete mode 100644 gnu/packages/patches/openfoam-4.1-cleanup.patch

BTW, please consider adding ChangeLog-style commit log, as per the
project’s conventions:

  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

(We can help you if needed.)

> -(define-public openfoam
> +(define-public openfoam-org

Maybe add:

  (define-public openfoam
    (deprecated-package "openfoam" openfoam-org))

Otherwise LGTM.