Subject: Re: [bug#59552] [PATCH] gnu: Add emacs-wakatime-mode.

From: Nicolas Goaziou <[email-masked]>
Date: Sat, 26 Nov 2022 11:21:53 +0100

Hello,

Hilton Chain via Guix-patches via <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-wakatime-mode): New variable.

Thank you.

> +(define-public emacs-wakatime-mode
> +  ;; No release since May 5, 2015.
> +  (let ((version "1.0.2") ;32a0154cd4bbd525d354997e6b12c6a9726d0b43, not tagged
> +        (revision "55")
> +        (commit "ef923829912c3854d230834f81083814b7c9d992"))

You can insert "1.0.2" directly in `version' field below instead of
binding it beforehand.

> +    (package
> +      (name "emacs-wakatime-mode")
> +      (version (git-version version revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/wakatime/wakatime-mode")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "0m29817s2din4n42pflvzg2538i91s0n06y78pf8q94qf0mfspcl"))))
> +      (build-system emacs-build-system)
> +      (arguments
> +       (list #:phases
> +             #~(modify-phases %standard-phases
> +                 ;; XXX: WakaTime hasn't packaged in Guix yet.
> +                 (delete 'patch-el-files))))

Wouldn't it make sense to package WakaTime first, then?

Could you also run tests?

> +      (home-page "https://wakatime.com/emacs")
> +      (synopsis "Automatic time tracking extension for Emacs using WakaTime")
> +      (description
> +       "@code{wakatime-mode} is an Emacs plugin for automatic time tracking
> +and metrics generated from your programming activity.")

WakaTime mode is an Emacs minor mode for automatic...

Regards,
-- 
Nicolas Goaziou