Subject: Re: [bug#59372] [PATCH] gnu: peek: Add missing input.

From: "(" <[email-masked]>
Date: Sat, 19 Nov 2022 09:13:02 +0000

Heya,

On Sat Nov 19, 2022 at 1:27 AM GMT, jgart via Guix-patches via wrote:
> * gnu/packages/video.scm (peek): Add missing input.
> [inputs]: Add ffmpeg so that Peek will not fail to run on a foreign
> distro.

> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index c394c65442..4f38d4432c 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -5369,6 +5369,8 @@ (define-public peek
>      (arguments '(#:glib-or-gtk? #t))
>      (inputs
>       `(("gtk+" ,gtk+)
> +       ;; Peek fails to run on a foreign distro without ffmpeg.
> +       ("ffmpeg" ,ffmpeg)
>         ("python" ,python-wrapper)))
>      (native-inputs
>       `(("desktop-file-utils" ,desktop-file-utils) ; for update-desktop-database

I don't think this will be enough; does the program call the ``ffmpeg''
executable? If so, you'll need to patch the call to ``ffmpeg'' to point to
/gnu/store/.../bin/ffmpeg directly.

Could you also update the inputs/arguments style to gexp form?

    -- (