Subject: Re: bug#58880: 'guix gc' does not round the amount of disk space freed

From: zimoun <[email-masked]>
Date: Sat, 21 Jan 2023 17:26:29 +0100

Hi,

On Fri, 25 Nov 2022 at 21:33, Remco van 't Veer <[email-masked]> wrote:
> * guix/scripts/gc.scm (guix-gc): Round MiBs in user feedback.
> * po/*/*.po (guix/scripts/gc.scm)a: Round MiBs in user feedback.

If the way to go with the translation dance?

> ---
>  guix/scripts/gc.scm |  8 ++++----
>  po/guix/bn.po       |  6 +++---

[...]

>  po/guix/zh_CN.po    |  6 +++---
>  29 files changed, 94 insertions(+), 94 deletions(-)

The only change is:

> diff --git a/guix/scripts/gc.scm b/guix/scripts/gc.scm
> index 5e775c5cdb..2bbfb26d5d 100644
> --- a/guix/scripts/gc.scm
> +++ b/guix/scripts/gc.scm
> @@ -260,10 +260,10 @@ (define-command (guix-gc . args)
>      ;; Attempt to have at least SPACE bytes available in STORE.
>      (let ((free (free-disk-space (%store-prefix))))
>        (if (> free space)
> -          (info (G_ "already ~h MiBs available on ~a, nothing to do~%")
> +          (info (G_ "already ~,2h MiBs available on ~a, nothing to do~%")
>                  (/ free 1024. 1024.) (%store-prefix))
>            (let ((to-free (- space free)))
> -            (info (G_ "freeing ~h MiBs~%") (/ to-free 1024. 1024.))
> +            (info (G_ "freeing ~,2h MiBs~%") (/ to-free 1024. 1024.))
>              (collect-garbage store to-free)))))
>
>    (define (delete-generations store pattern)
> @@ -327,10 +327,10 @@ (define-command (guix-gc . args)
>               (ensure-free-space store free-space))
>              (min-freed
>               (let-values (((paths freed) (collect-garbage store min-freed)))
> -              (info (G_ "freed ~h MiBs~%") (/ freed 1024. 1024.))))
> +              (info (G_ "freed ~,2h MiBs~%") (/ freed 1024. 1024.))))
>              (else
>               (let-values (((paths freed) (collect-garbage store)))
> -              (info (G_ "freed ~h MiBs~%") (/ freed 1024. 1024.)))))))
> +              (info (G_ "freed ~,2h MiBs~%") (/ freed 1024. 1024.)))))))
>          ((list-roots)
>           (assert-no-extra-arguments)
>           (list-roots))

and captured by G_ so does this only to be applied and then all the
msgid updated by the translation process?

Cheers,
simon