Subject: Re: bug#57667: [PATCH] gnu: Add emacs-flymake-collection.

From: Maxim Cournoyer <[email-masked]>
Date: Wed, 28 Sep 2022 14:26:14 -0400

Hi jgart!

Nicolas had done the review below:

Nicolas Goaziou <[email-masked]> writes:

> Hello,
>
> jgart via Guix-patches via <[email-masked]> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-flymake-collection): New variable.
>
> Thanks. Some comments below.
>
>> +(define-public emacs-flymake-collection
>> +  (package
>> +    (name "emacs-flymake-collection")
>> +    (version "20220612.1340")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://melpa.org/packages/flymake-collection-"
>> +                           version ".tar"))
>
> We don't fetch tarballs from MELPA because those are not stable. Could
> you use Github as upstream instead?
>
>> +       (sha256
>> +        (base32 "1ivf7hqjnpgya6bkn83134yhw6nc29fic642jb73w60j461l2a69"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://github.com/mohkale/flymake-collection/")
>> +    (synopsis "Collection of checkers for flymake")
>
> Nitpick: Flymake
>
>> +    (description
>> +"This package tries to provide a comprehensive list of
>
> This package provides…
>
>> +diagnostic-functions for use with flymake, give users the tools to
>> +easily define new syntax checkers and help selectively enable or disable
>> +diagnostic-functions based on major-modes.")
>
> Nitpick: major modes

Could you please address the comments and send a v2?

Thank you,

Maxim