Subject: Re: bug#57460: [PATCH 00/19] Refresh to specific version

From: Ludovic Courtès <[email-masked]>
Date: Sat, 24 Sep 2022 11:34:53 +0200

Hartmut Goebel <[email-masked]> skribis:

> * guix/import/kde.scm(latest-kde-release): Rename to (import-kde-release), add
>   keyword-argument 'version'.  Rework the code to not sort the relevant files,
>   but just find the requested or latest version.
>   [find-latest-archive-version]: New function.

(Same comment.)
[...]

> +         ;; find latest version
> +         (version (or version
> +                      (and (not (null? relevant))
> +                           (tarball->version (find-latest-archive-version relevant)))))
> +         ;; find archives matching this version
> +         (archives (filter (lambda (file)
> +                             (string=? version (tarball->version file)))
> +                           relevant)))

I think you can remove the comments or make them proper sentences
(capitalized and with a period).  I’d prefer to keep the name ‘tarballs’
rather than ‘archives’ because it’s less ambiguous IMO.

> +    (match archives
> +           (() #f)
> +           (_

Please reindent it as it was.