Subject: Re: [PATCH v2] gnu: python-slixmpp: Update to 1.8.1.

From: Maxim Cournoyer <[email-masked]>
Date: Sat, 23 Apr 2022 23:32:53 -0400

Hi jgart,

jgart <[email-masked]> writes:

> * gnu/packages/python-xyz.scm (python-slixmpp): Update to 1.8.1.
> [arguments]: Remove trailing boolean, use new style, and use 
> cc-for-target.
> [native-inputs]: Use new style.
>
> Hi Maxim,
>
> Here is the second version of this patch.
>
> I think this adds what you suggested in the code review.
>
> thanks,
>
> jgart
>
> ---
>  gnu/packages/python-xyz.scm | 25 ++++++++++++-------------
>  1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 219a0d9213..1654fc2894 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -688,7 +688,7 @@ (define-public python-mkdocs-material
>  (define-public python-slixmpp
>    (package
>      (name "python-slixmpp")
> -    (version "1.5.2")
> +    (version "1.8.1")
>      (source
>       (origin
>         (method git-fetch)
> @@ -700,21 +700,20 @@ (define-public python-slixmpp
>         (file-name
>          (git-file-name name version))
>         (sha256
> -        (base32 "15mqxcws14bjvh5jcfwl86zsvrymkdw3ya07vb44md7vfnsnclwx"))))
> +        (base32 "0723m7pbyf4xnsy381drni3kr8wm60637gn6d7fbf4i5m04jy9iy"))))
>      (build-system python-build-system)
>      (arguments
> -     `(#:phases
> -       (modify-phases %standard-phases
> -         (add-after 'unpack 'patch
> -           (lambda _
> -             (substitute* "setup.py"
> -               (("'CC', 'cc'")
> -                "'CC', 'gcc'"))
> -             #t)))))
> +      (list #:phases
> +            #~(modify-phases %standard-phases
> +                (add-after 'unpack 'patch
> +                  (lambda _
> +                    (substitute* "setup.py"
> +                      (((string-append "'CC', " #$(cc-for-target)))
> +                       ((string-append "'CC', " #$(cc-for-target))))))))))

This doesn't look right; the matched pattern is replaced by... the same
thing?

>      (native-inputs
> -     `(("cython" ,python-cython)
> -       ("gnupg" ,gnupg)
> -       ("pkg-config" ,pkg-config)))
> +      (list python-cython
> +            gnupg
> +            pkg-config))

Are you sure pkg-config is needed?  That's unusual in Python packages.

Thanks,

Maxim