Subject: Re: bug#53144: [PATCH 0/13] Make more git-using packages auto-updatable

From: Ludovic Courtès <[email-masked]>
Date: Tue, 18 Jan 2022 18:33:45 +0100

Maxime Devos <[email-masked]> skribis:

> This is currently pointless, because no updater returns such versions.

s/pointless/unused/  :-)

> A future patch will introduce an updater returning such versions.
>
> * guix/upstream.scm
>   (git-version-regexp): New variable.
>   (maybe-git-version, maybe-git-version->revision)
>   (maybe-git-versions->revision-replacements): New procedures.
>   (update-package-source): Use 'package-definition-location' instead of
>   'package-location'.  Also replace the revision.

Please mention tests/upstream.scm too.

Otherwise LGTM.

Ludo’.