Subject: Re: bug#42771: smalltalk fails to build

From: Ludovic Courtès <[email-masked]>
Date: Mon, 04 Jan 2021 10:28:35 +0100

Hi Miguel,

Miguel Ángel Arruga Vivas <[email-masked]> skribis:

> I've been investigating just a bit about this.

Nice!

> From c4385abde62bba4c634a7a874c2f431451909ec2 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
>  <[email-masked]>
> Date: Mon, 28 Dec 2020 10:36:48 +0100
> Subject: [PATCH 1/2] gnu: smalltalk: Fix integer multiplication overflow.
>
> * gnu/packages/patches/smalltalk-multiplication-overflow.patch: Patch
> from upstream commit 72ada189aba0283c551ead16635c1983968080b8.
> * gnu/packages/smalltalk.scm (smalltalk): Use patch and link with gmp
> and lightning libraries instead of the included source.
> ---
>  .../smalltalk-multiplication-overflow.patch   | 121 ++++++++++++++++++
>  gnu/packages/smalltalk.scm                    |  43 ++++++-

Please make sure to add the patch to ‘gnu/local.mk’ as well.  Otherwise
LGTM.

> From 46809e6c265280571ff024c749c448c74af79c1a Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
>  <[email-masked]>
> Date: Mon, 28 Dec 2020 11:42:31 +0100
> Subject: [PATCH 2/2] gnu: smalltalk: Update to version 3.2.91.
>
> * gnu/packages/smalltalk.scm (smalltalk): Update to 3.2.91.
>
> Co-Authored-By: Holger Peters <[email-masked]>

LGTM.

Thanks for investigating!

We can address the non-reproducibility issues separately.  Perhaps you
can send your findings to bug-guix so we can keep track of it.

Ludo’.