Subject: Re: [bug#42056] [PATCH] gnu: Add xloadimage.

From: Ludovic Courtès <[email-masked]>
Date: Sat, 27 Jun 2020 19:12:32 +0200

Hi Brice,

Brice Waegeneire <[email-masked]> skribis:

> * gnu/packages/xorg.scm (xloadimage): New variable.
> * gnu/packages/patches/xloadimage-debian-series-25.patch: New file …
> * gnu/local.mk (dist_patch_DATA): … add it.

[...]

> +++ b/gnu/packages/patches/xloadimage-debian-series-25.patch
> @@ -0,0 +1,7665 @@
> +Combined patches from Debian: https://sources.debian.org/patches/xloadimage/4.1-25/

We should keep ’em separated, for clarity.

However:

> +Index: xloadimage.4.1.old/Makefile.in
> +===================================================================
> +--- /dev/null
> ++++ xloadimage.4.1.old/Makefile.in

[...]

> +--- /dev/null
> ++++ xloadimage.4.1.old/configure
> +@@ -0,0 +1,2476 @@
> ++#! /bin/sh
> ++
> ++# Guess values for system-dependent variables and create Makefiles.
> ++# Generated automatically using autoconf version 2.13 
> ++# Copyright (C) 1992, 93, 94, 95, 96 Free Software Foundation, Inc.

This adds an Autoconf-generated ‘configure’ file.  IOW, it seems we’re
adding a complete build system that’s not available upstream.

It seems to me that it’s too much.  It would be okay to add a couple of
Makefile.in and a minimalist ‘configure.ac’, if they’re small, and from
there to run the bootstrap phase.

It would be better to try and use upstream’s build system though.

Thoughts?

Ludo’.