Subject: Re: [bug#36615] [PATCH] gnu: Add opencascade-occt.

From: Ludovic Courtès <[email-masked]>
Date: Fri, 12 Jul 2019 23:51:31 +0200

Hi Paul,

Paul Garlick <[email-masked]> skribis:

> * gnu/packages/maths.scm (opencascade-occt): New variable.

[...]

> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +              "https://git.dev.opencascade.org/gitweb/?p=occt.git;"
> +              "a=snapshot;sf=tgz;h=refs/tags/V"
> +              (string-map (lambda (x) (if (eq? x #\.) #\_ x)) version)))

I think you should use ‘git-fetch’ instead because generated tarballs
are notoriously prone to silent change.

> +    (arguments
> +     '(;; There is no test target for make.
> +       #:tests? #f

Sometimes CMake-based packages have a configure-time option like
-DWITH_TESTS=ON.  Is there something like that here?

Apart from that it LGTM.  Thank you!

Ludo’.