Subject: Re: [bug#36469] [PATCH 2/2] pack: 'squashfs' backend records the profile's search paths.

From: Ricardo Wurmus <[email-masked]>
Date: Thu, 04 Jul 2019 13:17:54 +0200

Ludovic Courtès <[email-masked]> writes:

> From: Ludovic Courtès <[email-masked]>
>
> * guix/scripts/pack.scm (singularity-environment-file): New procedure.
> (squashfs-image): Use it, and create /.singularity/env/90-environment.sh.
> * gnu/tests/singularity.scm (run-singularity-test)["singularity run,
> with environment"]: New test, currently skipped.
> * gnu/tests/singularity.scm (build-tarball&run-singularity-test): Add
> GUILE-JSON to the profile.

This looks good to me.

I think it would be good to separate squashfs-image and singularity
going forward as we discussed earlier, but for now mixing the two is
fine.

Thanks!

--
Ricardo