Subject: Re: [bug#27689] [PATCH] gnu: grub-efi: Add mtools input.

From: Danny Milosavljevic <[email-masked]>
Date: Fri, 14 Jul 2017 20:12:15 +0200

Hi Marius,

On Fri, 14 Jul 2017 18:49:24 +0200
Marius Bakke <[email-masked]> wrote:

> Danny Milosavljevic <[email-masked]> writes:
> 
> > * gnu/packages/bootloaders.scm: Add (gnu packages mtools).
> > (grub-efi)[inputs]: Add mtools.
> > [arguments]: Add phase "use-absolute-mtools-path".  
> 
> Why is this only necessary for grub-efi?

I checked the grub source code and mformat and mcopy are only used in util/grub-mkrescue.c if source_dirs[GRUB_INSTALL_PLATFORM_*_EFI].

If that's too fine-grained, we can also add it to grub itself.  But I'm sure it's only used for grub-mkrescue in the case of EFI.

> > +               (add-after 'patch-stuff 'use-absolute-mtools-path
> > +                 (lambda* (#:key inputs #:allow-other-keys)
> > +                   (let ((mtools (assoc-ref inputs"mtools")))  
>                                                     ^^^
> Missing space.

Thanks :)