Subject: Re: bug#26173: [PATCH 2/4] services: openssh: Add 'subsystems' option.

From: [email-masked] (Ludovic Courtès)
Date: Mon, 20 Mar 2017 21:18:56 +0100

Clément Lassieur <[email-masked]> skribis:

> * gnu/services/ssh.scm (openssh-config-file): Add it.
> (<openssh-configuration>)[subsystems]: Add it.
> * doc/guix.texi (Networking Services): Document it.

[...]

> +@item @code{subsystems} (default: @code{'(("sftp" "internal-sftp"))})
> +Configures external subsystems (e.g. file transfer daemon).
> +
> +This is a list of two-element lists, each of which containing the
> +subsystem name and a command (with optional arguments) to execute upon
> +subsystem request.
> +
> +The command @command{internal-sftp} implements an in-process SFTP server.

Maybe you can add an @example for the external SFTP server, just to show
what the syntax is like.

Otherwise LGTM, thanks!

Ludo’.