Subject: Re: bug#26173: [PATCH 2/4] services: openssh: Add 'subsystems' option.

From: [email-masked] (Ludovic Courtès)
Date: Tue, 21 Mar 2017 15:23:57 +0100

Clément Lassieur <[email-masked]> skribis:

> * gnu/services/ssh.scm (openssh-config-file): Add it.
> (<openssh-configuration>)[subsystems]: Add it.
> * doc/guix.texi (Networking Services): Document it.

[...]

> +The command @command{internal-sftp} implements an in-process SFTP
> +server.  Alternately, one can specify the @command{sftp-server} command:
> +@example
> +(service openssh-service-type
> +         (openssh-configuration
> +          (subsystems
> +           '(("sftp" "/run/current-system/profile/libexec/sftp-server")))))
> +@end example

Maybe the example should use:

  `(("sftp" ,(file-append openssh "/libexec/sftp-server")))

which looks better IMO (assuming it works, but I think it does.)

OK for you to push the whole series.

Thanks!

Ludo’.