GNU bug report logs

#78649 (recursive? #t) doesn't seem to be part of the source hash

PackageSource(s)Maintainer(s)
guix PTS Buildd Popcon
Full log

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

Received: (at submit) by debbugs.gnu.org; 30 May 2025 22:56:25 +0000
From debbugs-submit-bounces@debbugs.gnu.org Fri May 30 18:56:24 2025
Received: from localhost ([127.0.0.1]:52105 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1uL8eG-0007dV-41
	for submit@debbugs.gnu.org; Fri, 30 May 2025 18:56:24 -0400
Received: from lists.gnu.org ([2001:470:142::17]:40076)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <nomike@nomike.com>) id 1uL8eD-0007cY-48
 for submit@debbugs.gnu.org; Fri, 30 May 2025 18:56:21 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <nomike@nomike.com>) id 1uL8e7-0007ES-Gu
 for bug-guix@gnu.org; Fri, 30 May 2025 18:56:15 -0400
Received: from cyan.elm.relay.mailchannels.net ([23.83.212.47])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <nomike@nomike.com>) id 1uL8e2-0002Rh-Fs
 for bug-guix@gnu.org; Fri, 30 May 2025 18:56:13 -0400
X-Sender-Id: dreamhost|x-authsender|nomike@nomike.com
Received: from relay.mailchannels.net (localhost [127.0.0.1])
 by relay.mailchannels.net (Postfix) with ESMTP id 5AE314E5B98
 for <bug-guix@gnu.org>; Fri, 30 May 2025 22:56:07 +0000 (UTC)
Received: from pdx1-sub0-mail-a225.dreamhost.com
 (trex-green-6.trex.outbound.svc.cluster.local [100.126.10.237])
 (Authenticated sender: dreamhost)
 by relay.mailchannels.net (Postfix) with ESMTPA id 00FA54E57E3
 for <bug-guix@gnu.org>; Fri, 30 May 2025 22:56:06 +0000 (UTC)
ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1748645767; a=rsa-sha256;
 cv=none;
 b=tUgmvQesUccuyGeeidyPeRe9MKbvlgIhF6lDYxjBuhNyMOOwtIj1Xm8ZiexBgSbEX2/Bnh
 YDtaYZI63HoPlS/W9167hSusfYu56kw7JdnFBe/dZGH2BlTwutuDzTPDwLO8KnL6i1fa5+
 a/90S8e726ks+ET798+R3ttdDofgiPLJZYQDwIQrMRTKIQz4l35ZDrsPhsBRV7eUJCLFYf
 sIpLLby8bqppaeqhkERd953gwWAFj4GYYfP3Qouho3B6IwsaZeb8XhNwHftFGLUdnOCSPp
 jY8x4xT0O9X9S5sRZ/ih2xxXithtZ4PkTLR31IhyIk3sf2ThUzH+piB6C6PIHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
 d=mailchannels.net; s=arc-2022; t=1748645767;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:dkim-signature:autocrypt:autocrypt;
 bh=Xl8LW0o6y2/5/Z+mUapAMRtsrfMeLeLPZbnNHsn2eww=;
 b=xR5dmofRqKXLxBULaduBLM2TQgFghnM4ViOf740XzpfxuuDs2SdDuB1MUPFebRW7hQ2GLh
 dJIYKDgiOgOdm/8327B2qdZUwL5wv3ghY0FFqW3ZfxF+DNq6vz1GdSCWWl6QlnmJCD2ExQ
 10ziffpeJwsILtf5Zd0SeVtXCDQFsJL8Z6P9mcYii5HkjtEsGDyU2rOxCval5e6jZxJN6r
 OwIZBDTOVJo4VKCheKU3Plo6GMWOydHVDF2yq+XUUFXqkRKrLjmQbRVsbOiIy0q7LlM5eb
 8XZ9s3UwJ0JgwYcxviYkU6Pxhi5pgVRmBPiN0nZHpEz3jaqeT9fJv2WPCah9lw==
ARC-Authentication-Results: i=1; rspamd-cc9cfccc-5vpz5;
 auth=pass smtp.auth=dreamhost smtp.mailfrom=nomike@nomike.com
X-Sender-Id: dreamhost|x-authsender|nomike@nomike.com
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|nomike@nomike.com
X-MailChannels-Auth-Id: dreamhost
X-Wide-Eyed-Invention: 38f1daa316278bea_1748645767213_2873291327
X-MC-Loop-Signature: 1748645767213:766440223
X-MC-Ingress-Time: 1748645767212
Received: from pdx1-sub0-mail-a225.dreamhost.com (pop.dreamhost.com
 [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384)
 by 100.126.10.237 (trex/7.0.3); Fri, 30 May 2025 22:56:07 +0000
Received: from [10.31.0.156] (84-112-221-106.cable.dynamic.surfer.at
 [84.112.221.106])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 (Authenticated sender: nomike@nomike.com)
 by pdx1-sub0-mail-a225.dreamhost.com (Postfix) with ESMTPSA id 4b8JWB3QTTz3P
 for <bug-guix@gnu.org>; Fri, 30 May 2025 15:56:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nomike.com;
 s=dreamhost; t=1748645766;
 bh=Xl8LW0o6y2/5/Z+mUapAMRtsrfMeLeLPZbnNHsn2eww=;
 h=Date:To:From:Subject:Content-Type:Content-Transfer-Encoding;
 b=EjKM83Zr2U4bVmnQpyCqk/cBhKBm4w6a9mz1WHCrBcGms4RzY2PkDcxSQrwJvyLsE
 TrtrQVBDKCvf6lfiDPM28ST2bH11lDF11IQFCYyvEpgbT0ekDvT1ocDylf2kHYABnK
 iJCMBm0jss7nZyLusJBi/Db1+zrvUcqeq/8Q/Vxsz5ygBHUF/u8HjWnZCYu+3811RA
 LnOtaruD2Jjs7ecusW9tu+5XlDPikB6aCr+e1XTx2KX/QHhle7ONrP/LJjY+Av2opP
 8PXlwvUkKVXnwVa7kcK7/fIgv+LZBbw1nL8qn11QhTTdGG8pGxg9wtqvFDpqmk32KG
 ikpqcpnC0oaZw==
Message-ID: <331afb8a-fa7f-4935-b990-ebd6f5268b58@nomike.com>
Date: Sat, 31 May 2025 00:56:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: bug-guix@gnu.org
From: "nomike (they/them)" <nomike@nomike.com>
Subject: (recursive? #t) doesn't seem to be part of the source hash
Autocrypt: addr=nomike@nomike.com; keydata=
 xjMEZ+8bGhYJKwYBBAHaRw8BAQdAnX/6ThbmnmGYDNklZjA0bz600QNUdP+ajuwTe4TVe4PN
 L25vbWlrZSBQb3N0bWFubiAodGhleS90aGVtKSA8bm9taWtlQG5vbWlrZS5jb20+wpkEExYK
 AEECGwMFCQWjmoACHgcCF4AWIQRDQfMGyihCx53NO0tbWPztpJIHVwUCZ+8vPgULCQgHAgIi
 AgYVCgkICwIEFgIDAQAKCRBbWPztpJIHV6A3APoCTSYs7uR0ZoxGMoEFdDUdgbdmPFNZSNoA
 3J5js9FQwgD/UUGwD9PCILmGZTeyG1BmUUFIDshW/NlKtgzc38AeRQ3OOARn7xsaEgorBgEE
 AZdVAQUBAQdAQYFr4LDmq9tDyrJ1hmbnQ18nN/TEzmM+X0Dc84f+51UDAQgHwn4EGBYKACYW
 IQRDQfMGyihCx53NO0tbWPztpJIHVwUCZ+8bGgIbDAUJBaOagAAKCRBbWPztpJIHV549AQCo
 MLaLPJ8OhIRvEJkvS2nVEn+D/DKG7bxxbyvB5gwaqgEA3aVP643HUqWDp2u9q+57SCycExVI
 mOW3VG9jxDNJlAc=
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=23.83.212.47; envelope-from=nomike@nomike.com;
 helo=cyan.elm.relay.mailchannels.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

Hi!

I'm currently working on a package definition and again stumbled upon an 
issue:

I had the flag `(recursive? #t)` added to `source`:

```scheme
      (source
       (origin
         (method git-fetch)
         (uri (git-reference
               (url "https://github.com/openscad/openscad")
               (commit commit)
               (recursive? #t)))
         (sha256
          (base32 "1bkzrjjp0qvfg7pj24j5pa0i6zj0zsqjb5z4w3l6pjdb5q9in0qi"))
         (file-name (git-file-name name version))))
```

I then removed the recursive flag and continued on working on my 
package, which is based on a commit-ID of the upstream project. Once I 
switched to a newer commit, I got strange build errors from cmake. I 
switched back the original commit, everything worked again.
It took me a while to remember, that in such a case, guix is not 
re-downloading the source as the source hash doesn't change.

IMHO this hash should also contain flags like recursive.

When  `git clone foo` is changed to `git clone --recursive foo` the 
source has obviously changed (unless the repo doesn't have submodules 
perhaps), so it doesn't make sense that the sha256 hash stays the same.

Is this something we can address?

Or is this an issue as it would invalidate all current source hashes at 
once?

Thanks

nomike

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Mon Sep 8 22:05:10 2025; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.