#76895 [PATCH 0/2] Improve senpai package integration and cleanup

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Luis Guilherme Coelho <lgcoelho@disroot.org>

To: guix-patches@gnu.org

Cc: Luis Guilherme Coelho <lgcoelho@disroot.org>

Subject: [PATCH 0/2] Improve senpai package integration and cleanup

Date: Sun, 9 Mar 2025 13:30:08 -0300

This patch series improves the senpai package by adding a desktop
file for better integration with desktop environments and cleaning
up redundant mkdir-p calls in the package definition.

Luis Guilherme Coelho (2):
  gnu: senpai: Install desktop file.
  gnu: senpai: Remove redundant mkdir-p calls.

 gnu/packages/messaging.scm | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)


base-commit: a5256944a35e91be71b1348e805a341fe06cbb8d
-- 
2.48.1

Message #8 received at 76895@debbugs.gnu.org (full text, mbox, reply):

From: Luis Guilherme Coelho <lgcoelho@disroot.org>

To: 76895@debbugs.gnu.org

Cc: Luis Guilherme Coelho <lgcoelho@disroot.org>

Subject: [PATCH 1/2] gnu: senpai: Install desktop file.

Date: Sun, 9 Mar 2025 13:44:30 -0300

* gnu/packages/messaging.scm (senpai)[arguments]<#:phases>: Add
'install-desktop-file phase.

Change-Id: Ib2b84639a3bfa5ff211eda794a99370a1c39061c
---
 gnu/packages/messaging.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index d2bc9fcfac..a19673a463 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -3722,7 +3722,12 @@ (define-public senpai
                       man1)
                      (install-file
                       (string-append "src/" unpack-path "/doc/senpai.5")
-                      man5)))))))
+                      man5))))
+               (add-after 'install 'install-desktop-file
+                (lambda* (#:key unpack-path #:allow-other-keys)
+                  (install-file
+                    (string-append "src/" unpack-path "/contrib/senpai.desktop")
+                    (string-append #$output "/share/applications")))))))
     (native-inputs
      (list go-git-sr-ht-emersion-go-scfg
            go-github-com-delthas-go-libnp
-- 
2.48.1

Message #11 received at 76895@debbugs.gnu.org (full text, mbox, reply):

From: Luis Guilherme Coelho <lgcoelho@disroot.org>

To: 76895@debbugs.gnu.org

Cc: Luis Guilherme Coelho <lgcoelho@disroot.org>

Subject: [PATCH 2/2] gnu: senpai: Remove redundant mkdir-p calls.

Date: Sun, 9 Mar 2025 13:44:31 -0300

* gnu/packages/messaging.scm (senpai)[arguments]<#:phases>:
{install-doc}: Remove unecessary mkdir-p calls.

Change-Id: I819561888579e86fc9f8e534d54fb79240fe2f09
---
 gnu/packages/messaging.scm | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index a19673a463..04dd0afbc8 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -3713,16 +3713,12 @@ (define-public senpai
                            "-C" (string-append "src/" unpack-path))))
                (add-after 'install 'install-doc
                  (lambda* (#:key unpack-path #:allow-other-keys)
-                   (let ((man1 (string-append #$output "/share/man/man1"))
-                         (man5 (string-append #$output "/share/man/man5")))
-                     (mkdir-p man1)
-                     (mkdir-p man5)
-                     (install-file
-                      (string-append "src/" unpack-path "/doc/senpai.1")
-                      man1)
-                     (install-file
-                      (string-append "src/" unpack-path "/doc/senpai.5")
-                      man5))))
+                   (install-file
+                    (string-append "src/" unpack-path "/doc/senpai.1")
+                    (string-append #$output "/share/man/man1"))
+                   (install-file
+                    (string-append "src/" unpack-path "/doc/senpai.5")
+                    (string-append #$output "/share/man/man5"))))
                (add-after 'install 'install-desktop-file
                 (lambda* (#:key unpack-path #:allow-other-keys)
                   (install-file
-- 
2.48.1

Send a report that this bug log contains spam.