#76892 [PATCH v1] gnu: ntp: Fix crash.

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Jakob Kirsch <jakob.kirsch@web.de>

To: guix-patches@gnu.org

Subject: [PATCH v1] gnu: ntp: Fix crash.

Date: Sun, 9 Mar 2025 16:19:51 +0100

[Message part 1 (text/plain, inline)]

ntpd segfaults at boot so here is a patch to fix that.

[v1-0001-gnu-ntp-Fix-crash.patch (text/plain, attachment)]

Message #8 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Leo Famulari <leo@famulari.name>

To: Jakob Kirsch via Guix-patches via <guix-patches@gnu.org>

Cc: 76892@debbugs.gnu.org

Subject: Re: [bug#76892] [PATCH v1] gnu: ntp: Fix crash.

Date: Sun, 9 Mar 2025 17:36:14 -0400

On Sun, Mar 09, 2025 at 04:19:51PM +0100, Jakob Kirsch via Guix-patches via wrote:
> ntpd segfaults at boot so here is a patch to fix that.

> From 3ebd9d493240978d5f2b14e55ed63754c43151c3 Mon Sep 17 00:00:00 2001
> Message-ID: <3ebd9d493240978d5f2b14e55ed63754c43151c3.1741533506.git.jakob.kirsch@web.de>
> From: Jakob Kirsch <jakob.kirsch@web.de>
> Date: Sun, 9 Mar 2025 16:16:43 +0100
> Subject: [PATCH v1] gnu: ntp: Fix crash.
> 
> * gnu/packages/ntp.scm (ntp): Add patch.
> * gnu/packages/patches/ntp-fix-dereferencing-the-wrong-variable.patch: Add patch.
> * gnu/local.mk (dist_patch_DATA): Register patch.

Is the only change in this patch that we build ntp with the new patch
file? And the rest of it is changes to indentation? Or are there other
changes too?

Message #14 received at 76892@debbugs.gnu.org (full text, mbox, reply):

From: Jakob Kirsch <jakob.kirsch@web.de>

To: 76892@debbugs.gnu.org

Date: Sun, 9 Mar 2025 22:52:17 +0100

Yes I only added the patch to fix the crash (it's a typo where ep should be ep2) and ran `guix style ntp` on it.

Message #17 received at 76892@debbugs.gnu.org (full text, mbox, reply):

From: Ian Eure <ian@retrospec.tv>

To: Leo Famulari <leo@famulari.name>

Cc: 76892@debbugs.gnu.org

Subject: Re: [bug#76892] [PATCH v1] gnu: ntp: Fix crash.

Date: Sun, 09 Mar 2025 21:48:10 -0700

Hi Jakob, Leo,

Leo Famulari <leo@famulari.name> writes:

> On Sun, Mar 09, 2025 at 04:19:51PM +0100, Jakob Kirsch via 
> Guix-patches via wrote:
>> ntpd segfaults at boot so here is a patch to fix that.
>
>> From 3ebd9d493240978d5f2b14e55ed63754c43151c3 Mon Sep 17 
>> 00:00:00 2001
>> Message-ID: 
>> <3ebd9d493240978d5f2b14e55ed63754c43151c3.1741533506.git.jakob.kirsch@web.de>
>> From: Jakob Kirsch <jakob.kirsch@web.de>
>> Date: Sun, 9 Mar 2025 16:16:43 +0100
>> Subject: [PATCH v1] gnu: ntp: Fix crash.
>> 
>> * gnu/packages/ntp.scm (ntp): Add patch.
>> * 
>> gnu/packages/patches/ntp-fix-dereferencing-the-wrong-variable.patch: 
>> Add patch.
>> * gnu/local.mk (dist_patch_DATA): Register patch.
>
> Is the only change in this patch that we build ntp with the new 
> patch
> file? And the rest of it is changes to indentation? Or are there 
> other
> changes too?

Here’s the upstream bug(s): 
https://bugs.ntp.org/show_bug.cgi?id=3928 
https://bugs.ntp.org/show_bug.cgi?id=3968

I think this patch is fine, we might also consider rolling back to 
4.2.8p17.

-- Ian

Message #22 received at 76892-done@debbugs.gnu.org (full text, mbox, reply):

From: Ludovic Courtès <ludo@gnu.org>

To: Ian Eure <ian@retrospec.tv>

Cc: Jakob Kirsch <jakob.kirsch@web.de>, 76401-done@debbugs.gnu.org, 76892-done@debbugs.gnu.org, Leo Famulari <leo@famulari.name>

Subject: Re: bug#76892: [PATCH v1] gnu: ntp: Fix crash.

Date: Wed, 19 Mar 2025 11:24:33 +0100

Ian Eure <ian@retrospec.tv> skribis:

> Here’s the upstream bug(s): https://bugs.ntp.org/show_bug.cgi?id=3928
> https://bugs.ntp.org/show_bug.cgi?id=3968
>
> I think this patch is fine, we might also consider rolling back to
> 4.2.8p17.

Applied, with a reference to <https://issues.guix.gnu.org/76401> too.

Thanks,
Ludo'.

Send a report that this bug log contains spam.