#76660 - Downgrade prevention triggers erroneously with 'guix pull'

Package	Source(s)		Maintainer(s)
guix		PTS Buildd Popcon

Message #38 received at 76660@debbugs.gnu.org (full text, mbox, reply):

Received: (at 76660) by debbugs.gnu.org; 9 Mar 2025 23:38:26 +0000
From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 09 19:38:26 2025
Received: from localhost ([127.0.0.1]:34977 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1trQDy-0007Wz-66
	for submit@debbugs.gnu.org; Sun, 09 Mar 2025 19:38:26 -0400
Received: from wolfsden.cz ([37.205.8.62]:60600)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1trQDv-0007Wn-Ch
 for 76660@debbugs.gnu.org; Sun, 09 Mar 2025 19:38:24 -0400
Received: by wolfsden.cz (Postfix, from userid 104)
 id 1FCB1252FC6; Sun,  9 Mar 2025 23:38:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1741563501; bh=yOA7nT/hyJSaqIN92QacNdi7WTnjYeR7naNOiB04Qpg=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date;
 b=d2puxykLDHt0tOBIyCMKKiKpm6Cv9vMxkOcyONFlD/3207OzmW7a90Ko8DozLCiQE
 l13E3OHWwUKH2IDHY4+5D8KkTEaJwy8X3CHAOMR3TyWMWdav2cpRrKiFeq8ywCAyrK
 B3abwxy3ZBTGy/iY8Fz3tW2UeaVIFA+V/dV6THt/hFmN4IUddNzGJBCcTr4efP+9yF
 LN745+HXbq/PpCmxiclD/8wdnLb7tWXGVVcHQ+4UbsY67r9zBtr5HEZaWNaqW2HDbz
 GjXVi1/tuJFvChejx5pp22COWJJPpSd++W2bwETXeAH3Nal0DEa4hhn/lNNbhNm4us
 BQAviGtZNonOG8gcYXIkQ9w7287V1HAa0xuYEa26EAgvG6La3I7hNIBqu4pI8U+iOO
 /GpE7Qs9hLrZrNjajOGj82EBfK0L+GklZoyfsG+Ee4OklpaO4NCSPRPwGkVxROkObV
 qvXtZPCzKJ11XaN/B+920TANHc+2u4GWxPRUmYpBYNyTnuIXuFS2Bn6GW0hYwsp72L
 B4OuBp8pU4m9v5Z6Pm5khNlePNv+mMJhJVhXRyUcNhwaysvI5IhKtd1z1fitjgjEHf
 HWgOj3euXvPVAG2bYvh0hev/BHqsLxuFjOCdwjEQA05sITvHkVDFEeRxmyEMCN544u
 Iry4xd6YZh+17jzJ4+WfaQN8=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level: 
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
 autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
 by wolfsden.cz (Postfix) with ESMTPSA id B751D291C90;
 Sun,  9 Mar 2025 23:38:20 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1741563500; bh=yOA7nT/hyJSaqIN92QacNdi7WTnjYeR7naNOiB04Qpg=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date;
 b=A5pvrzcjmhkFtfcwCiv3cp+kbH1Bw3uroMSphxzbfSFzOAVZxcDoFybIMwwqzS+DD
 YR77Id+5zBR/MdllEX/Q/TM9CUTZtjq12X4vOm0bkOclFqiUd5ZrtMcxNRwccNkHsz
 4bgZDq50oarZJ1AT/fTVPDDlzaTVaNGQJUoXPXec2u1cNiBu1R/PizsKcUGq32fbOp
 Gu7ZClic64Q1OED5YkE24u0rXGDe2nheSth7ssXgqmAF+nKWwu5Yv3iBnaGKIL5xAB
 Pua45biBHrjaQFSiWcGCX1rwdWMZ6iT2wi0UkaflhAmBa5c+3ZVCTwrXlLC+uopwS3
 jbzKejk4Xvrcivz36dQFv4IYWAZJoPqm9nIp/t+GvkphUtoblE6mcvKz5TmkLSyfWG
 S5jU/2Vh0HhJed/naYxGsCfWYvHf5H5MBcnG1rsiapIWbXadN0vrhewjh1D9Qcr1Hz
 1TcUU9JkzdY0nyBFrzjoHeza/rM2LDi6849aumPkAvl1dFEo3DTLDpVji1Cv+gXKM0
 elNJrsWdGAXuWe/BUpj/gT5DDtzvzJFKcm1MWfBZpA8lwgTr7IrlQvE6EGTn6JGL2Q
 cZDFQ50M292Rn9Ku+y8KWvbApOQiQ5EwzLnFofxsERBKYyl9Ld+qjMXX4Gi70gLZpT
 xGEwsPwFw9GJW2zqPhB4lmwA=
From: Tomas Volf <~@wolfsden.cz>
To: Leo Famulari <leo@famulari.name>
Subject: Re: bug#76660: current guix pull doesn't authenticate
In-Reply-To: <Z84IoyZfmIiwBq9n@jasmine.lan> (Leo Famulari's message of "Sun, 9
 Mar 2025 17:31:15 -0400")
References: <alpine.DEB.2.21.2503011134420.24671@marsh.hcoop.net>
 <Z8Sog2wmaP2rT0IT@jasmine.lan> <87mse3jlml.fsf@wolfsden.cz>
 <Z8TgDzBDgv5UPBUJ@jasmine.lan> <875xkrj8vg.fsf@wolfsden.cz>
 <alpine.DEB.2.21.2503072212540.24671@marsh.hcoop.net>
 <87ldtezgxy.fsf@wolfsden.cz> <Z84IoyZfmIiwBq9n@jasmine.lan>
Date: Mon, 10 Mar 2025 00:38:20 +0100
Message-ID: <871pv5zser.fsf@wolfsden.cz>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76660
Cc: Jack Hill <jackhill@jackhill.us>, 76660@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

[Message part 1 (text/plain, inline)]

Leo Famulari <leo@famulari.name> writes:

> On Sun, Mar 09, 2025 at 10:33:45AM +0100, Tomas Volf wrote:
>> I think it could be influenced by the commit you are currently on, and
>> the commit you are pulling as latest.  So depending on time of previous
>> and current pull, it might work or it might not work.  I assume that
>> limits the amount of affected people.
>
> Yes, it might or might not work. Some of us can pull from the "bad
> commit", and some of us can't:
>
> https://issues.guix.gnu.org/76660#6
>
> So, either we don't understand all the conditions that trigger this bug,
> or it's not deterministic. But we should work to get the fix into
> guile-git.

There is nothing to fix in guile-git, the fix needs to go into (guix
git).  The libgit2 (which guile-git is wrapping) simply does not
guarantee that two gets of the same commit hash will return identical
pointer.  So I believe (guix git) is in the wrong here for using eq?.

Well, I guess guile-git could go beyond what libgit2 promises, and
introduce its own caching layer, but I am not sure that is the correct
course of action.  But its up to Ludo' of course.

Tomas

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[signature.asc (application/pgp-signature, inline)]

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Sep 7 15:44:29 2025; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#76660 Downgrade prevention triggers erroneously with 'guix pull'