#74051 [PATCH] gnu: Add emacs-weblorg

Message #11 received at 74051@debbugs.gnu.org (full text, mbox, reply):

Received: (at 74051) by debbugs.gnu.org; 28 Oct 2024 12:09:11 +0000
From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 08:09:10 2024
Received: from localhost ([127.0.0.1]:52811 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1t5OYY-0004qT-Ai
	for submit@debbugs.gnu.org; Mon, 28 Oct 2024 08:09:10 -0400
Received: from drosera-smtp.ehess.fr ([193.48.45.73]:41144
 helo=drosera.ehess.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mattia.bunel@ehess.fr>) id 1t5OYU-0004pv-4f
 for 74051@debbugs.gnu.org; Mon, 28 Oct 2024 08:09:08 -0400
Received: from smtp-ehess-auth.ehess.fr (smtp-ehess-auth.ehess.fr
 [193.48.45.113])
 by drosera.ehess.fr (Postfix) with ESMTP id 233B614000D;
 Mon, 28 Oct 2024 13:08:23 +0100 (CET)
Received: from [10.63.9.37] (unknown [10.63.9.37])
 by smtp-ehess-auth.ehess.fr (Postfix) with ESMTPSA id E0F04220088;
 Mon, 28 Oct 2024 13:08:22 +0100 (CET)
Message-ID: <055b8d2c-3507-48f9-a269-751492012f19@ehess.fr>
Date: Mon, 28 Oct 2024 13:08:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [bug#74051] [PATCH] gnu: Add emacs-weblorg
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <9eb86d322b0944948b166e17a48a3adf9c197996.1730054952.git.mattia.bunel@ehess.fr>
 <87seshkudj.fsf@nicolasgoaziou.fr>
Content-Language: en-US, fr-FR
From: Mattia Bunel <mattia.bunel@ehess.fr>
In-Reply-To: <87seshkudj.fsf@nicolasgoaziou.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 74051
Cc: 74051@debbugs.gnu.org, Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
 Liliana Marie Prikler <liliana.prikler@gmail.com>,
 Andrew Tropin <andrew@trop.in>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

Hello Nicolas,

Thanks for your review.

I've written a new patch based on your comments. What is the correct 
procedure for sending it? Should I send a patch based on *origin/master* 
or the previous patch you reviewed?

For documentation, the weblorg *doc/* folder contains the sources for 
the project website. My opinion is therefore not to include them.

Regards,

Le 28/10/2024 à 00:18, Nicolas Goaziou a écrit :
> Hello,
> 
> Mattia Bunel <mattia.bunel@ehess.fr> writes:
> 
>> Change-Id: Iae2d6cbbadec7a171e1e5b8502d4f47701d7af5b
> 
> Thank you for your patch. There are some (small) things to fix before it
> can be merged, tho.
> 
> First you need to write a proper commit message, such as:
> 
>    gnu: Add emacs-weblorg.
> 
>    * gnu/packages/emacs-xyz.scm (emacs-weblorg): New variable.
> 
>> +(define-public emacs-weblorg
>> +  (package
>> +    (name "emacs-weblorg")
>> +    (version "0.1.2")
> 
> The version is not actually "0.1.2", or rather, it seems we need to pick
> a commit after this tag. You should let-bind the commit hash, i.e.,
> "0db218bd6b2e083546d3a69a022dfb1a08900acd", to a `commit' symbol.
> Then, `version' field would become:
> 
>    (version (git-version "0.1.2" revision commit))
> 
> See, e.g., `emacs-taskrunner' package definition.
> 
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://stable.melpa.org/packages/" "weblorg-"
>> +                           version ".tar"))
> 
> Upstream is on GitHub, not on Stable MELPA. The package should use
> `git-fetch' method, and
> 
>    (uri (git-reference
>          (url "https://github.com/emacs-love/weblorg")
>          (commit commit)))
> 
> as the `uri' field.
> 
> Also, you need to add
> 
>    (file-name (git-file-name name version))
> 
> before the `sha256' field.
> 
>> +       (sha256
>> +        (base32 "0lvjfhysiyaz8klbj01da5jdjw1p4vvd9kl1zmi9vciazayh82ch"))))
>> +    (build-system emacs-build-system)
> 
> There are tests. You may want to run them, probably with
> 
>    (arguments
>     (list #:tests? #t
>           #:test-command '("emacs" "--batch"
>                            "-l" "t/weblorg-tests.el"
>                            "-f" "ert-run-tests-batch-and-exit")))
> 
> There seem to be some documentation in the "doc/" directory. What should
> be done about it?
> 
>> +    (propagated-inputs (list emacs-templatel))
>> +    (home-page "https://emacs.love/weblorg")
>> +    (synopsis "Static site generator for org-mode")
> 
> Nitpick: org-mode -> Org mode
> 
>> +    (description
>> +     "@code{emacs-weblorg} is a static site generator for org-mode,
>> +based on @code{templatel} library.")
> 
> Nitpick: @code{emacs-weblorg} -> Weblorg, org-mode -> Org mode. I also
> suggest to remove the reference about Templatel library in the
> description.
> 
> Could you send an updated patch? If you have any trouble doing so,
> please let us know.
> 
> Regards,

Send a report that this bug log contains spam.