Report forwarded
to andrew@trop.in, cox.katherine.e+guix@gmail.com, liliana.prikler@gmail.com, guix-patches@gnu.org: bug#74051; Package guix-patches.
(Sun, 27 Oct 2024 18:54:02 GMT) (full text, mbox, link).
Acknowledgement sent
to Mattia Bunel <mattia.bunel@ehess.fr>:
New bug report received and forwarded. Copy sent to andrew@trop.in, cox.katherine.e+guix@gmail.com, liliana.prikler@gmail.com, guix-patches@gnu.org.
(Sun, 27 Oct 2024 18:54:02 GMT) (full text, mbox, link).
Hello,
Mattia Bunel <mattia.bunel@ehess.fr> writes:
> Change-Id: Iae2d6cbbadec7a171e1e5b8502d4f47701d7af5b
Thank you for your patch. There are some (small) things to fix before it
can be merged, tho.
First you need to write a proper commit message, such as:
gnu: Add emacs-weblorg.
* gnu/packages/emacs-xyz.scm (emacs-weblorg): New variable.
> +(define-public emacs-weblorg
> + (package
> + (name "emacs-weblorg")
> + (version "0.1.2")
The version is not actually "0.1.2", or rather, it seems we need to pick
a commit after this tag. You should let-bind the commit hash, i.e.,
"0db218bd6b2e083546d3a69a022dfb1a08900acd", to a `commit' symbol.
Then, `version' field would become:
(version (git-version "0.1.2" revision commit))
See, e.g., `emacs-taskrunner' package definition.
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://stable.melpa.org/packages/" "weblorg-"
> + version ".tar"))
Upstream is on GitHub, not on Stable MELPA. The package should use
`git-fetch' method, and
(uri (git-reference
(url "https://github.com/emacs-love/weblorg")
(commit commit)))
as the `uri' field.
Also, you need to add
(file-name (git-file-name name version))
before the `sha256' field.
> + (sha256
> + (base32 "0lvjfhysiyaz8klbj01da5jdjw1p4vvd9kl1zmi9vciazayh82ch"))))
> + (build-system emacs-build-system)
There are tests. You may want to run them, probably with
(arguments
(list #:tests? #t
#:test-command '("emacs" "--batch"
"-l" "t/weblorg-tests.el"
"-f" "ert-run-tests-batch-and-exit")))
There seem to be some documentation in the "doc/" directory. What should
be done about it?
> + (propagated-inputs (list emacs-templatel))
> + (home-page "https://emacs.love/weblorg")
> + (synopsis "Static site generator for org-mode")
Nitpick: org-mode -> Org mode
> + (description
> + "@code{emacs-weblorg} is a static site generator for org-mode,
> +based on @code{templatel} library.")
Nitpick: @code{emacs-weblorg} -> Weblorg, org-mode -> Org mode. I also
suggest to remove the reference about Templatel library in the
description.
Could you send an updated patch? If you have any trouble doing so,
please let us know.
Regards,
--
Nicolas Goaziou
Information forwarded
to guix-patches@gnu.org: bug#74051; Package guix-patches.
(Mon, 28 Oct 2024 12:10:02 GMT) (full text, mbox, link).
Hello Nicolas,
Thanks for your review.
I've written a new patch based on your comments. What is the correct
procedure for sending it? Should I send a patch based on *origin/master*
or the previous patch you reviewed?
For documentation, the weblorg *doc/* folder contains the sources for
the project website. My opinion is therefore not to include them.
Regards,
Le 28/10/2024 à 00:18, Nicolas Goaziou a écrit :
> Hello,
>
> Mattia Bunel <mattia.bunel@ehess.fr> writes:
>
>> Change-Id: Iae2d6cbbadec7a171e1e5b8502d4f47701d7af5b
>
> Thank you for your patch. There are some (small) things to fix before it
> can be merged, tho.
>
> First you need to write a proper commit message, such as:
>
> gnu: Add emacs-weblorg.
>
> * gnu/packages/emacs-xyz.scm (emacs-weblorg): New variable.
>
>> +(define-public emacs-weblorg
>> + (package
>> + (name "emacs-weblorg")
>> + (version "0.1.2")
>
> The version is not actually "0.1.2", or rather, it seems we need to pick
> a commit after this tag. You should let-bind the commit hash, i.e.,
> "0db218bd6b2e083546d3a69a022dfb1a08900acd", to a `commit' symbol.
> Then, `version' field would become:
>
> (version (git-version "0.1.2" revision commit))
>
> See, e.g., `emacs-taskrunner' package definition.
>
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append "https://stable.melpa.org/packages/" "weblorg-"
>> + version ".tar"))
>
> Upstream is on GitHub, not on Stable MELPA. The package should use
> `git-fetch' method, and
>
> (uri (git-reference
> (url "https://github.com/emacs-love/weblorg")
> (commit commit)))
>
> as the `uri' field.
>
> Also, you need to add
>
> (file-name (git-file-name name version))
>
> before the `sha256' field.
>
>> + (sha256
>> + (base32 "0lvjfhysiyaz8klbj01da5jdjw1p4vvd9kl1zmi9vciazayh82ch"))))
>> + (build-system emacs-build-system)
>
> There are tests. You may want to run them, probably with
>
> (arguments
> (list #:tests? #t
> #:test-command '("emacs" "--batch"
> "-l" "t/weblorg-tests.el"
> "-f" "ert-run-tests-batch-and-exit")))
>
> There seem to be some documentation in the "doc/" directory. What should
> be done about it?
>
>> + (propagated-inputs (list emacs-templatel))
>> + (home-page "https://emacs.love/weblorg")
>> + (synopsis "Static site generator for org-mode")
>
> Nitpick: org-mode -> Org mode
>
>> + (description
>> + "@code{emacs-weblorg} is a static site generator for org-mode,
>> +based on @code{templatel} library.")
>
> Nitpick: @code{emacs-weblorg} -> Weblorg, org-mode -> Org mode. I also
> suggest to remove the reference about Templatel library in the
> description.
>
> Could you send an updated patch? If you have any trouble doing so,
> please let us know.
>
> Regards,
Information forwarded
to andrew@trop.in, cox.katherine.e+guix@gmail.com, liliana.prikler@gmail.com, guix-patches@gnu.org: bug#74051; Package guix-patches.
(Mon, 28 Oct 2024 15:45:02 GMT) (full text, mbox, link).
>ven. 29 nov. 2024 at 16:43, Mattia Bunel <mattia.bunel@ehess.fr> wrote:
> + (description "A static site generator particularly suitable for blogs,
> +written in Emacs Lisp and with support for templates and themes. It requires
> +no external dependencies.")
Sentences in description should be followed by two spaces.
You may check your code before submitting with:
./pre-inst-env guix lint emacs-weblorg
./pre-inst-env guix style emacs-weblorg
and your description here
https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
Thanks !
--
Cayetano Santos
Information forwarded
to mattia.bunel@ehess.fr, mail@nicolasgoaziou.fr, csantosb@inventati.org, andrew@trop.in, cox.katherine.e+guix@gmail.com, liliana.prikler@gmail.com, guix-patches@gnu.org: bug#74051; Package guix-patches.
(Sat, 30 Nov 2024 17:02:02 GMT) (full text, mbox, link).
Thanks for the patch, the reviews, and your reactivity in making
changes! I have slightly modified the description - it should consist of
full sentences - and pushed the commit.
Andreas
Debbugs is free software and licensed under the terms of the
GNU Public License version 2. The current version can be
obtained from https://bugs.debian.org/debbugs-source/.