#73948 - [PATCH 0/2] 'derivation-build-plan' returns builds in topological order

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #11 received at 73948@debbugs.gnu.org (full text, mbox, reply):

Received: (at 73948) by debbugs.gnu.org; 22 Oct 2024 13:25:14 +0000
From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 22 09:25:13 2024
Received: from localhost ([127.0.0.1]:55058 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1t3Esr-0002lY-CG
	for submit@debbugs.gnu.org; Tue, 22 Oct 2024 09:25:13 -0400
Received: from eggs.gnu.org ([209.51.188.92]:49050)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1t3Eso-0002j5-O1
 for 73948@debbugs.gnu.org; Tue, 22 Oct 2024 09:25:11 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1t3Eq7-0006wk-D0; Tue, 22 Oct 2024 09:22:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To:
 From; bh=pCDl98mnGMAPbVrqa9HnjDDOYIOCiv2XK7X32xIeC3k=; b=VKs/QVeEHBVKx/2VDZOF
 05EnDXL+xnWc+4ITGT1VyG38xOsCt/4YeA/S8T0x42Kxi+4UutDbG5Z+6QJUMUMfOWsTdO+6Wipwz
 hQ76l1hu18iwwaFR0CwzoNRfITLZjkkM1kjSFE7RXXGpu8LAkjmEo9oH8HMdjjrFR2jcDNoBAd70U
 QBzhMK2JfToQjZ8eh7k7Cs6X10t1jhNBij/eZEz19VdTZKQ6d+WVlH9EJnwPxKFG9EldudGa1JJss
 6F3Jz8+mxs2sYb4V63XRDpNPByTv571P+XIK/VdKQ5WTn9iGJxP/nSubK/7ITkyTiiEvWMJyN/QUn
 JE/pYx2f3N/+sw==;
From: Ludovic Courtès <ludo@gnu.org>
To: 73948@debbugs.gnu.org
Subject: [PATCH 2/2] ui: ‘show-what-to-build’ displays builds in topological order.
Date: Tue, 22 Oct 2024 15:22:10 +0200
Message-ID: <3ad164e7e8a4fe9469ef42e2ca4b5cfa77fffa82.1729603127.git.ludo@gnu.org>
X-Mailer: git-send-email 2.46.0
In-Reply-To: <cover.1729603127.git.ludo@gnu.org>
References: <cover.1729603127.git.ludo@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Debbugs-Cc: Christopher Baines <guix@cbaines.net>, Josselin Poiret <dev@jpoiret.xyz>, Ludovic CourtÃ¨s <ludo@gnu.org>, Mathieu Othacehe <othacehe@gnu.org>, Simon Tournier <zimon.toutoune@gmail.com>, Tobias Geerinckx-Rice <me@tobias.gr>
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 73948
Cc: Ludovic Courtès <ludo@gnu.org>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

That gives something like:

  $ ./pre-inst-env guix build vim --no-grafts --no-substitutes -n
  The following derivations would be built:
    /gnu/store/…-tcsh-6.24.01.tar.gz.drv
    /gnu/store/…-tcsh-6.24.01.tar.zst.drv
    /gnu/store/…-tcsh-6.24.01.drv
    /gnu/store/…-vim-9.1.0744-checkout.drv
    /gnu/store/…-vim-9.1.0744.drv

… with the derivation(s) being asked for coming last.

* guix/ui.scm (show-what-to-build): Reverse ‘build/full’ before folding it.

Change-Id: Ic0da9f4f8a58c7ed5e2d10f6ec2226f0865aed75
---
 guix/ui.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/ui.scm b/guix/ui.scm
index 966f0611f6..447550635c 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -1077,7 +1077,7 @@ (define* (show-what-to-build store drv
                                          #:hook ,hook
                                          #:build ,(cons file build))))))))
                               '(#:graft () #:hook () #:build ())
-                              build/full)
+                              (reverse! build/full)) ;preserve ordering
                    ((#:graft graft #:hook hook #:build build)
                     (values graft hook build)))))
     (define installed-size
-- 
2.46.0

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Wed Oct 23 01:31:33 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#73948 [PATCH 0/2] 'derivation-build-plan' returns builds in topological order