#66348 - [PATCH RFC] gnu: glibc: Fix CVE-2023-4911.

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #15 received at 66348@debbugs.gnu.org (full text, mbox, reply):

Received: (at 66348) by debbugs.gnu.org; 6 Oct 2023 22:24:48 +0000
From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 06 18:24:47 2023
Received: from localhost ([127.0.0.1]:52819 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1qotFX-00053d-Ir
	for submit@debbugs.gnu.org; Fri, 06 Oct 2023 18:24:47 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:41176)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1qotFV-00053P-4Q
 for 66348@debbugs.gnu.org; Fri, 06 Oct 2023 18:24:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1qotF6-0001XQ-Dv; Fri, 06 Oct 2023 18:24:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=8iHrV7a8AMe5OTGjOr4XCX1gxaKEv+IttUzkiHOxMU8=; b=fB9wIZZU61LWeFYFjZNT
 lO6RRzyqQ0IC1vlfT0SE69eNuDAKhbsCo5j/Jrl3yYTN1RC2WG9pejux6JbVzkoud+ZTmK0cNZVOd
 BOkLemn3cZT0igkxdcPH/Uuinm5IhONWXo2XcVZGrV2mNa4A7mkSzU9jN6pJCsEwwOj0Qm1iJO9ij
 YYLb46XuQKozohAXHz0qYNvwJzInQNftHXP1nlTvU/fzdh58hhhnxWliS/IZPW3O/NCSSMTFaeAaf
 8UUWfGK1YTY5uU0kGAGHGEFWvB+CsYzgk3CCaOp3VQWyKLsieBjSJBbYa7cZt/YMyQD1aljbtz++N
 9vXu66D8dobMAQ==;
From: Ludovic Courtès <ludo@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: Re: bug#66348: [PATCH RFC] gnu: glibc: Fix CVE-2023-4911.
In-Reply-To: <b4b918de4fce8ab839b51740f2758dc13f9884d5.1696450898.git.liliana.prikler@gmail.com>
 (Liliana Marie Prikler's message of "Wed, 4 Oct 2023 21:27:13 +0200")
References: <b4b918de4fce8ab839b51740f2758dc13f9884d5.1696450898.git.liliana.prikler@gmail.com>
Date: Sat, 07 Oct 2023 00:24:16 +0200
Message-ID: <87ttr3xucv.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 66348
Cc: 66348@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Liliana,

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> * gnu/packages/patches/glibc-2.35-CVE-2023-4911.patch: New file.
> * gnu/local.mk: Register it here.
> * gnu/packages/base.scm (glibc/fixed): New variable.
> (glibc): Use it as replacement.

I’ve tested it and it LGTM.

I found a bug where the grafted libreoffice ends up indirectly referring
to the broken libc in addition to the fixed one:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix build libreoffice
/gnu/store/1v6kgw1nrccc67yqlm1pzic1y32z63xb-libreoffice-7.5.4.2
$ guix gc -R /gnu/store/1v6kgw1nrccc67yqlm1pzic1y32z63xb-libreoffice-7.5.4.2|grep glibc-2.35
/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35
/gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35
$ ./pre-inst-env guix build libreoffice --no-grafts
/gnu/store/f5iibn55pm70icnk16hd4a8hwchicrvf-libreoffice-7.5.4.2
$ guix gc -R /gnu/store/f5iibn55pm70icnk16hd4a8hwchicrvf-libreoffice-7.5.4.2|grep glibc-2.35
/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35
$ guix graph -t references --path /gnu/store/1v6kgw1nrccc67yqlm1pzic1y32z63xb-libreoffice-7.5.4.2 /gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35
/gnu/store/1v6kgw1nrccc67yqlm1pzic1y32z63xb-libreoffice-7.5.4.2
/gnu/store/y392yldk4pbk4z5q587bz5n61hzbcf4g-mariadb-10.10.2-dev
/gnu/store/cilkyfnc5fxmpviyypci3d2881ik3nih-mariadb-10.10.2-lib
/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35
--8<---------------cut here---------------end--------------->8---

Not a showstopper but we’ll need to investigate.

Another concern: we’ll be grafting every single package.  It hurts
performance so we may want to “ungraft” in core-updates and get it
merged soon.

Thoughts?

Ludo’.

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 02:16:25 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#66348 [PATCH RFC] gnu: glibc: Fix CVE-2023-4911.