#65665 - package-mapping with #:deep? #t doesn't get all the implicit inputs

Package	Source(s)		Maintainer(s)
guix		PTS Buildd Popcon

Message #23 received at 65665@debbugs.gnu.org (full text, mbox, reply):

Received: (at 65665) by debbugs.gnu.org; 6 Oct 2023 02:37:29 +0000
From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 05 22:37:29 2023
Received: from localhost ([127.0.0.1]:48960 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1qoaiT-0005Qw-F5
	for submit@debbugs.gnu.org; Thu, 05 Oct 2023 22:37:29 -0400
Received: from mail-qv1-xf2c.google.com ([2607:f8b0:4864:20::f2c]:57824)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@gmail.com>) id 1qoaiD-0005QQ-3Q
 for 65665@debbugs.gnu.org; Thu, 05 Oct 2023 22:37:24 -0400
Received: by mail-qv1-xf2c.google.com with SMTP id
 6a1803df08f44-65b2463d651so9310756d6.3
 for <65665@debbugs.gnu.org>; Thu, 05 Oct 2023 19:36:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1696559805; x=1697164605; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=TcmSSFmeNVszjIhS4cSOCke81Z/gjBltYyBoGVF7qC8=;
 b=B8xaHrZIplA1SJbqQ2EliL7kD21voRjQeMezOkPtXeqIKfoL0AOCPvs+HicnuAi3H0
 b04Ljp7pqnO9rvRL+Q+xX7r8U2CHFUui0ZLyL/5g5TjTfc6lCSUu832yeGI4Z0v57bEt
 0vK5G5CbDJKs4ipl7SHsGNk7WxlFsqVRhWollWw22k+noAlFeCZ1BhQCd3P51wu/tyiA
 JpPE9Ncml0LQl2QfMdQqhWueTITiPqBUjU6lFRLd0DotUrQBlnr+VoIY7Nr4WOViq2uR
 BtnRMKktnk3i0G4xBvvVDR0D3M0R4ME5GIpgfXrlgcMYYcqe5tuOgJ1lAIH/cfMf8YkU
 HKIw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1696559805; x=1697164605;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=TcmSSFmeNVszjIhS4cSOCke81Z/gjBltYyBoGVF7qC8=;
 b=h52zNM9VuPQw/PA5SRg4J+ejByKSwdbdiJi5eYsxBLkms76zbU+l/hHuUooww6ZRZL
 3LItZ3QJUq5t3XElbYTRS4eTQgXSEFbi3edWdLpOgaPUK2NZ+FH9KxrbAUHYjRFAD7eq
 7y5w8QCjckn8kNyAZo9FsqEW1QgU81vpCDMwvmz3FOdafoYu5C1+yXAVzF6qaqH1diDu
 RkbaNkEMTy4ca/0adH+FJKT3aBYoFzROeQbUjUEfV26txVBgvXHbjxWy+fPfd3M3TBE7
 Y7uPIVO6tgy86XLl/2wOmxIzaNmUhy7prBUwoayHNBFxjidOIQBQ5pv+dw95wcxjs62a
 Y5DA==
X-Gm-Message-State: AOJu0YxC8h+KhaTHqF/5kUtxyR3WWJQvOznZ5FM2Xde4ohMYqIS0uUMK
 eQ0rMCKfaavmVJE4vQvQhhI=
X-Google-Smtp-Source: AGHT+IGRLPb93X97yA/u3VA1nEx//9V4A6c3VCbHvSdl9H8K5Xlg9xpNEjGYRy9R1z/QK+uotDAw0w==
X-Received: by 2002:a0c:f647:0:b0:658:9896:91b2 with SMTP id
 s7-20020a0cf647000000b00658989691b2mr6740831qvm.7.1696559804920; 
 Thu, 05 Oct 2023 19:36:44 -0700 (PDT)
Received: from hurd (dsl-151-116.b2b2c.ca. [66.158.151.116])
 by smtp.gmail.com with ESMTPSA id
 t10-20020a0ca68a000000b0065afcf19e23sm994377qva.62.2023.10.05.19.36.43
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 05 Oct 2023 19:36:44 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Ulf Herrman <striness@tilde.club>
Subject: Re: bug#65665: [PATCH] Really get all the implicit inputs.
In-Reply-To: <87msxmqwng.fsf@tilde.club> (Ulf Herrman's message of "Sat, 16
 Sep 2023 04:45:23 -0500")
References: <87h6ofufy5.fsf@tilde.club> <87msxmqwng.fsf@tilde.club>
Date: Thu, 05 Oct 2023 22:36:42 -0400
Message-ID: <87a5swlbnp.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 65665
Cc: dev@jpoiret.xyz, zimon.toutoune@gmail.com, othacehe@gnu.org, ludo@gnu.org,
 me@tobias.gr, 65665@debbugs.gnu.org, rekado@elephly.net, guix@cbaines.net
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello Ulf!

Ulf Herrman <striness@tilde.club> writes:

> This patch series causes package-mapping to recurse into package and bag
> arguments when #:deep? #t is given.  It also recurses into gexps and
> gexp inputs in search of packages to devour.  It also ensures that build
> systems leave all of their implicit package arguments in the bag
> arguments, ready to be found by package-mapping.  It also fixes a couple
> build system errors I came across while modifying 40+ build systems and
> testing a deep package transformation.

Nice series!

I've reviewed it, and it makes sense to me.  I'd like to apply it to the
core-updates branch.  Core team, what say you?

-- 
Thanks,
Maxim

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Wed Sep 10 04:41:15 2025; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#65665 package-mapping with #:deep? #t doesn't get all the implicit inputs