#62678 - [PATCH] services: nginx: Harden php-location settings.

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #11 received at 62678@debbugs.gnu.org (full text, mbox, reply):

Received: (at 62678) by debbugs.gnu.org; 6 Apr 2023 13:11:50 +0000
From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 06 09:11:50 2023
Received: from localhost ([127.0.0.1]:53652 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1pkPP4-0001J4-A3
	for submit@debbugs.gnu.org; Thu, 06 Apr 2023 09:11:50 -0400
Received: from smtpmciv3.myservices.hosting ([185.26.107.239]:39824)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mirai@makinata.eu>) id 1pkPP1-0001It-Pp
 for 62678@debbugs.gnu.org; Thu, 06 Apr 2023 09:11:49 -0400
Received: from mail1.netim.hosting (unknown [185.26.106.173])
 by smtpmciv3.myservices.hosting (Postfix) with ESMTP id 44874202E2;
 Thu,  6 Apr 2023 15:11:46 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by mail1.netim.hosting (Postfix) with ESMTP id F3AB8800A8;
 Thu,  6 Apr 2023 15:11:45 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting
Received: from mail1.netim.hosting ([127.0.0.1])
 by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id Tr-Y3DHWWlGZ; Thu,  6 Apr 2023 15:11:45 +0200 (CEST)
Received: from [192.168.1.239] (unknown [10.192.1.83])
 (Authenticated sender: lumen@makinata.eu)
 by mail1.netim.hosting (Postfix) with ESMTPSA id C1B13800A7;
 Thu,  6 Apr 2023 15:11:43 +0200 (CEST)
Message-ID: <65a26f2b-0ef5-b9ac-b4df-4e3b73ad4474@makinata.eu>
Date: Thu, 6 Apr 2023 14:11:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [bug#62678] [PATCH] services: nginx: Harden php-location settings.
Content-Language: en-US
To: Jonathan Brielmaier <jonathan.brielmaier@web.de>
References: <ad598ba1ce644a29c997139c82d790a3ac65f4b4.1680708757.git.mirai@makinata.eu>
 <068a52bd-8597-a449-c452-4c110f645ca0@web.de>
From: Bruno Victal <mirai@makinata.eu>
In-Reply-To: <068a52bd-8597-a449-c452-4c110f645ca0@web.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: 62678
Cc: 62678@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

Hi Jonathan,

On 2023-04-05 21:19, Jonathan Brielmaier wrote:
> I wonder if we should at least make the HTTP_PROXY variable
> configurable. It may need to be set to something else then "" in some
> scenarios. I don't know...

No, there's no legitimate reason for this, since 'PROXY' is not
a standard HTTP header according to [1]. PROXY being passed to a cgi application
as HTTP_PROXY is what the exploit is about, since HTTP_PROXY is recognized as
a variable for configuring proxies (for curl, wget, etc.)
Allowing HTTP_PROXY to be set remotely (due to a confusion with the non-standard 'PROXY' header)
is simply incomprehensible.

Regarding user intent, that is, configuring the proxy used by the cgi application by
setting HTTP_PROXY via nginx?
I don't have this use-case but IMO it feels like an extreme poor design, since it's
exploiting a name confusion to change the system environment variables for the
cgi application.

If for some reason you really need this, you can always use the regular
nginx-location-configuration to manually craft a php-location.

[1]: https://www.iana.org/assignments/http-fields/http-fields.xhtml

Cheers,
Bruno

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 01:08:28 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#62678 [PATCH] services: nginx: Harden php-location settings.