#60868 - [PATCH] build: pyproject-build-system: Use wrap-script instead of wrap-program.

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #16 received at 60868@debbugs.gnu.org (full text, mbox, reply):

Received: (at 60868) by debbugs.gnu.org; 24 Jan 2023 08:42:48 +0000
From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 03:42:47 2023
Received: from localhost ([127.0.0.1]:55799 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1pKEtD-000384-Ih
	for submit@debbugs.gnu.org; Tue, 24 Jan 2023 03:42:47 -0500
Received: from eggs.gnu.org ([209.51.188.92]:49472)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1pKEtB-00037q-Mx
 for 60868@debbugs.gnu.org; Tue, 24 Jan 2023 03:42:46 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1pKEt5-0000zm-3Y; Tue, 24 Jan 2023 03:42:39 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=voNNKU9pvGEPrve70udyKrrQ8U3DEYFd7i0GmBnxebk=; b=AzxrCXc81N/0iXTaIGa2
 ImS2NDe7R3RDpkqgxTzoOvnytTHDfvG8fHkHDSp0BKz8dE18FeKxLzGSSJelE95sZAUNlOTnVyST/
 aUPZwqU6UzygvDQ6rNgR8o8QcVNdArEf+CH3ej7YhTYQkON0sBVo5e9f+u8RIS7jLW8MGdiQo2q7P
 s2i+crcRkDAVUriCUUkfhCW3ZSRIjZTg7ctaJLkYCcstxnja3W6+YnT9Ok7iJ8LuJ2048hh30QVZ0
 GuBBPnFUPUk5coEGCjJhxR/eB0O9vBL5yBEd871hTgpwmZg4b6GEuzMxzerq5sY56am+HBHJmjcs+
 T1TpePItT4LBWA==;
Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1pKEt4-0008F1-K0; Tue, 24 Jan 2023 03:42:38 -0500
From: Ludovic Courtès <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: Re: [PATCH v2] build: pyproject-build-system: Use wrap-script
 instead of wrap-program.
References: <20230123133354.1345-1-maxim.cournoyer@gmail.com>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: Quintidi 5 Pluviôse an 231 de la
 Révolution, jour du Taureau
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Tue, 24 Jan 2023 09:42:35 +0100
In-Reply-To: <20230123133354.1345-1-maxim.cournoyer@gmail.com> (Maxim
 Cournoyer's message of "Mon, 23 Jan 2023 08:33:54 -0500")
Message-ID: <87y1pswcg4.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60868
Cc: jgart <jgart@dismail.de>, 60868@debbugs.gnu.org,
 Lars-Dominik Braun <lars@6xq.net>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hello!

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> * guix/build-system/pyproject.scm (default-guile): New procedure.
> (lower) Add guile to the host-inputs of the bag.
> * guix/build/pyproject-build-system.scm (wrap): Replace wrap-program with
> wrap-script.  Rename bash-related nested variables/procedure with
> guile-related ones.

I had overlooked this patch before, sorry about that.

> +    (host-inputs (modify-inputs inputs
> +                   (append (default-guile))))

Maybe add a comment stating it’s for ‘wrap-script’.

> +  (define bindirs
> +    (append-map (match-lambda
> +                  ((_ . dir)
> +                   (list (string-append dir "/bin")
> +                         (string-append dir "/sbin"))))
> +                outputs))

Should it include “libexec”?

> +  ;; Do not require "guile" to be present in the package inputs
> +  ;; even when there is nothing to wrap.
> +  ;; Also, calculate (guile) only once to prevent some I/O.
> +  (define %guile (delay (search-input-file inputs "bin/guile")))
> +  (define (guile) (force %guile))

Aaah, got it.  :-)

LGTM, thanks!

Ludo’.

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Mon Dec 23 06:57:44 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#60868 [PATCH] build: pyproject-build-system: Use wrap-script instead of wrap-program.