#60847 - [PATCH] Enable cross-compilation for the pyproject-build-system.

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #65 received at 60847@debbugs.gnu.org (full text, mbox, reply):

Received: (at 60847) by debbugs.gnu.org; 12 Mar 2023 04:05:40 +0000
From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 11 23:05:40 2023
Received: from localhost ([127.0.0.1]:58902 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1pbCxn-0001xk-Rd
	for submit@debbugs.gnu.org; Sat, 11 Mar 2023 23:05:40 -0500
Received: from mail-qt1-f181.google.com ([209.85.160.181]:39587)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@gmail.com>) id 1pbCxl-0001xX-FA
 for 60847@debbugs.gnu.org; Sat, 11 Mar 2023 23:05:38 -0500
Received: by mail-qt1-f181.google.com with SMTP id w23so10083618qtn.6
 for <60847@debbugs.gnu.org>; Sat, 11 Mar 2023 20:05:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20210112; t=1678593932;
 h=content-transfer-encoding:mime-version:message-id:date:user-agent
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=wapCJ+4WPMr3+oPYy9bGOlrHJkyHEl2M5LQvhGbBI5o=;
 b=LAfLjLO2Utr4NfGOGQOic6i0cUhVW8ZhJk9IGUznCVMBlYGAT6X0qPdJ7jm4yYad1R
 96lwS8aJoxU7RbWm4LWTg6UiZipSMh5iNra1Hmh7+xh3CCwpFDvGg4fq0IGfVUSqHdGn
 ku8O8X8j7dwCrgkA8G5OtBu3I9qXTeX8CbAA88yPOY6zz9zbGgQxu5dSG+QcfOJOSoyW
 rAuDw++D5PYYMuumjMOLtvwAZj2vzd3VKFxhM9ysPdN4vBCqc/qOIWC8GuOZ/mMwXXwp
 apwqOsVpjqSAEjugp7nBpS4/6ekj6Iv/eFQUaS8ycQbKvVqxCKawalA/lt/qGRsy6ErH
 7HIg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112; t=1678593932;
 h=content-transfer-encoding:mime-version:message-id:date:user-agent
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=wapCJ+4WPMr3+oPYy9bGOlrHJkyHEl2M5LQvhGbBI5o=;
 b=bEFpMw1/kGlLCR8uBq8BeTZPMQDSghS7EeSSO8nyZjJWrCwA6szy7Bvg+g40DsJHji
 JdN71NFq5OYeekg7Uc4CNLXpN4RWE65g4O+aKeQC548LPTZSdgPXqIJ40UK5WiDRoe6v
 06g1AFHLuV6Aw1EKygXk7I93tOKZWuNn706QoUduSuxPnFWtEnXkFh/vDA18PKxCSLXp
 IFr4QjVfSPSD5qodK8i3RIJjuNw/cWTfaQC2CcAvHDZsRnzEkMLXgFAHFRaYSxL4bzP2
 FO0o/azi6eXKGsuHn5d2/F4C7sjLrcS3yz8fw7o8FTJbcWgiYOHw5SH2UWv6hhKadJgt
 MCiA==
X-Gm-Message-State: AO0yUKW96ISdaBh0o1eOefK2w3gXGHJs+dH04RpHK+kDkppXVjEMmcpl
 6y8uDPeDGo6PonAkzvTbMlA=
X-Google-Smtp-Source: AK7set/+lFx7S9Xfct1ZAxEPH3PawBZ21peIvCtE82GMHp47ITVQYHAl1SLr3t6GKJBrnfiHzsGUKQ==
X-Received: by 2002:ac8:7d86:0:b0:3bf:d993:f3aa with SMTP id
 c6-20020ac87d86000000b003bfd993f3aamr16773360qtd.35.1678593932041; 
 Sat, 11 Mar 2023 20:05:32 -0800 (PST)
Received: from hurd ([2607:fad8:4:3::1000]) by smtp.gmail.com with ESMTPSA id
 g11-20020ac8580b000000b003b86b99690fsm3012957qtg.62.2023.03.11.20.05.31
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 11 Mar 2023 20:05:31 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Ludovic Courtès <ludo@gnu.org>
Subject: Re: bug#60847: [PATCH] Enable cross-compilation for the
 pyproject-build-system.
In-Reply-To: <87a60kh77y.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 10 Mar 2023 18:00:33 +0100")
References: <20230123133217.318-1-maxim.cournoyer@gmail.com>
 <20230123133217.318-2-maxim.cournoyer@gmail.com>
 <87zg8p7qvw.fsf_-_@gnu.org> <87jzzsy7qt.fsf@gmail.com>
 <87o7p19e6w.fsf@gnu.org> <87v8j8r8jt.fsf@gmail.com>
 <87a60kh77y.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Date: Sat, 11 Mar 2023 23:05:30 -0500
Message-ID: <87o7oypqb9.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 60847
Cc: Josselin Poiret <dev@jpoiret.xyz>, Christopher Baines <mail@cbaines.net>,
 Simon Tournier <zimon.toutoune@gmail.com>, Mathieu Othacehe <othacehe@gnu.org>,
 60847@debbugs.gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>,
 Lars-Dominik Braun <lars@6xq.net>, Ricardo Wurmus <rekado@elephly.net>,
 jgart <jgart@dismail.de>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
> [...]
>
>>>>>> +  (let ((builder-name (procedure-name (bag-build bag))))
>>>>>> +    (if (or (bag-target bag)
>>>>>> +            (eq? 'pyproject-build builder-name))
>>>>>> +        (bag->cross-derivation bag)
>>>>>
>>>>> This one part is a showstopper to me, for two reasons:
>>>>>
>>>>>   1. We cannot rely on ‘procedure-name’ (it’s a debugging aid and it’s
>>>>>      not guaranteed to return something useful).
>>>>>
>>>>>   2. Special-casing build systems here is not okay: the bag and build
>>>>>      system abstractions exist to maintain separation of concerns.
>>>>>
>>>>> I understand there’s an actual bug to fix and the desire to fix a more
>>>>> common issue, but I think this one approach is not the way forward.
>>>>>
>>>>> I hope that makes sense!
>>>>
>>>> I agree this is not "pretty", but it would be a "temporary" kludge until
>>>
>>> To make sure there’s no misunderstanding, I think that’s not okay even
>>> as a “temporary kludge” (I’m not against temporary kludges in general,
>>> I’ve done my share of that ;-), but this would be way too brittle.)
>>
>> "way too brittle" is a strong warning :-).
>
> It is; I’m objecting to this change.

OK.

>> I don't understand what is
>> so brittle about it?  It's not like we change the build system names
>> often.
>
> I have little to add to what I wrote above: procedure names don’t mean
> anything, especially with higher-order functions, and separation of
> concerns is an important design principle.
>
> I’m speaking with 15+ years of experience with Guile; I don’t mind being
> challenged, it’s healthy, but I think we also need to recognize the
> expertise of each other and encounter each other halfway.

When I don't understand something, I ask for an explanation.  I'm happy
(and greatly value) that my correspondent has 15 years of experience
with Guile, but I'll still ask if something is unclear.  I hope you
don't mind.

> [...]
>
>>> Perhaps one suggestion would be: start the native-inputs/inputs change
>>> on a new branch, for all the build systems (or at least the main
>>> ones), and then try to build the ‘core’ subset (which includes
>>> cross-compilation) to get an idea of the kind of code simplification
>>> opportunities as well as issues that arise.  I feel like it’s hard to
>>> anticipate the impact of such a change without actually trying.
>>
>> I can do this; the exercise would be similar to what I've done for
>> pyproject-build-system, where I was able to build complex packages (both
>> natively and cross-compiled) with the new same-bag representation
>> change, but to a larger scale.  It's more work, which is why I would
>> have preferred to contain its scope to get started, but the changes were
>> easy, IIRC.
>
> Yes, I agree it’s more work, but it’s dissimilar in that you’ll be
> confronted with tons of weird cases, some of which we can already
> anticipate, but probably others we’ll probably be surprised to discover.

OK.  I'll put this to the test, when I'm done with the current Ruby
rabbit-hole I've been pursuing.  Thanks for the feedback!

-- 
Thanks,
Maxim

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 20:58:41 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#60847 [PATCH] Enable cross-compilation for the pyproject-build-system.