#60847 - [PATCH] Enable cross-compilation for the pyproject-build-system.

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #38 received at 60847@debbugs.gnu.org (full text, mbox, reply):

Received: (at 60847) by debbugs.gnu.org; 7 Mar 2023 14:08:23 +0000
From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 07 09:08:23 2023
Received: from localhost ([127.0.0.1]:44901 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1pZXzK-0004VK-P7
	for submit@debbugs.gnu.org; Tue, 07 Mar 2023 09:08:23 -0500
Received: from mail-qt1-f172.google.com ([209.85.160.172]:44973)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@gmail.com>) id 1pZXzJ-0004V6-9r
 for 60847@debbugs.gnu.org; Tue, 07 Mar 2023 09:08:21 -0500
Received: by mail-qt1-f172.google.com with SMTP id s12so14313710qtq.11
 for <60847@debbugs.gnu.org>; Tue, 07 Mar 2023 06:08:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20210112; t=1678198095;
 h=content-transfer-encoding:mime-version:user-agent:message-id
 :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=F7B1Vu/MnzcDjQpiyXJQB4JJniF+y8JePazYuuINU1g=;
 b=Afdmwo2tVqEpqfJ+RQL8bwD6DNc6KKUshFNCo9ny8fRBRyFu8f+Bei609iZ4XJRAEs
 DG4BCBUBlyy6HHgUnDZg/rs2LrLIPFyCqWC60dln8iYNGNi/vH6JA0ByuB6OL2E4mILd
 6XjsV/s8tMnvLPZDwHlnvaBf4P3PQ7VkM4bMHa+8YlnoXrbz98C2IV6eBSPdEfAZq+C4
 6roD+J4iF6yEcFC1IYzXzb8NtQU7YiFFqwluSUJKPIQ379cSZFKLUEVTNpZEDJp/teFj
 it33pLOjlwtI+uLijdLwws15VIie/kEqckj5rYaxFpFlQKHRVQpIno92KNG4yvg9aSz8
 Hkyg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112; t=1678198095;
 h=content-transfer-encoding:mime-version:user-agent:message-id
 :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=F7B1Vu/MnzcDjQpiyXJQB4JJniF+y8JePazYuuINU1g=;
 b=zTyQp4yRAqWv09UeHxcGm/9tzQtDrtaoSM1XUz1eAW4IAzkHFQGSLAeR0UazcRW01I
 b608UcIMWVgFdis+LGP2tIz4TrmXnCEJCvpM0exL34d85IhcRQ0lR9PHEcHlT2pSvTt1
 p/UsY8zfhvubbWyX51XnA1vwN2eE1fxD9icMwa79d+ibK1QpJlSpATAGNL80oN3ASZeL
 55W+N9upUStF7FSWIfUUSGvWviM+EnUGT4hf28hS1wuYY8HIz5LCyh0idur1K5z4afPF
 wb+NagqQ2f2jEPgGSbjWHigje0qS74Br04sLg8SAXS1YSQZ0ew9CTy0T8WWQdR6knScP
 sHMw==
X-Gm-Message-State: AO0yUKXf7/u9djpYwId2svs7VyM1RmnnAacIiRD1aFv4LKrBaocB9kaT
 F3mlGR3tkT9y0PJVz6mJj7E=
X-Google-Smtp-Source: AK7set/p+GvNL5TWiKfm5tIgo1DBUkP/1ztL6yKOjfByHapa6qcUbhUXij4004ohWrGyexC3P/xnOg==
X-Received: by 2002:a05:622a:1650:b0:3bf:c5a3:6143 with SMTP id
 y16-20020a05622a165000b003bfc5a36143mr25255342qtj.27.1678198095631; 
 Tue, 07 Mar 2023 06:08:15 -0800 (PST)
Received: from hurd ([2607:fad8:4:3::1000]) by smtp.gmail.com with ESMTPSA id
 p23-20020a05620a057700b0071f0d0aaef7sm9397235qkp.80.2023.03.07.06.08.14
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 07 Mar 2023 06:08:14 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Ludovic Courtès <ludo@gnu.org>
Subject: Re: bug#60847: [PATCH] Enable cross-compilation for the
 pyproject-build-system.
References: <20230123133217.318-1-maxim.cournoyer@gmail.com>
 <20230123133217.318-2-maxim.cournoyer@gmail.com>
 <87zg8p7qvw.fsf_-_@gnu.org>
Date: Tue, 07 Mar 2023 09:08:10 -0500
In-Reply-To: <87zg8p7qvw.fsf_-_@gnu.org> ("Ludovic Courtès"'s message of "Mon, 06 Mar 2023 18:04:35 +0100")
Message-ID: <87jzzsy7qt.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 60847
Cc: Josselin Poiret <dev@jpoiret.xyz>, Christopher Baines <mail@cbaines.net>,
 Simon Tournier <zimon.toutoune@gmail.com>, Mathieu Othacehe <othacehe@gnu.org>,
 60847@debbugs.gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>,
 Lars-Dominik Braun <lars@6xq.net>, Ricardo Wurmus <rekado@elephly.net>,
 jgart <jgart@dismail.de>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Ludo!

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> +++ b/guix/packages.scm
>> @@ -1864,28 +1864,30 @@ (define* (bag->derivation bag #:optional context)
>
> […]
>
>> +  (let ((builder-name (procedure-name (bag-build bag))))
>> +    (if (or (bag-target bag)
>> +            (eq? 'pyproject-build builder-name))
>> +        (bag->cross-derivation bag)
>
> This one part is a showstopper to me, for two reasons:
>
>   1. We cannot rely on ‘procedure-name’ (it’s a debugging aid and it’s
>      not guaranteed to return something useful).
>
>   2. Special-casing build systems here is not okay: the bag and build
>      system abstractions exist to maintain separation of concerns.
>
> I understand there’s an actual bug to fix and the desire to fix a more
> common issue, but I think this one approach is not the way forward.
>
> I hope that makes sense!

I agree this is not "pretty", but it would be a "temporary" kludge until
all the build systems can be migrated (and the package adjusted for) the
"new" way, which is: native-inputs and inputs always co-exist, whether
the build is a native one or a cross one.

In light of this, it seems OK to test the water with a not so
significant build system (only a handful of package relies on
pyproject-build-system thus far).  When all the build systems will have
been migrated to the new way (a too big undertaking to be done in one
shot), this kludge can be removed.

Otherwise, could you offer a concrete suggestion as the way forward?  I
appreciate the "that's not the way", but stopping short of suggesting a
better alternative leaves me wanting more :-).

-- 
Thanks,
Maxim

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 20:11:04 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#60847 [PATCH] Enable cross-compilation for the pyproject-build-system.