#60847 - [PATCH] Enable cross-compilation for the pyproject-build-system.

Package	Source(s)		Maintainer(s)
guix-patches		PTS Buildd Popcon

Message #29 received at 60847@debbugs.gnu.org (full text, mbox, reply):

Received: (at 60847) by debbugs.gnu.org; 6 Mar 2023 17:04:50 +0000
From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 06 12:04:50 2023
Received: from localhost ([127.0.0.1]:43515 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1pZEGX-0006Bd-Ox
	for submit@debbugs.gnu.org; Mon, 06 Mar 2023 12:04:49 -0500
Received: from eggs.gnu.org ([209.51.188.92]:53108)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1pZEGW-0006BR-JS
 for 60847@debbugs.gnu.org; Mon, 06 Mar 2023 12:04:49 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1pZEGQ-0002cG-PW; Mon, 06 Mar 2023 12:04:42 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=4HyrjNlKU/X046YF+Kbdn7btcX1CPUo0/R9EZoZuGGA=; b=H14vT1+dWkU7t3j8zzdO
 Scy5yjT1cSdjdmU1hL9nPJTd6w9mdfpN4jCZU1zoQ0x9hEc/xPNUFmTdh+Jtd667LRCNG/d3c/Mcr
 F2wt+741xsoO1y1naYRlsd2ioHrzgRZhIlFVjeqN3Z3zmBMeXWOyJL+P7IlJEOR5hubW08WJtKmyq
 oCq0cLkgtKCu7bdqhQsu0P3/cx3WOLo0jwCB4kZ7a9uLLe2BLtDMu9p9l2fVChUj4YHCXy32PqfNc
 MpBaNhBxXHbJZ4J2E8giYhFPRGc7uSXXQ7zW1Ym2dw8hDruBJY+RBsSI22tCzuwaYbBCcXnYs0wNh
 jWsDJXsAuBDWyQ==;
Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1pZEGN-0005Ou-FI; Mon, 06 Mar 2023 12:04:40 -0500
From: Ludovic Courtès <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: Re: bug#60847: [PATCH] Enable cross-compilation for the
 pyproject-build-system.
References: <20230123133217.318-1-maxim.cournoyer@gmail.com>
 <20230123133217.318-2-maxim.cournoyer@gmail.com>
Date: Mon, 06 Mar 2023 18:04:35 +0100
In-Reply-To: <20230123133217.318-2-maxim.cournoyer@gmail.com> (Maxim
 Cournoyer's message of "Mon, 23 Jan 2023 08:32:16 -0500")
Message-ID: <87zg8p7qvw.fsf_-_@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 60847
Cc: Josselin Poiret <dev@jpoiret.xyz>, Christopher Baines <mail@cbaines.net>,
 Simon Tournier <zimon.toutoune@gmail.com>, Mathieu Othacehe <othacehe@gnu.org>,
 60847@debbugs.gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>,
 Lars-Dominik Braun <lars@6xq.net>, Ricardo Wurmus <rekado@elephly.net>,
 jgart <jgart@dismail.de>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> +++ b/guix/packages.scm
> @@ -1864,28 +1864,30 @@ (define* (bag->derivation bag #:optional context)

[…]

> +  (let ((builder-name (procedure-name (bag-build bag))))
> +    (if (or (bag-target bag)
> +            (eq? 'pyproject-build builder-name))
> +        (bag->cross-derivation bag)

This one part is a showstopper to me, for two reasons:

  1. We cannot rely on ‘procedure-name’ (it’s a debugging aid and it’s
     not guaranteed to return something useful).

  2. Special-casing build systems here is not okay: the bag and build
     system abstractions exist to maintain separation of concerns.

I understand there’s an actual bug to fix and the desire to fix a more
common issue, but I think this one approach is not the way forward.

I hope that makes sense!

Ludo’.

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 20:23:19 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#60847 [PATCH] Enable cross-compilation for the pyproject-build-system.