#56014 'guix substitute' crashes in zstd on transient networking issues

Message #8 received at 56014@debbugs.gnu.org (full text, mbox, reply):

Received: (at 56014) by debbugs.gnu.org; 26 Jun 2022 15:28:47 +0000
From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 26 11:28:47 2022
Received: from localhost ([127.0.0.1]:48713 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1o5UBr-0005Ay-91
	for submit@debbugs.gnu.org; Sun, 26 Jun 2022 11:28:47 -0400
Received: from eggs.gnu.org ([209.51.188.92]:34164)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1o5UBo-0005Aj-VO
 for 56014@debbugs.gnu.org; Sun, 26 Jun 2022 11:28:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:50046)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1o5UBj-0008Go-96; Sun, 26 Jun 2022 11:28:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=VGxSCAjsYGFJIFOkOUVpCKj6oehnr6gxiMC7ZRz3qJI=; b=WOWCTcBosquXiERqEoik
 Wk41O6aEzqBhY+TEM27iJ0V+UOzievMrkeU6NP2SjQmNN4v0+5/E99v04BdrJFAHYKOcuW83pTHk+
 7atYvLwl23QAbiJXy//AQLN4GhjNzBduF7peW6SXM3bNN17msAdfiMVSMpsSUkSMjZJ63dcJir7nJ
 SqVyDg3wYen0Mxnm2mr4zUgWyH2f5G+ciu5QiQB0VQhf4mih2UKtW4j7f3McZ0iBfcUWM2vBpwxlQ
 RI+PSlpT5j6ypTKzRbFxKWea9aVj3S6lTrgpsxU1PiaqsMGxzkQvtXUtYCuzv4fYkoZ0X4rx6HCeH
 UuSEdhJTJEp0bg==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:57354
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1o5UBi-0008L7-QC; Sun, 26 Jun 2022 11:28:39 -0400
From: Ludovic Courtès <ludo@gnu.org>
To: Matthias <matthias.kaak@smartflyer.de>
Subject: Re: bug#56014: Guix crashes at while downloading an update
References: <92fd6760-bbdc-b2d3-5364-4b69a7ae3e4d@smartflyer.de>
Date: Sun, 26 Jun 2022 17:28:36 +0200
In-Reply-To: <92fd6760-bbdc-b2d3-5364-4b69a7ae3e4d@smartflyer.de> (Matthias's
 message of "Thu, 16 Jun 2022 04:09:52 +0000")
Message-ID: <8735frsau3.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 56014
Cc: 56014@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Matthias,

Matthias <matthias.kaak@smartflyer.de> skribis:

> I just downloaded the QEMU image for the Guix distribution and wanted
> to try it out.  I use QEMU and AQEMU from the current Debian Testing.
>
> To try out the package manager I installed the Lynx terminal
> browser. That worked without any problems (lynx is working), but guix
> said I should update the system with the commands "guix pull" and
> "guix package -u".  Excited to be able to explore more features I
> typed in the first command, but while downloading the package "apr" it
> crashed.  See the attachment for guix' output.
>
> Guix version ("guix --version"): 1.3.0-1.771b866

[...]

>  xz-5.2.5  308KiB                                                                 568.9MiB/s 00:00 [##################] 100.0%
>  glib-2.70.2  2.7MiB                                                               4.68GiB/s 00:00 [##################] 100.0%
>  apr-1.7.0  314KiB                                                                581.4MiB/s 00:00 [#######           ]  40.7%Backtrace:
> In guix/serialization.scm:
>    468:33 19 (read "/gnu/store/rbb9h501zyf8mg1hz47plql80gsl99za-apr?" ?)
>    468:33 18 (read "/gnu/store/rbb9h501zyf8mg1hz47plql80gsl99za-apr?" ?)
>    442:24 17 (read "/gnu/store/rbb9h501zyf8mg1hz47plql80gsl99za-apr?" ?)
>    525:24 16 (_ "/gnu/store/rbb9h501zyf8mg1hz47plql80gsl99za-apr-1.?" ?)
> In guix/store/deduplication.scm:
>     227:2 15 (dump-file/deduplicate "/gnu/store/rbb9h501zyf8mg1hz47?" ?)
> In ice-9/ports.scm:
>    463:17 14 (call-with-output-file _ _ #:binary _ #:encoding _)
> In guix/store/deduplication.scm:
>    232:10 13 (_ _)
> In guix/serialization.scm:
>     261:6 12 (dump _)
>    247:20 11 (dump #<input: string 7fd40c2b5af0> #<output: string 7?> ?)
> In unknown file:
>           10 (get-bytevector-n! #<input: string 7fd40c2b5af0> # 0 #)
> In guix/store/deduplication.scm:
>    203:22  9 (read! #vu8(47 42 32 76 105 99 101 110 115 101 100 32 ?) ?)
> In unknown file:
>            8 (get-bytevector-n! #<input: string 7fd409cdcd20> # 0 #)
> In gcrypt/hash.scm:
>    223:13  7 (read! #vu8(47 42 32 76 105 99 101 110 115 101 100 32 ?) ?)
> In unknown file:
>            6 (get-bytevector-n! #<input: string 7fd409cdce70> # 0 #)
> In zstd.scm:
>    256:12  5 (read! _ _ _)
> In ice-9/boot-9.scm:
>   1669:16  4 (raise-exception _ #:continuable? _)
>   1669:16  3 (raise-exception _ #:continuable? _)
>   1764:13  2 (_ #<&compound-exception components: (#<&error> #<&irri?>)
>   1669:16  1 (raise-exception _ #:continuable? _)
>   1669:16  0 (raise-exception _ #:continuable? _)
>
> ice-9/boot-9.scm:1669:16: In procedure raise-exception:
> Throw to key `zstd-error' with args `(decompress! 18446744073709551544)'.

This is the root cause; its meaning:

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> ,use(zstd)
scheme@(guile-user)> (error-name 18446744073709551544)
$23 = "Src size is incorrect"
--8<---------------cut here---------------end--------------->8---

Downloading and uncompressing the same thing works like this:

--8<---------------cut here---------------start------------->8---
$ wget -qO - https://ci.guix.gnu.org/nar/zstd/rbb9h501zyf8mg1hz47plql80gsl99za-apr-1.7.0 | zstd -d |sha256sum 
e15bd1d4f4628969c461d99e23d27d76fb0d77b709eb393b9b2b2bcac67a8b19  -
--8<---------------cut here---------------end--------------->8---

Likewise with Guile + Guile-zstd:

--8<---------------cut here---------------start------------->8---
$ wget -qO - https://ci.guix.gnu.org/nar/zstd/rbb9h501zyf8mg1hz47plql80gsl99za-apr-1.7.0 | guile -c '(use-modules (zstd) (guix build utils)) (call-with-zstd-input-port (current-input-port) (lambda (port) (dump-port port (current-output-port))))' | sha256sum 
e15bd1d4f4628969c461d99e23d27d76fb0d77b709eb393b9b2b2bcac67a8b19  -
--8<---------------cut here---------------end--------------->8---

So my guess is that the connection was closed early for some reason,
leading to a decompression error down the road.

> guix pull: error: You found a bug: the program '/gnu/store/aaik6090bx4vdp9rn2g6w89296my5445-compute-guix-derivation'
> failed to compute the derivation for Guix (version: "128697d43c21eb229ff5413f1c4cf79ae1a9dcd4"; system: "x86_64-linux";
> host version: "1.3.0-1.771b866"; pull-version: 1).
> Please report the COMPLETE output above by email to <bug-guix@gnu.org>.

The bug here is that Guix should (1) handle transient networking issues
gracefully, and (2) retry downloads instead of aborting.

To be continued…

Thanks for reporting the issue!

Ludo’.

Send a report that this bug log contains spam.