#55377 [PATCH] gnu: recutils: Make it cross-compilable.

Message #5 received at submit@debbugs.gnu.org (full text, mbox, reply):

From: Maxime Devos <maximedevos@telenet.be>

To: guix-patches@gnu.org

Subject: [PATCH] gnu: recutils: Make it cross-compilable.

Date: Wed, 11 May 2022 23:25:50 +0200

[Message part 1 (text/plain, inline)]

TBD:

  * [ ] Commit message
  * [ ] Testing beyond ‘it builds’
  * [ ] Proper usage of "git format-patch"
  * [ ] 'guix style'
  * [ ] "guix refresh --list-dependents" and such

Just sending it now such that it doesn't disappear, intend to make it a
proper patch submission later ...

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 4472677ab3..ffadb1312b 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1569,18 +1569,17 @@ (define-public recutils
                
"14xiln4immfsw8isnvwvq0h23f6z0wilpgsc4qzabnrzb5lsx3nz"))))
     (build-system gnu-build-system)
 
-    (arguments '(#:configure-flags
-                 (list (string-append "--with-bash-headers="
-                                      (assoc-ref %build-inputs
"bash:include")
-                                      "/include/bash"))))
-
+    (arguments
+      (list #:configure-flags
+            #~(list (string-append "--with-bash-headers="
+                                    (search-input-directory %build-
inputs "/include/bash")))))
     (native-inputs `(("bc" ,bc)
-                     ("bash:include" ,bash "include")
                      ("check" ,check-0.14)
                      ("pkg-config" ,pkg-config)))
 
     ;; TODO: Add more optional inputs.
-    (inputs `(("curl" ,curl)
+    (inputs `(("bash:include" ,bash "include")
+              ("curl" ,curl)
               ("libgcrypt" ,libgcrypt)
               ("libuuid" ,util-linux "lib")))
     (synopsis "Manipulate plain text files as databases")

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 55377@debbugs.gnu.org (full text, mbox, reply):

From: Maxime Devos <maximedevos@telenet.be>

To: 55377@debbugs.gnu.org

Cc: control@debbugs.gnu.org

Subject: Re: [bug#55377] [PATCH] gnu: recutils: Make it cross-compilable.

Date: Thu, 12 May 2022 09:07:46 +0200

[Message part 1 (text/plain, inline)]

tags 55377 + moreinfo
thanks

Maxime Devos schreef op wo 11-05-2022 om 23:25 [+0200]:
> TBD:
> 
>   * [ ] Commit message
>   * [ ] Testing beyond ‘it builds’
>   * [ ] Proper usage of "git format-patch"
>   * [ ] 'guix style'
>   * [ ] "guix refresh --list-dependents" and such

Needs a rebase because of
<https://git.savannah.gnu.org/cgit/guix.git/commit/?id=b4c9a3d23b06d9441e96938b45fbf6669685955d>.
Still, a bash:include in native-inputs doesn't seem correct to me even
if it happens to work here -- e.g., what if the include headers are
architecture-dependent?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.