Report forwarded
to guix-patches@gnu.org: bug#53920; Package guix-patches.
(Thu, 10 Feb 2022 16:53:02 GMT) (full text, mbox, link).
Acknowledgement sent
to Hartmut Goebel <h.goebel@crazy-compilers.com>:
New bug report received and forwarded. Copy sent to guix-patches@gnu.org.
(Thu, 10 Feb 2022 16:53:02 GMT) (full text, mbox, link).
Subject: Re: bug#53920: [PATCH] gnu: lesspipe: Update to 2.02.
Date: Sat, 12 Feb 2022 10:48:27 +0100
Hello Hartmut,
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
> * gnu/packages/less.scm (lesspipe): Update to 2.02.
> ---
> gnu/packages/less.scm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
[...]
Thank you for the patch, I wasn't able to build it tho. Because the previsou git
tag was named "1.91" and the latest one is "v2.02", so the commit field from
git-reference need to be adjusted. Did you managed to build and test it on your
side before sending the patch?
Cheers,
- Brice
Added tag(s) moreinfo.
Request was from Ludovic Courtès <ludo@gnu.org>
to control@debbugs.gnu.org.
(Wed, 16 Feb 2022 15:02:01 GMT) (full text, mbox, link).
Information forwarded
to guix-patches@gnu.org: bug#53920; Package guix-patches.
(Sun, 20 Feb 2022 17:01:02 GMT) (full text, mbox, link).
Subject: Re: bug#53920: [PATCH] gnu: lesspipe: Update to 2.02.
Date: Sun, 20 Feb 2022 17:54:54 +0100
Am 12.02.22 um 10:48 schrieb Brice Waegeneire:
> Did you managed to build and test it on your
> side before sending the patch?
I though I did, but apparently I dd not. When looking at it, I saw that
quite some stuff changed under the hood, too. I’ll send a new patch
these days.
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
Information forwarded
to guix-patches@gnu.org: bug#53920; Package guix-patches.
(Tue, 22 Feb 2022 09:18:02 GMT) (full text, mbox, link).
Subject: Re: bug#53920: [PATCH] gnu: lesspipe: Update to 2.02.
Date: Tue, 22 Feb 2022 19:42:43 +0100
Hi Brice,
I'd appreciate your review on version 3 of the patch.
https://issues.guix.gnu.org/issue/53920#5
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
Information forwarded
to guix-patches@gnu.org: bug#53920; Package guix-patches.
(Sun, 27 Feb 2022 22:07:02 GMT) (full text, mbox, link).
Subject: Re: bug#53920: [PATCH] gnu: lesspipe: Update to 2.02.
Date: Sun, 27 Feb 2022 23:06:25 +0100
Hi Hartmut,
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
> * gnu/packages/less.scm (lesspipe): Update to 2.03.
> [arguments] Use new style. <phases>{configure} Adjust to updated source.
> {fix-makefile} New phase.
> {patch-tput-and-file} rename into …
> {patch-command-paths} this; patch other relevant scripts.
> [inputs] Add perl-archive-zip.
I haven’t tested it but it looks good to me on the surface. If it works
for you, please go ahead!
Thanks,
Ludo’.
Information forwarded
to guix-patches@gnu.org: bug#53920; Package guix-patches.
(Sun, 27 Feb 2022 22:23:01 GMT) (full text, mbox, link).
To: Maxime Devos <maximedevos@telenet.be>, 53920@debbugs.gnu.org
Subject: Re: [bug#53920] [PATCH v3] gnu: lesspipe: Update to 2.03.
Date: Mon, 28 Feb 2022 09:25:08 +0100
Am 27.02.22 um 23:22 schrieb Maxime Devos:
> To make package transformations work, can #$perl-archive-zip be avoided
> here? Maybe:
>
> (substitute* [...]
> ([...]
> (string-append [...] (assoc-ref inputs "perl-archive-zip") [...])))
FMPOV I can easily change this.
Anyhow, I don't understand, why this is necessary for package
transformations. I thought g-exps are the way to do it?
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
Information forwarded
to guix-patches@gnu.org: bug#53920; Package guix-patches.
(Mon, 28 Feb 2022 09:58:02 GMT) (full text, mbox, link).
Cc: 53920@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: Re: [bug#53920] [PATCH v3] gnu: lesspipe: Update to 2.03.
Date: Mon, 28 Feb 2022 10:56:57 +0100
Hello,
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
> Am 27.02.22 um 23:22 schrieb Maxime Devos:
>> To make package transformations work, can #$perl-archive-zip be avoided
>> here? Maybe:
>>
>> (substitute* [...]
>> ([...]
>> (string-append [...] (assoc-ref inputs "perl-archive-zip") [...])))
>
> FMPOV I can easily change this.
>
> Anyhow, I don't understand, why this is necessary for package
> transformations. I thought g-exps are the way to do it?
Actually, I think it should be the higher-level sexp:
#$(this-package-input "perl-archive-zip")
instead of
(assoc-ref inputs ...)
To answer your question, this is explained in
<https://guix.gnu.org/fr/blog/2021/the-big-change/>, in "G-expressions
and self-referential records".
Another nitpick: end-of-line comments only need a single semicolon, not
two.
Regards,
--
Nicolas Goaziou
Information forwarded
to guix-patches@gnu.org: bug#53920; Package guix-patches.
(Mon, 28 Feb 2022 12:32:02 GMT) (full text, mbox, link).
Am 28.02.22 um 10:56 schrieb Nicolas Goaziou:
> Actually, I think it should be the higher-level sexp:
>
> #$(this-package-input "perl-archive-zip")
How can one know, this one to use?
The blog post is more like a historical story, not a tutorial for
converting. It uses both
|#~`("--disable-color" ,(string-append "--with-gawk=" #$gawk)))) |
|and|
|#~(list (string-append "--with-gawk=" #$(this-package-input "gawk"))))) |
|The manual seems to mostly use the former way.|
||||
--
Regards
Hartmut Goebel
| Hartmut Goebel |h.goebel@crazy-compilers.com |
|www.crazy-compilers.com | compilers which you thought are impossible |
Cc: 53920@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: Re: [bug#53920] [PATCH v3] gnu: lesspipe: Update to 2.03.
Date: Mon, 28 Feb 2022 13:50:43 +0100
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
> Am 28.02.22 um 10:56 schrieb Nicolas Goaziou:
>> Actually, I think it should be the higher-level sexp:
>>
>> #$(this-package-input "perl-archive-zip")
>
> How can one know, this one to use?
>
> The blog post is more like a historical story, not a tutorial for
> converting.
Actually, it is. It a tutorial for converting to the new syntax, with
historical background so you know why you're doing it.
> It uses both
>
> |#~`("--disable-color" ,(string-append "--with-gawk=" #$gawk)))) |
>
> |and|
>
> |#~(list (string-append "--with-gawk=" #$(this-package-input "gawk"))))) |
Yes, it does. The former is an example of what was done before the
change, and the latter is demonstrating what we should now use.
> |The manual seems to mostly use the former way.|
Then this should be fixed.
Regards,
Reply sent
to Hartmut Goebel <h.goebel@crazy-compilers.com>:
You have taken responsibility.
(Wed, 02 Mar 2022 20:53:02 GMT) (full text, mbox, link).
Notification sent
to Hartmut Goebel <h.goebel@crazy-compilers.com>:
bug acknowledged by developer.
(Wed, 02 Mar 2022 20:53:02 GMT) (full text, mbox, link).
Cc: Maxime Devos <maximedevos@telenet.be>,
Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [bug#53920] [PATCH v3] gnu: lesspipe: Update to 2.03.
Date: Wed, 2 Mar 2022 21:52:19 +0100
Thanks for the review.
Changed to use #$(this-package-input, updated to 2.04 (which was
released meanwhile) and pushed as d8e353c11bf1999255a2471b553ce754800b074a
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
bug archived.
Request was from Debbugs Internal Request <help-debbugs@gnu.org>
to internal_control@debbugs.gnu.org.
(Thu, 31 Mar 2022 11:24:05 GMT) (full text, mbox, link).
Debbugs is free software and licensed under the terms of the
GNU Public License version 2. The current version can be
obtained from https://bugs.debian.org/debbugs-source/.