#50349 - [PATCH] packages: Add 'define-package' syntax.

Package	Source(s)		Maintainer(s)
guix		PTS Buildd Popcon

Message #8 received at 50349@debbugs.gnu.org (full text, mbox, reply):

Received: (at 50349) by debbugs.gnu.org; 3 Sep 2021 05:57:40 +0000
From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 03 01:57:40 2021
Received: from localhost ([127.0.0.1]:42580 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1mM2Cq-00061P-Iq
	for submit@debbugs.gnu.org; Fri, 03 Sep 2021 01:57:40 -0400
Received: from mail-wr1-f52.google.com ([209.85.221.52]:35810)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@gmail.com>) id 1mM2Co-00061C-CH
 for 50349@debbugs.gnu.org; Fri, 03 Sep 2021 01:57:39 -0400
Received: by mail-wr1-f52.google.com with SMTP id i6so6538216wrv.2
 for <50349@debbugs.gnu.org>; Thu, 02 Sep 2021 22:57:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:subject:in-reply-to:references:date:message-id:mime-version
 :content-transfer-encoding;
 bh=Y8B4Vw/RtQ7E7bSQ8H69adXa7h7sA223u5r+betwoVs=;
 b=Z81tbLYlhNoG5NwJe1ZW5uTyK00RwtzamWeYxymOR94prPzn4cNte86WWVT5sL6rkE
 pWjUR1RpOkVoKAWmZK8dbTQYsTGFj9BBMb75440F6vfvLP45N3QZdnKTkXr/FNiMqJV2
 ZMRyrk0wYR7O9wz0hAQXcygqZYVDmP6mcFTmYXtFyFRFf+qiVHGl5hM9Hm5+oHjeFYk4
 1S56p+xfDu+Nl370hFXZD1Rr/CWXGEreAmvhUEn9+/PTBj/AKy3ksSPiJ+A6iuK8/jV3
 RmpKDT2+l98f9nTpDvYwKbXsglpQ0hQtb2CBPJSxZEtlxUZX1Uh9fSJx87ugFkewPjmw
 f7Hg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:subject:in-reply-to:references:date
 :message-id:mime-version:content-transfer-encoding;
 bh=Y8B4Vw/RtQ7E7bSQ8H69adXa7h7sA223u5r+betwoVs=;
 b=Mnd5PPLMqzBbAYwEXoZiGFHPL6NpfKyFFAWa5SBBSoQNAWJpx3BzbDB25YaFIpxKyo
 yRvRLAxv8w96jx2in0haHi1/FTDay72j6OfK4ZMMELaMt1Q8+TF7p931UNM9pvFYw9y2
 +Qq6JPrh70g0ukAoYDFejjj0VEqWtsaStCeXnA4z2tBbbHE+wAAeA6GxlRm0WsOquTtw
 pzdZEky8BwEbx8qKHWkdS+URmjXSbQqekIieNg5HLXzyMPRsQkBeXm4YGlTrrSNjxuFU
 IDGUa1KZZpN9C5h0588mfSCHPsF9ZX681mh0RXOjw5jrcM36+M1MuOOwFILrwJ4XWq6t
 wBlA==
X-Gm-Message-State: AOAM532YIs8rhzgMCptvBukkmQKjzwFUX7M5INQI+wmLggPrb63nXxwi
 ZjAs1fbbfMbXgJG9OKCoY9OxDVjXIR/JLQ==
X-Google-Smtp-Source: ABdhPJwn9bomkuENq4IdnnYo1blbLl0uGWsTQhcAwJtXEzcDVNv2ph0Osd/Ln3bqWUHpDmSHHtrwEA==
X-Received: by 2002:adf:dd11:: with SMTP id a17mr1957321wrm.132.1630648652472; 
 Thu, 02 Sep 2021 22:57:32 -0700 (PDT)
Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e])
 by smtp.gmail.com with ESMTPSA id l2sm3489881wmi.1.2021.09.02.22.57.31
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 02 Sep 2021 22:57:32 -0700 (PDT)
From: zimoun <zimon.toutoune@gmail.com>
To: Sarah Morgensen <iskarian@mgsn.dev>, 50349@debbugs.gnu.org
Subject: Re: [bug#50349] [PATCH] packages: Add 'define-package' syntax.
In-Reply-To: <15d01b32313f5f2f291b120597719ae92bd26acd.1630639896.git.iskarian@mgsn.dev>
References: <15d01b32313f5f2f291b120597719ae92bd26acd.1630639896.git.iskarian@mgsn.dev>
Date: Fri, 03 Sep 2021 07:41:18 +0200
Message-ID: <86h7f21aip.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 50349
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Sarah,

On Thu, 02 Sep 2021 at 21:06, Sarah Morgensen <iskarian@mgsn.dev> wrote:

> (define-package my-favorite-package
>   (name "my-favorite-package")
>   ...)
>
> The purpose is primarily to save the horizontal indent, but IMO it looks
> better, and is marginally more clear for newcomers.  I think ideally we could
> eventually transition to using this syntax as the primary syntax and only use
> 'define-public' when necessary.

On one hand, I think it is a good idea; especially for newcomers.  On
the other hand, it will break ’git-blame’, isn’t it?

Therefore, I am not convinced such change is worth for ’gnu/packages/’.
Instead it seems worth only for teaching custom packages.  Explaining to
people in my labs, they are often confused between ’define’ and
’define-public’.  But then, there is two “styles” and people could be
more confused.

Well, my feelings are mixed.  Thanks for opening the discussion. :-)

Cheers,
simon

Display info messages

Send a report that this bug log contains spam.

debbugs.gnu.org maintainers <help-debbugs@gnu.org>. Last modified: Sun Dec 22 16:02:05 2024; Machine Name: wallace-server

GNU bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

#50349 [PATCH] packages: Add 'define-package' syntax.